Repository navigation
Transcript: center the turn footer between reply and next row; firmer table rows and first column #29860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Transcript: center the turn footer between reply and next row; firmer table rows and first column #29860
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9f8fc46
Transcript: center the turn footer between reply and next row; firmer…
teamleaderleo f925099
test: continuation spacing follows the footer's centring drop
teamleaderleo fd9b59c
Merge branch 'feat-cmux-next' into lane/other2-tx-footer-table
cmux-bot[bot] e5d513f
Merge branch 'feat-cmux-next' into lane/other2-tx-footer-table
cmux-bot[bot] 69261f6
Merge branch 'feat-cmux-next' into lane/other2-tx-footer-table
cmux-bot[bot] c26310c
Merge feat-cmux-next: the last footer keeps #30297's rest gap over th…
teamleaderleo 59e29f8
transcript: the last footer's line stays put over the composer's rest…
teamleaderleo 708c60b
Merge remote-tracking branch 'origin/feat-cmux-next' into lane/other2…
teamleaderleo 0967fa0
transcript: only the footer that ends the chat keeps its line over th…
teamleaderleo 2ed0d7e
test: the footer that ends the chat keeps the full turn gap (continua…
teamleaderleo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: This selector counts hidden bookkeeping articles as a following row, although
nextDrawnRowskips them. A final footer after hidden rows therefore keeps the 4px drop and shifts its line over the composer rest gap; exclude empty row siblings when detecting the logical end.Prompt for AI agents