Repository navigation
Transcript: center the turn footer between reply and next row; firmer table rows and first column - #29860
Conversation
… table rows and first column The turn footer's 24px line (time, Copy, Read aloud, More) sat 7px under the reply's last line and 16px over the next prompt. It now moves down inside its own row by --cv-footer-drop (4px; 2px over the same agent's next reply), taken off the row's bottom padding, so the room above equals the room below and every footer keeps its height. Markdown tables: row rules go from 4.5% to 9% of the text colour and every table's first column takes the label weight (500), as a labeled table's already did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-53d81bfaf9dd62794c6b
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a web and size checks: green Shipped in:
|
GitHub Actions
Inactive
|
Review (subagent claude-opus-5-5 medium): SHIP at 9f8fc46 Every footer row keeps its total height. The normal and last footers are 4 + 24 + 12 = 40, the same as 0 + 24 + 16 before, and the continuation footer is unchanged too. So model.ts's estimates and the running line the footer replaces still match. There are no specificity or order problems. The new assertion should fail on base (7 vs 16) and pass here (about 11 vs 12). The Follow-ups:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-53d81bfaf9dd62794c6b
GitHub Actions
Inactive
|
Review (subagent claude-opus-5-5 medium): SHIP at f925099 The new commit only brings transcript-continuation-spacing.test.ts's expectations in line with the footer drop:
Fast checks at this head pass 98 of 98 tests in 8 files: transcript spacing, turn footer, continuation spacing, table actions and copy, rowEstimates, compaction rows and message placement. run |
|
Review (next-review patch-id; carried): SHIP at fd9b59c The independent SHIP at f925099 carries to this head: the PR's own change ( |
|
Found 6 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
|
Review (next-review patch-id; carried): SHIP at 69261f6 The independent SHIP at f925099 carries to this head: the PR's own change ( |
…e composer The conflict was in agent-pane-transcript-spacing.test.ts. #30297 rests the last row REST_GAP (56px) over the composer, so this PR's centring check now covers the footers between turns only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-53d81bfaf9dd62794c6b
GitHub Actions
Inactive
GitHub Actions
Inactive
… gap After the base merge, agent-pane-transcript-spacing's REST_GAP check read 4px off (60 vs 56): the footer drop moved the last footer too. It has no next row to centre on, so it keeps base's position. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-53d81bfaf9dd62794c6b
GitHub Actions
Inactive
GitHub Actions
Inactive
…e rest gap isLastFooter also marks a footer followed by an incoming agent's message, which still has a next row to centre on (transcript-continuation-spacing peer: 16 vs 12). The drop is off only when no row follows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-53d81bfaf9dd62794c6b
GitHub Actions
Inactive
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
GitHub Actions
Inactive
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="webviews/src/agent-session/acpmux/conversation/conversation.css">
<violation number="1" location="webviews/src/agent-session/acpmux/conversation/conversation.css:4930">
P2: This selector counts hidden bookkeeping articles as a following row, although `nextDrawnRow` skips them. A final footer after hidden rows therefore keeps the 4px drop and shifts its line over the composer rest gap; exclude empty row siblings when detecting the logical end.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| } | ||
| /* The footer that ends the chat has no next row to centre on: under it is the rest gap over the | ||
| composer (model.ts REST_GAP), so its line stays put. */ | ||
| .acpmux-row.acpmux-turnSummary.acpmux-row--last-footer:not(:has(~ .acpmux-row)) { |
There was a problem hiding this comment.
P2: This selector counts hidden bookkeeping articles as a following row, although nextDrawnRow skips them. A final footer after hidden rows therefore keeps the 4px drop and shifts its line over the composer rest gap; exclude empty row siblings when detecting the logical end.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At webviews/src/agent-session/acpmux/conversation/conversation.css, line 4930:
<comment>This selector counts hidden bookkeeping articles as a following row, although `nextDrawnRow` skips them. A final footer after hidden rows therefore keeps the 4px drop and shifts its line over the composer rest gap; exclude empty row siblings when detecting the logical end.</comment>
<file context>
@@ -4921,11 +4921,14 @@ article.acpmux-row:not(:has(> :not(.acpmux-row__gap))) {
+}
+/* The footer that ends the chat has no next row to centre on: under it is the rest gap over the
+ composer (model.ts REST_GAP), so its line stays put. */
+.acpmux-row.acpmux-turnSummary.acpmux-row--last-footer:not(:has(~ .acpmux-row)) {
--cv-footer-drop: 0px;
- padding-bottom: var(--cv-turn-gap);
</file context>
…tion spacing) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-53d81bfaf9dd62794c6b
GitHub Actions
Inactive
|
Review (subagent claude-opus-5-5 medium): SHIP at 2ed0d7e This head merges feat-cmux-next, which brings #30297's REST_GAP. The footer that ends the chat now keeps its line in place over that rest gap: Rows are direct The table changes are as before. The test expectations match the CSS. Follow-ups:
|
#29860 centres a turn footer between the reply's last line and the next prompt by padding the footer row. On the grid the footer has no height and its action row is laid in the gap, so the resolution keeps the grid footer. A footer over a prompt now sits in the middle of the turn gap, raised by half the reply's half-leading. Continuation and last footers stay centred in the block gap, which restBand assumes. The spacing test keeps the grid measures and adds #29860's centring check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…31130) #29860 moved the turn footer's line down 4px inside its row (--cv-footer-drop), taken off its bottom padding, so the footer-to-sender gap is 2px under the turn gap instead of 2px over it. The gallery play still expected gap + 2. Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…d gaps (#31946) * base red: transcript continuation and fold tests read the stack's grid gaps (#27580) Both browser tests predate #27580, which moved every outer gap between transcript rows into the virtual stack (design/grid.md 5.5). The continuation test still asked for #26755's half gap and #29860's footer drop inside the row; the fold test counted every placed gap, and the row's own gap target, as blank space. Both now take their values from the grid tokens (gridLength). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0 * test(chat): the fold check allows only the gaps transcriptGap places (no inner gap) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Two small transcript CSS fixes Leo asked for on 2026-10-31.
1. The turn footer sits in the middle of its gap.
Leo: "when i hover this little whatever time ago copy sound ellipsis thing should be centered in between the two things you're saying in between / so padding after == padding before that kinda thing all around"
Before: the footer's 24px line (time, Copy, Read aloud, More) was 7px under the reply's last text line and 16px over the next prompt's bubble. Now the line moves down inside its own row by
--cv-footer-drop(4px, or 2px over the same agent's next reply, whose first line has the same half-leading). That amount comes off the row's bottom padding. Room above and below is now about 11px and 12px, and over the composer it is the same. Every footer row keeps its height, so model.ts's estimates still match and the running-turn line the footer replaces doesn't jump.2. Tables are less faint.
Leo: "at least the left side of our table if we're gonna have it should be more distinctly there it's all almost a bit too faint"
Test:
webviews/test/agent-pane-transcript-spacing.test.tsnow measures the room above and below the first and last footer: from the reply's last line box to the footer line, and from the footer line to the next bubble or the composer. It requires the two to be within 1.5px. On base they are 7 and 16.Risk: CSS only, in
conversation.css. No footer or table geometry outside the agent-pane transcript changes; Chief views keep their own.cv-table. Not covered here:Spec: design/chat-transcript.md (transcript rhythm).
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Centers the transcript turn footer between the reply's last line and the next row, and makes markdown tables read more distinctly.
Tests
Risk: CSS-only in
conversation.css; no transcript geometry outside the agent pane changes, and Chief views keep their own table styles.Written for commit 2ed0d7e. Summary will update on new commits.