Skip to content

fix(agent-pane): show workflow progress in tray and inspector (carry of #27886) - #29777

Merged
teamleaderleo merged 48 commits into
feat-cmux-nextfrom
lane/ux-carry-27886
Nov 1, 2026
Merged

teamleaderleo merged 48 commits into
feat-cmux-nextfrom
lane/ux-carry-27886

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Carries #27886 (its owner's lane VM no longer resolves). It keeps that PR's commits and authorship, merges the current base, and fixes the conflicts against base's newer tray design.

Takes back #28164: replaces its whole-list progress dependency in App.tsx with keyed AgentProgressStore subscriptions, so a usage-only update notifies only the changed agent instead of rebuilding every row.

Leo, 2026-10-29: "i also want all those ui fixes/improvements in and stuff too along with more think tanks to improve stuff too after learning all those ui dev things".

What it does

  • Running workflows show their completed/started agent counts, failed and queued agents in the default running tray and in Session Info. Before, only the alternate transcript card showed them.
  • Progress updates arrive through keyed per-agent subscriptions (subagents/agentProgressSource.ts, agentProgressStore.tsx). A usage-only snapshot touches one row and rebuilds no list. Compatibility snapshots, versioned snapshots and session switches keep their progress.
  • SW-04: when the owning root is identified late, its progress identity and pending delta are dropped, and real workers and grandchildren stay.
  • The Inspector's row and its hover card read the same live progress.

Changes in this carry (base merge)

Observed / Not run

  • Local: bun test test/subagent-tray.test.tsx test/agent-pane-workflow-progress.test.tsx test/inspector-subagent-card-stays.test.tsx test/subagent-tray-trailing.test.ts passes (47 pass, 0 fail). bun run check is clean.
  • Not run locally: the Chromium tray geometry suite, which goes to CI at this head.
  • No screenshots: Leo tries the build.

Changelog

  • Fixed: running workflows show their agent counts in the running tray and in Session Info.

Design: running tray.

🤖 Generated with Claude Code

Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Shows running workflow progress (completed/started counts, failed, queued) in the default running tray, the Inspector's row, and their hover cards. Replaces the whole-list progress dependency in App.tsx with keyed per-agent AgentProgressStore subscriptions, so usage-only updates re-render just the changed agent row instead of rebuilding every row.

  • Direct snapshots carry keyed progress deltas from the event fold; bridge/gallery snapshots keep the same keyed contract, with a compatibility path for unversioned snapshots, and reset their store per session.
  • A late root identification drops phantom progress while real workers and grandchildren stay.
  • Since the base merge, no subagent list shows tokens or tool uses (only the Inspector's Context does); the tray and Inspector rows read the same live store.

Observed / Not run

Written for commit cbc4c94. Summary will update on new commits.

View guided diff Turn on auto-fix

teamleaderleo and others added 30 commits October 30, 2026 03:06
Resolve App and tray conflicts while preserving keyed progress updates and page-clock migration.

Agent-Session: https://cmux.com/deeplink/agent?id=aid-f518dd20e1523aa0398c
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at fcb542e

SHIP at fcb542e

Visual verdict: no images; Leo tries the build

  1. [P2] [follow-up] webviews/src/agent-session/acpmux/App.tsx:7453 — Bridge deltas can be lost when React batches snapshots. If an update for agent A is followed by another snapshot before rendering, only the latter delta reaches this effect, leaving A’s progress stale. Apply deltas when received or accumulate them before rendering. Add coverage for consecutive receives without an intervening render.
  2. [P2] [follow-up] review/pr.body:25 — No after screenshots were supplied; tray and Inspector appearance remain visually unverified.

Validation: all 13 changed files passed syntax parsing; isolated progress-store checks passed. React tests could not run because Bun and dependencies are unavailable.

Follow-ups:

  • Preserve bridge progress deltas across batched snapshots.
  • Check tray and Inspector visuals in the build.

Base added the agent's kind to the Inspector's hover card (#29276); the
card that subscribes to live progress keeps it. The workflow test now checks
only that Stop's track and the chevron stay last, and
subagent-tray-trailing owns the column order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-63b9964940c20354b639
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at a206513

SHIP at a206513

Visual verdict: no images; Leo tries the build

  1. [P2] [follow-up] webviews/src/agent-session/acpmux/subagents/SubagentTray.tsx:367 — No after screenshots were supplied. Verify live progress in the tray and Inspector, including narrow layouts.

No blocking code findings. Changed files parsed successfully; isolated progress-store checks passed. Full tests were unavailable because Bun and project dependencies are absent.

Follow-ups:

  • Capture and review tray and Inspector screenshots.

Base now leaves usage out of every subagent list, the Inspector's
included; only Context says tokens. So useAgentProgress always reads
without usage, and the usage option and progressUsage prop go away. The
agents pill is gone from base (#29792), so the progress store's comment no
longer names it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-63b9964940c20354b639
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 469b43b

SHIP at 469b43b
Visual verdict: no images; Leo tries the build

  1. [P2] [follow-up] webviews/src/agent-session/acpmux/subagents/SubagentTray.tsx:367: After screenshots are missing. Capture the tray and Session Info at narrow and wide widths.

No blocking code findings. Syntax checks and focused store checks passed. React tests could not run because Bun and dependencies are absent.

Follow-ups:

  • Capture after screenshots for the tray and Session Info.

@cursor

cursor Bot commented Nov 1, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 01:51 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 01:56 Inactive
@blacksmith-sh

This comment has been minimized.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base dd61ce5 to this head): SHIP at d2b719d.

No P1/P2 findings.

…ry-27886

# Conflicts:
#	webviews/test/session-info-subagent-card-stays.test.tsx
…ion Info

Base turned workflows on by default (#30192), so a running workflow leaves
the tray; stopped building rows in a folded tray (#29250); and renamed the
Session Info aside (#29921). The App tests turn workflows off as the
workflowLabs push would, open the tray for their chats, and read
aside.acpmux-session-info.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-63b9964940c20354b639
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at eba6a78

Delta review covering:

Fleet: 96/96 pass across the tray and Session Info suites at eba6a78.

Follow-ups:

  • Cover the workflows-on default: a keyed progress update reaching the workflow card and Session Info's Background tasks, and late root retirement there.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base da249ca to this head): SHIP at eba6a78.

No P1/P2 findings.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 16:08 Inactive
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (next-review patch-id; carried): SHIP at cbc4c94

The independent SHIP at eba6a78 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (ee268feabd1e5cc2) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.

@teamleaderleo
teamleaderleo merged commit 45b916e into feat-cmux-next Nov 1, 2026
186 of 189 checks passed
@teamleaderleo
teamleaderleo deleted the lane/ux-carry-27886 branch November 1, 2026 17:00

This branch was previously deployed

1 inactive deployment
ci-routing-agent — cbc4c94f Deployed Nov 1, 2026 by cmux-bot[bot] via cmux-tui tree preflight #96823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant