Skip to content

fix(agent-pane): carry workflow progress tray and inspector - #28164

Merged
cmux-bot[bot] merged 5 commits into
feat-cmux-nextfrom
lane/ux-adopt-27886
Oct 30, 2026
Merged

cmux-bot[bot] merged 5 commits into
feat-cmux-nextfrom
lane/ux-adopt-27886

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Carry-forward of orphan #27886, rebased onto current feat-cmux-next after resolving its conflict with the base.

Running workflows now show completed/started agent counts, failed and queued agents, and token usage in the default running tray and Session Info inspector. Existing action text remains, with progress beneath it so long names do not crowd out counts. The refresh key includes usage and progress fields so successive updates re-render.

The original commits and authorship are preserved via cherry-pick: c2750629a5c and a68fd2cadbe.

Validation: webviews/test/subagent-tray.test.tsx covers tray and inspector updates, missing/zero progress, and unrelated-row preservation. Fleet checks pending.

Gallery: agent-pane.subagent-tray/workflow-progress
Gallery / captures: agent-pane.subagent-tray/workflow-progress; before/after media-tour labels requested from ux-owner.

Risk: row height increases only when progress exists; existing action, open, Stop, and spinner behavior remain unchanged. No timer or observer is added.

Closes orphan #27886 after this replacement lands.

Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Carry-forward of orphan #27886, rebased onto feat-cmux-next.

Running workflows now show completed/started agent counts, failed and queued agents, and token usage in the default running tray and Session Info inspector. Progress appears beneath the existing action text so long names don't crowd out the counts.

  • Progress appears only when counts or usage exist, so rows without progress keep their current height and behavior.
  • The refresh key includes usage and progress fields, so successive updates re-render.
  • Tests in webviews/test/subagent-tray.test.tsx cover tray and inspector updates, missing or zero progress, and preservation of unrelated rows.

Closes orphan #27886.

Written for commit b0fb0d1. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 94175eb: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28164 -f ref=lane/ux-adopt-27886 -f platform=macos -f backend_mode=local

Passes: CI passes on b0fb0d1635.

CI passes on b0fb0d1635 (run 41116469274 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

web and size checks: green

Gallery before/after for b0fb0d1: the capture produced no images (run).

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test/model-menu-submenu-up.test.ts/model-menu-submenu-up.test View Logs
test/model-menu-submenu-up.test.ts/model-menu-submenu-up.test View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 7defba3

SHIP

  1. No blocking findings.

@teamleaderleo teamleaderleo added media-tour-mac media-tour Run the cmux-next UI tour (cmux-next-media.yml) on every push and removed media-tour Run the cmux-next UI tour (cmux-next-media.yml) on every push media-tour-mac labels Oct 30, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 94175eb

SHIP

No actionable findings. Reviewed all 135 changed lines; all eight files match the diff’s head hashes.

Tests were not run: Bun and dependencies are unavailable. Forum acknowledgments also failed because acpmux is unavailable.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Workflow progress tray before/after

Fleet Chromium capture run 41098232419 at exact head 94175eb3293408b1d028db4a0d478dbc9b54c1d1; base is be2201cda9240e52c3c6ce01dc7a4180f7af3ea9. The base frame uses the existing one-running tray state; the after frame is workflow-progress.

Theme Before After
Dark Before dark After dark
Light Before light After light

Visual verdict: SHIP. The after frame preserves the tray row, adds the 37/101 agents · 2 failed · 4 queued · 1.2M tokens progress line, keeps the compact row layout, and retains readable contrast in both themes.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Fleet Chromium capture run 41098232419 at exact head 94175eb. Before/after media: https://raw.githubusercontent.com/manaflow-ai/cmux/pr-media/28164/before-dark.png https://raw.githubusercontent.com/manaflow-ai/cmux/pr-media/28164/before-light.png https://raw.githubusercontent.com/manaflow-ai/cmux/pr-media/28164/after-dark.png https://raw.githubusercontent.com/manaflow-ai/cmux/pr-media/28164/after-light.png

Visual verdict: SHIP; workflow-progress adds 37/101 agents, 2 failed, 4 queued, 1.2M tokens while retaining compact row layout and readable contrast in dark and light.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent review (gpt-6.1-sol high) at b0fb0d1: SHIP.

@cmux-bot
cmux-bot Bot merged commit c09765e into feat-cmux-next Oct 30, 2026
174 of 181 checks passed
@cmux-bot
cmux-bot Bot deleted the lane/ux-adopt-27886 branch October 30, 2026 20:05
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This branch had an error being deployed

1 failed (outdated) and 2 inactive (1 outdated) deployments
ci-routing-agent — b0fb0d16 Deployed Oct 30, 2026 by teamleaderleo via wait for same-key tree publisher #84744
artifacts — 7defba37 Deployed Oct 30, 2026 by teamleaderleo via publish the Windows daemon to R2 #82187
sentry-dsyms — 7defba37 Deployed Oct 30, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #82187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

media-tour Run the cmux-next UI tour (cmux-next-media.yml) on every push media-tour-mac risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant