Skip to content

test(next): investigate expanded tool-group card height - #29763

Closed
teamleaderleo wants to merge 6 commits into
feat-cmux-nextfrom
lane/stranded-tool-group-card-height
Closed

teamleaderleo wants to merge 6 commits into
feat-cmux-nextfrom
lane/stranded-tool-group-card-height

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

HOLD: The reported production stretch is not reproduced. Awaiting the original screenshot/build from the coordinator; this PR must not be treated as a demonstrated fix.

Leo reported: “WHY THE F*** DOES IT FING EXTEND TO THE BOTTOM WITH FING 0 INFO”.

Adds a browser fixture that opens a two-row tool group at the end of the virtual transcript and checks its card geometry. The fixture explicitly activates the gallery card presentation. The current shipped presentation uses flat rows following #29638.

Independent review found the proposed sizing declarations redundant in the current block layout; those declarations have been removed. Only the fixture and test remain. The production cause remains unsubstantiated. Transcript bottom-space is unchanged. Reference: design/chat-transcript.md.

Validation: focused browser fleet run https://github.com/manaflow-ai/cmux/actions/runs/41250208261 at d66bd61 and webview checks pending. The subagent SHIP reports no blocking regression; it does not establish that this fixes the reported stretch.

Agent session: agent session
🤖 Generated with Claude Code

Agent-Session: Agent session: [agent session](aid-b41b4b9149b0314c3c0b)
@cursor

cursor Bot commented Oct 31, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review bdfe37c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr29763 -f ref=lane/stranded-tool-group-card-height -f platform=macos -f backend_mode=local

Gallery before/after for bdfe37c: 16 states rendered, 17 images differ, 684 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41250285428 -R manaflow-ai/cmux -n gallery-advisory-29763-bdfe37c49db5f70fd5121e3085a654c211262dc1 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.tool-group-card-height/default Apple System Colors Light new 0% own ToolGroupCardHeight.gallery.tsx
agent-pane.tool-group-card-height/default Apple System Colors new 0% own ToolGroupCardHeight.gallery.tsx
agent-pane.access-offer/turn-no-credits Apple System Colors Light unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.access-offer/turn-no-credits Apple System Colors unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.access-offer/turn-low-credits Apple System Colors Light unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.access-offer/turn-low-credits Apple System Colors unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.access-offer/turn-no-offer Apple System Colors Light unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.access-offer/turn-no-offer Apple System Colors unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/batches Apple System Colors Light changed 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/batches Apple System Colors changed 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/batch-raw Apple System Colors changed 0.0002% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/batch-raw Apple System Colors Light changed 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/batch-sending Apple System Colors Light changed 0.022% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/batch-sending Apple System Colors changed 0.0209% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/look-guide Apple System Colors Light changed 0.0023% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/look-guide Apple System Colors changed 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/look-list Apple System Colors changed 0.0018% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/look-list Apple System Colors Light unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/look-flat Apple System Colors changed 0.402% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.acpmux-batch-send/look-flat Apple System Colors Light changed 0.0007% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.addressed-message/relayed Apple System Colors Light unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.addressed-message/relayed Apple System Colors unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/unicode-boundary Apple System Colors Light unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/unicode-boundary Apple System Colors unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/sent Apple System Colors Light changed 0.0242% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/sent Apple System Colors changed 0.0224% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/lanes Apple System Colors Light unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/lanes Apple System Colors unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/sent-subagents Apple System Colors Light unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/sent-subagents Apple System Colors unchanged 0% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/sent-hover Apple System Colors Light changed 0.0312% same-folder ToolGroupCardHeight.gallery.tsx
agent-pane.agent-message-row/sent-hover Apple System Colors changed 0.0285% same-folder ToolGroupCardHeight.gallery.tsx

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026
@cursor

cursor Bot commented Oct 31, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent): SHIP at b10793e

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent): SHIP at 3c7e1d3

@teamleaderleo teamleaderleo changed the title Fix expanded tool-group cards stretching below content test(next): investigate expanded tool-group card height Oct 31, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Superseded by merged #29703 (14d7ce7), which fixes transcript bottom-room behavior for expanded tool calls at the end and covers scrolling away and back. This PR did not contain a production fix: independent review showed its initial sizing CSS was ineffective in the current block layout, and the corrected geometry fixture did not reproduce the reported stretch. The owner should close this PR rather than land a no-op/test-only change.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closed for its lane: superseded by #29703, which has merged (14d7ce7).

This branch was previously deployed

1 inactive deployment
ci-routing-agent — bdfe37c4 Deployed Oct 31, 2026 by teamleaderleo via cmux-tui tree preflight #91925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant