Repository navigation
Transcript: keep bottom room after tool collapse - #29703
Conversation
…s the whole turn Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
…copy skips hidden draft calls Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
… row now) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Passes: CI passes on CI passes on Written by web and size checks: green Shipped in:
|
|
Review (subagent): SHIP at c322f89 |
1 similar comment
|
Review (subagent): SHIP at c322f89 |
|
Review (subagent): SHIP at 4ee8970 |
1 similar comment
|
Review (subagent): SHIP at 4ee8970 |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (subagent): SHIP at 6bc2412 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d769bae91020b1c63442
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d769bae91020b1c63442
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d769bae91020b1c63442
|
Review (subagent): SHIP at 23f20a4 |
|
Review (subagent): SHIP at fd1fe34 |
…nscript-bottom-space-keep
|
Review (subagent): SHIP at ea3db30. Independently inspected the diff and carried steer/footer changes. The observed-shrink guard prevents immediate reader scrolling from releasing bottom room before collapse measurement; collapse retains the clicked line and extent, and base expansion behavior remains intact. No blocking findings. Fleet validation pending. |
|
Review (subagent): SHIP at 6b9cb38. Verified the final delta restores the incoming report continuation marker; personal-steer retention explicitly excludes incoming reports. Prior full review found no blocking issues in retained bottom room, immediate-scroll handling, base expansion motion, and carried steer/footer behavior. Fleet at the preceding head passed both new bottom-room cases and the personal-steer browser case; the corrected report fixture is being rerun. |
…ript-bottom-space-keep
|
Review (subagent): SHIP at a83f3e8. Independently inspected the full two-file diff and base integration. The retention implementation and regression tests are unchanged; incoming App changes are outside VirtualTranscript. No blocking findings. diff --check passed; final automated webview verdicts pending. |
|
Found 4 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
A tool call expanded at the transcript end now keeps that scroll extent when it collapses. Its header stays in place, and scrolling up and back—including scrolling before the collapse is first measured—keeps the blank room. New content can consume the room; Send, Jump to latest and switching chats reset it.
The assigned request, forwarded from Leo: “the bottom space added when a tool call expands must stay after it collapses, and after scrolling up.” Leo also clarified: “i literally said dont fold the steer”.
This builds on the landed #29686 expansion animation and #29740 steer/footer behavior. A browser regression verifies that the personal steer and assistant reply immediately before it stay visible across Worked-for toggles. The PR changes only scroll-room retention and its browser tests.
Design reference:
leo-workspace/design/chat-transcript.md, Tool expansion at the bottom, updated for this behavior. Expansion keeps base's single compositor move; tool collapse retains the expanded end. No new timers or observers. Risk is scroll anchoring during a collapse; browser coverage measures extent, header movement and immediate reader input.Validation:
6b9cb38aec80f09f23f685a0999e1fe1ca0890e4: fold-anchor browser tests, popover animation audit, steer continuity and turn/footer tests.a83f3e8b482fc03abc06cd13157e6f53e867ef66leaves the retention implementation and tests unchanged. Independent exact-head review passed; all eight automated webview base-check verdicts passed at the final head.git diff --checkpasses.Agent session: agent session
🤖 Generated with Claude Code