[teamleaderleo]

Summary

This is the follow-up from the review of #28940 at b7eb1d4 (receipt: #28940 (comment)). That review was SHIP, with one P2 follow-up.

The chat-open bench's click_subagent copied the app's debug.agent_pane click reply, then overwrote its clicked boolean with the subagent's name. So a bench artifact could not show a press that didn't happen. The reply now keeps the app's clicked and error fields as they came back, and records the subagent it clicked under subagent. The test fake now answers with clicked: true, as the app does, and the test checks that the flag survives.

Testing

• python3 scripts/cmux-next/tests/test_chat_open_bench.py: all 16 tests pass.

Observed / Not run

• Observed: the unit tests above, and the app's click reply shape in DebugAgentPaneClick.swift ("clicked": .bool(pressed)).
• Not run: a fleet bench at this head.

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes the chat-open bench's click_subagent so bench artifacts keep the app's real clicked flag.

Previously, the function overwrote the reply's clicked boolean with the subagent's name, so an artifact could show a press that didn't happen. It now records the subagent under subagent and leaves clicked and error untouched. The test fake now returns clicked: true like the app does, and the test verifies the flag survives.

^{Written for commit d4623de. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review c689604: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr29383 -f ref=lane/chatopen-subagent-click-flag -f platform=macos -f backend_mode=local

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4122123816401 (2bace7350f)
• cmux NEXT nightly 1.0.0-nightly.4122185214701 (3531e040b6)
• cmux NEXT nightly 1.0.0-nightly.4122410931101 (5fb4ac7bc0)
• cmux NEXT nightly 1.0.0-nightly.4122444305401 (b3b2b165e9)

[blacksmith-sh]

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/ test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

Review (the owner lane's independent review, at its land request): SHIP at c689604

Recorded by lane-gh-broker from this PR's owner lane, which asked to land this exact head after its independent review. next-autoland lands it once every red is the base's; a BLOCK at this head, a HOLD line or a hold label still stops it.

[teamleaderleo]

Review (next-review patch-id; carried): SHIP at 100ab35

The independent SHIP at c689604 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (e6ccc0c297b20d60) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.

[teamleaderleo]

Review (codex gpt-6.1-sol high fast, router-review): SHIP at d4623de

This head is the lander's update-branch for stale guards. The full diff was reviewed. No correctness findings.
Follow-ups: none