Repository navigation
cmux NEXT Chief chat: reply threads look like Messages, no header (part of #26686) - #26708
Conversation
… (red, #26686) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Fixes #26686) The thread view drew the host's thread header above the root: the root's first line as raw Markdown (link source visible) and an Open / Unassigned status row. Messages has no header; the root bubble is the view's first row. Home no longer installs the header hooks, and the rename / assign / resolve UI behind them is gone. The daemon's thread object is unchanged and stays in Channels. Copy Link and permalinks are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub Actions
Inactive
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green Shipped in:
|
|
Bead |
…ls resolved/title step, the header drive says whether a thread is open Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
GitHub Actions
Inactive
|
Review (subagent, correctness first) at 2c64a88:
|
This comment has been minimized.
This comment has been minimized.
GitHub Actions
Inactive
GitHub Actions
Inactive
…ext-26686-imessage-replies
austinywang
added
the
media-tour
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
…ext-26686-imessage-replies
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Found 3 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
…ext-26686-imessage-replies
GitHub Actions
Inactive
GitHub Actions
Inactive
…ext-26686-imessage-replies
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (Codex correctness review): SHIP at 8aa0b7f Fresh independent correctness review of all 13 feature files against base 378fb1a found no blockers. Header removal preserves root-first rendering, Copy Link, nested replies, permalink paging, send and Escape. Incoming base changes introduce no conflicting Home behavior. Diff whitespace passed. This review does not claim executed tests or visual verification; those exact-head fleet runs are in progress. |
|
Fresh-home launch of
Screenshot withheld: the pr-media privacy check or upload refused it.
|
|
Review (Codex correctness review): SHIP at 11abb01 Fresh independent review of all 13 feature files against base 3017ef1 found no correctness blockers. The thread retains its original bubble, Copy Link, nested replies, permalink paging, send and Escape. No dangling header references or integration conflicts were found. Whitespace validation passed. Runtime and visual verification are being repeated separately on this exact head; no local builds or tests were run. |
|
Review (Codex correctness review): SHIP at 2b1a1ae Fresh independent review of all 13 feature files against e56ae9e found no correctness blockers. Header-only code is removed while link state, root rendering, nested replies, permalink paging, send and Escape remain intact. The base merge introduces no conflicting Home changes. Whitespace validation passed. Exact-head runtime and visual evidence are being collected separately; no local native builds or tests ran. This normal merge also includes the base repair from #29600 for the inherited fast-tier test compiler errors. The failing CloudMachineChangeStateTests and AddMachineFlowTests were identical to base before the merge. Failure log: https://github.com/manaflow-ai/cmux/actions/runs/41235495460/job/124638462594. The original cmux-next checks blocker passed on the preceding head; the current-head checks will judge this merge anew. |
|
Exact-head verification at 2b1a1ae (base e56ae9e, owner austinywang, agent Codex): Fleet step 9bb58740a041fec9466ab5da executed 39 tests across 11 focused suites, all passed, exit 0, workspace reset confirmed. This includes the two HomeThreadViewCaptureTests regressions plus reply selection, nested quote rendering, Escape, send motion/capture, fixture parity, gaps, video, agent folding and links. Capture artifact: sha256:bbc0ed0ed16eb7f15b120b06692f3d7b60fa16c6b857d676ca5646985e7ebb06. Primary and independent visual review: PASS for thread presentation. The original bubble appears first, both replies are legible, and no duplicate Markdown title or Open/Unassigned header appears. This is an offscreen macOS Home view with a mock owner; live interaction and composer appearance are outside the capture verdict. Public image publication remains withheld by the existing privacy check because the host lacks an agent-authors list. No privacy check was bypassed. The normal push passed its hooks with no new violations. Namespace and whitespace checks passed. Repository preflight still reports inherited localization parity and workspace package-grouping debt; no fix to unrelated base inputs was added here. Native compilation/tests ran only on the fleet. The exact-head tagged build and fresh-Home launch are in progress. |
|
Fresh-home launch of
Screenshot withheld: the pr-media privacy check or upload refused it.
|
|
Review (Codex correctness review): SHIP at fae73a5 Fresh independent correctness review inspected all 13 feature files against base c27fba5. No correctness blockers found. Root rendering, Copy Link, nested replies, permalink paging, send and Escape remain intact after header removal. No dangling header references or conflicting Home integration found. Reviewer: Codex subagent review_pr26708_latest; PR owner austinywang; #26708. Whitespace validation passed. No builds, tests or UI actions were performed by the reviewer; exact-head runtime verification is separate. |
|
Exact-head verification at fae73a5 (base c27fba5, PR owner austinywang, agent Codex; #26708): Fleet step dda8e42457cf61a8a1d8d377 executed 39 tests across 11 focused suites, all passed, exit 0 and workspace reset confirmed. This includes HomeThreadViewCaptureTests (both tests), HomeThreadEscapeTests, HomeThreadSendMotionTests, HomeThreadSendCaptureTests, LabFixtureParityTests, HomeReplyToSelectionTests, ThreadQuoteBubbleTests, HomeStandAloneGapTests, HomeVideoViewerTests, HomeAgentMessageFoldTests and HomeAutoLinksTests. Capture artifact: sha256:fc602dcfe9c7796715864413c333167b2980b2f87d312703d89661052e02b1b7. Primary and independent Visual PASS for the supplied dark-mode fixture: original bubble first, both replies legible, no duplicate raw-Markdown title or Open/Unassigned header. This is the real macOS Home view rendered offscreen over a mock owner; light mode, live interaction, composer behavior, scrolling and animation remain unverified. Public image publication remains withheld by the existing privacy check because the host lacks an agent-authors list. No privacy check was bypassed. The cmux-next checks job, including god files, concurrency, crash safety, localization and pushed-commit violations, is green on this head: https://github.com/manaflow-ai/cmux/actions/runs/41240220114/job/124652433367 . Exact-head Release compile also passed. Static preflight ran all 11 selected checks; inherited repository-wide localization parity and workspace grouping remain red; XCStrings structure, default-value parity, syntax and the other selected checks passed. No native builds, Swift tests, bun or node ran on the person’s Mac. A separate base-only fleet comparison (step 484a39cee2f5d51694608524 at merged ancestor e56ae9e) reproduced SidebarGroupEdgePaddingTests, TabLookupGuardTests, TipAppTrackTests and SidebarEditModeTests failures; exit 1, workspace reset confirmed. HomeUnreadBlueDotTests, GhosttyGlassMinimumContrastTests, ReduceMotionLoopTests and MainPaneWindowCornerTests passed in that comparison; I am not claiming those older cancelled-run assertions have base runtime proof. These results are separate from the current-head focused verification. |
|
Fresh-home launch of
Screenshot withheld: the pr-media privacy check or upload refused it.
|
…ext-26686-imessage-replies
|
Review (Codex review_pr26708_latest): SHIP at 8821da4 Fresh correctness-first review of all 13 feature files against base 4f957ed found no blocking defects. Root rendering, Copy Link, nested replies, permalinks, send and Escape remain intact. The incoming binding-before-transcript initialization and empty-transcript scroll pinning are preserved. Primary review independently inspected the actual diff and clean merge; git diff --check and the pre-push gate pass with no new violations. Exact-head fleet tests, including HomeOpensAtNewestTests, and a tagged build are underway; this receipt does not claim their results. |
|
Exact-head verification at 8821da4 (base 4f957ed):
The preceding current12 app was confirmed not running. Its backend stop reported no local state; data and registration were preserved. |
|
Fresh-home launch of
Screenshot withheld: the pr-media privacy check or upload refused it.
|
|
Review (Codex review_pr26708_latest): SHIP at 8c42878 Fresh correctness-first subagent review of the complete 13-file feature diff against a7a448a and the merged base integration found no blockers. Root/reply rendering, Copy Link, permalink paging, send, Escape and the Home scroll-to-bottom fix remain intact. Diff whitespace checks passed. Current-head fleet tests, build and runtime verification are being checked separately. |
|
Fresh-home launch of
Screenshot withheld: the pr-media privacy check or upload refused it.
|
|
Review (Codex review_pr26708_3afad985): SHIP at 3afad98 Fresh independent correctness-first review of all 13 feature files and shared integration paths against base 29f3daa found no blockers. Header removal preserves the original bubble, Copy Link, nested replies, permalink paging, Escape/send and the merged base's scrolling behavior. Whitespace, Python syntax and catalog integrity checks passed. The reviewer ran no builds or runtime tests. Primary review independently inspected the actual diff and clean checkout. Fleet step 08694df07322110ef5cf8423 executed 44 tests across 12 focused suites on this exact head: all passed, exit 0, workspace reset confirmed. Exact-head visual and tagged-app verification are being collected separately. PR: #26708; owner austinywang; agent Codex /root. |
|
Exact-head visual verification: PASS at 3afad98 Primary and independent reviewer Codex review_pr26708_3afad985 each viewed the screenshot from fleet step 2772cf521e5001a5b0b6f9a1. The right-hand thread starts with the original rendered bubble, followed by both legible replies. No duplicate raw-Markdown title or Open/Unassigned header appears. Both HomeThreadViewCaptureTests passed, exit 0, workspace reset confirmed; image artifact sha256:88535379687645d0230434965eebf0953a8e31bc89115d889b3c026f6dbcc8d1. This is the real macOS Home view rendered offscreen over a mock owner, dark only. Live interaction, light mode and animation are outside this verdict. Public image publication remains withheld by the existing privacy check because the agent host lacks an agent-authors list; no check was bypassed. The reported cmux-next checks blocker is green on this exact head: https://github.com/manaflow-ai/cmux/actions/runs/41251052842/job/124684506186. Release compile also passed. Base 29f3daa; PR owner austinywang; agent Codex /root; #26708. |
|
Fresh-home launch of
Screenshot withheld: the pr-media privacy check or upload refused it.
|
…ext-26686-imessage-replies
Remove the unnecessary source-file renames from the header fix. The remaining permalink state and Copy Link drives retain their existing file paths; runtime logic is unchanged. Verification: scoped static preflight passes 9 checks; localization parity and workspace grouping retain base findings. Namespace conventions and diff whitespace pass. The same 44 focused tests passed on preceding head 3afad98; exact-head fleet verification follows this commit.
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (Codex review_pr26708_3afad985): SHIP at c09f40c Fresh independent correctness-first review of all 11 feature files against base 747b4fa found no correctness defects. Reviewed shared header rendering, nested branches, Copy Link, permalink paging, send, Escape and scrolling integration. Diff whitespace, Python syntax, catalog integrity and removed-symbol reference checks passed. The reviewer ran no builds or runtime tests; fresh exact-head fleet and visual verification are in progress. Primary review independently checked the diff and clean base merge. The header-free thread helpers now remain in their existing source files, removing unnecessary renames and leaving no deleted files in the feature diff. Runtime logic is unchanged by this adjustment. Pre-push gate and normal push hooks passed with no new violations; the remote head was checked immediately before the plain push. PR #26708; owner austinywang; agent Codex /root. Earlier-head receipts are superseded. |
|
Visual review at c09f40c: primary and independent reviewer both PASS. Viewed the exact-head dark macOS Home fixture from fleet step This is an offscreen native rendering over a mock owner. Light appearance, live interaction, scrolling and animation were not verified visually. Public image publication remains blocked by the privacy check because this agent host lacks the agent-authors list; no privacy check was bypassed. |
|
Fresh-home launch of
Screenshot withheld: the pr-media privacy check or upload refused it.
|
Summary
Chief reply threads start with the original message, as in Messages, without a duplicate title or Open / Unassigned header. Copy Link, nested replies and permalinks remain available. This handles the header portion of #26686; slimmer bubble width and padding remain outside this PR.
Head
c09f40ccea8a0390c3e34e7406f8219d41837a5aincludes a normal, conflict-free merge of base747b4fa6cf74c5a9a1fa496bca76aecd71539976. The feature changes 11 files, deletes no files and preserves the base's Home scrolling behavior. Surviving permalink helpers stay in their existing source files.Verification
b4eb6f570035dbff2a4437dcexecuted 44 tests across 12 suites, all passed, exit 0, workspace reset confirmed. Covers the header regression, Escape, send motion/capture, fixture parity, reply selection, nested quotes, gaps, video, agent folding, links and Home opening at the newest message.sha256:a5ee550894cbfaf1e99ddc3e20cf6fa6d88864318288efb5f27795fa759fa9ac.b8605db7a72010b17c84a401passed, workspace reset confirmed. Tag and actual bundle name matchissue-26686-chief-header-current16; explicit local backend. Artifactsha256:4cf8accab4ee184373b28078c85d996a30bf5baf4084702dc94c5651fe740f65. Publication and non-launching Tag Opener health/status checks passed.Regression command:
cmux-ci run --class light --script scripts/ci/package-test-lane.sh --ref SHA --arg suite --arg Packages/Shared/CmuxMessagesLab --arg HomeThreadViewCaptureTests. It failed before the fix ateb8c781cf3fc65e6b5654531caf073a9d17b8cb2(step77535990f25df40eb609fdcc):threadHeaderFramewas(0.0, 14.25, 560.0, 50.0)instead of nil. Both tests in the same suite pass on this head.Observed / Not run
The fixture renders the real macOS Home view offscreen over a mock owner. It establishes dark-mode thread appearance and the named tests' behavior. The real tagged app also passed a fresh-Home launch on a capture Mac. Light mode, live reply interaction, link activation and animation were not repeated after this base merge. Broad native/iOS results remain with their current-head checks; queued checks establish no coverage. Earlier-head receipts are superseded. Native builds and Swift tests ran off the person's Mac.
Viewed after image: yes, exact head
c09f40ccea8a0390c3e34e7406f8219d41837a5a.Visual verdict: Primary and independent Visual PASS for the supplied dark-mode thread fixture.
No capture: public image publication remains withheld by the existing privacy check because the agent host lacks an agent-authors list. No privacy check was bypassed.
Localization audit: no added keys or translations; removes the unused
home.thread.titlePlaceholderkey.Try it
Open issue-26686-chief-header-current16, the desktop build with an explicit local backend. In Chief chat, open a message's replies. The thread should start with its original bubble, without an extra title or status row. Cloud behavior is unverified. The preceding current15 app is not running; backend stop reported no local state, so its data and registration were preserved.
Performance
No perf numbers: this changes reply layout and makes no performance-improvement claim. The unchanged state-change benchmark timed out at send on preceding head
75bbd3fand its merged base0f4bde52(steps86750d940e32ee6c6840ecc9,674468eab420b07f32959333ande165aba52f545f09f883f589). Those incomplete runs provide no performance verdict. The focused run excludes that separate stalled benchmark.Changelog
Fixed: Chief reply threads start with the original message, without an extra title or status header.