Repository navigation
ci(repo variables): literal fallback for the check job's pool runs-on (fixes CI fast guards on main) - #29051
Merged
Conversation
9197d7f (#28864) moved ci-repo-variables' check job onto fromJSON(vars.RUNNER_POOLS).linux with no literal after it, and tests/test_ci_repo_variable_defaults.py (CI fast guards, step 'Validate repository variable defaults') fails on a runs-on that reads a variable with no literal label to fall back to. That reddened CI fast guards on main from 9197d7f on. Fall back to the linux pool's first member. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cabecb079fe356666905
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
Owned by an agent session · session |
Collaborator
Author
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Merge receipt for
Labeled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI fast guards is red on main from 9197d7f (#28864) on. The failing step is Validate repository variable defaults (
tests/test_ci_repo_variable_defaults.py):#28864 moved the
Check repository variablesjob ontofromJSON(vars.RUNNER_POOLS).linuxwith nothing after it. This adds|| 'blacksmith-32vcpu-ubuntu-2404'(the linux pool's first member). The job still reads the pool first, so it still never waits on LINUX_RUNNER.Verified: the 41 guard steps that cover workflows, runners, variables and pools pass on this head (the variable-defaults step failed before the change).
Risk: low. One runs-on expression; the job only runs on manaflow-ai/cmux.
🤖 Generated with Claude Code
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes CI fast guards on main by giving the "Check repository variables" job's
runs-ona literal fallback. After #28864 moved the job ontofromJSON(vars.RUNNER_POOLS).linux, a fork pull request gets an emptyruns-on, failing the "Validate repository variable defaults" guard step.The fallback is
'blacksmith-32vcpu-ubuntu-2404', the linux pool's first member. The job still reads the pool first, so it still never waits onLINUX_RUNNER.Written for commit 7e5e89e. Summary will update on new commits.
Summary by CodeRabbit
manaflow-aiuse theblacksmith-32vcpu-ubuntu-2404runner when no Linux runner pool is configured. Other repositories continue to useubuntu-24.04.