Skip to content

ci(repo variables): literal fallback for the check job's pool runs-on (fixes CI fast guards on main) - #29051

Merged
teamleaderleo merged 1 commit into
mainfrom
fix-fast-guards-linux-runner
Oct 31, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
fix-fast-guards-linux-runner

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

CI fast guards is red on main from 9197d7f (#28864) on. The failing step is Validate repository variable defaults (tests/test_ci_repo_variable_defaults.py):

ci-repo-variables.yml:48: runs-on reads vars.RUNNER_POOLS with no literal runner label to fall back to; a fork pull request gets an empty runs-on

#28864 moved the Check repository variables job onto fromJSON(vars.RUNNER_POOLS).linux with nothing after it. This adds || 'blacksmith-32vcpu-ubuntu-2404' (the linux pool's first member). The job still reads the pool first, so it still never waits on LINUX_RUNNER.

Verified: the 41 guard steps that cover workflows, runners, variables and pools pass on this head (the variable-defaults step failed before the change).

Risk: low. One runs-on expression; the job only runs on manaflow-ai/cmux.

🤖 Generated with Claude Code

Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes CI fast guards on main by giving the "Check repository variables" job's runs-on a literal fallback. After #28864 moved the job onto fromJSON(vars.RUNNER_POOLS).linux, a fork pull request gets an empty runs-on, failing the "Validate repository variable defaults" guard step.

The fallback is 'blacksmith-32vcpu-ubuntu-2404', the linux pool's first member. The job still reads the pool first, so it still never waits on LINUX_RUNNER.

Written for commit 7e5e89e. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Chores
    • Updated CI runner selection so repositories under manaflow-ai use the blacksmith-32vcpu-ubuntu-2404 runner when no Linux runner pool is configured. Other repositories continue to use ubuntu-24.04.

9197d7f (#28864) moved ci-repo-variables' check job onto
fromJSON(vars.RUNNER_POOLS).linux with no literal after it, and
tests/test_ci_repo_variable_defaults.py (CI fast guards, step
'Validate repository variable defaults') fails on a runs-on that reads a
variable with no literal label to fall back to. That reddened CI fast
guards on main from 9197d7f on. Fall back to the linux pool's first
member.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-cabecb079fe356666905
@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 7e5e89e

SHIP at 7e5e89e

Visual verdict: no images; Leo tries the build

No findings.

Follow-ups: none

@teamleaderleo
teamleaderleo enabled auto-merge (squash) October 31, 2026 06:57
@teamleaderleo
teamleaderleo merged commit 7793200 into main Oct 31, 2026
32 of 33 checks passed
@teamleaderleo
teamleaderleo deleted the fix-fast-guards-linux-runner branch October 31, 2026 06:58
@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Merge receipt for 7e5e89e5e9, merged 2026-10-31 06:58:07 UTC

  • Not verified at merge: ci-status (not reported), CI fast guards (in progress), Fast static checks (in progress), web-validation (in progress)
  • Verified: backend migrations applied, merge freeze, plan
  • Skipped by policy: apply-production, apply-staging, close lapsed freezes, web-build, web-database-tests, web-tests
  • Full suite: runs on main after merge.

Labeled merged-unverified: if main breaks near this merge, look here first.

@github-actions github-actions Bot added the merged-unverified A judging check was not green at merge; see the merge receipt comment label Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-unverified A judging check was not green at merge; see the merge receipt comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant