[teamleaderleo]

HOLD: superseded by #29024 (merged as 0d38b5c): it made the same panic-ratchet fixes, so this PR's diff against feat-cmux-next is now empty (head tree == base tree). Nothing left to land.

Base red fix (priority zero): the Rust panic ratchet is RED on feat-cmux-next at 3465552:

• cmux-rd-link: clippy::indexing_slicing 7 > new crate (must be 0) (3b9cf69, 6d04ce1, ae8cd21)
• cmux-tui: clippy::indexing_slicing 835 > baseline 831 (49394d0 group create, cf3d7a3 chief acp/pipe, d13d17a apps info)

It blocks area PRs such as #28757. #28808 and #28847 fixed the cmux-tui-core and apps hits; these are the rest.

Each hit is rewritten without a panic (get/get_mut, truncate, pushes into a Vec). The baseline is not raised.

• replay.rs: the slot word is always < WORDS, so get never misses.
• seal / write_handshake: n is at most the buffer handed to snow.
• cmux-tui: an empty-slice default replaces what would have panicked.

risk:low (no behaviour change).

Observed / Not run

• Observed: the ratchet on the tip (cmux-ci run 41169601379 on measure only (do not merge): acpmux ratchet on tip + #28388 / #28015 #28448) listed these 12 hit locations. A ratchet run at this head follows in a comment.
• Not run: cmux-rd-link and cmux-tui test suites (no behaviour change).

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 03e24e5: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28958 -f ref=lane/panic-ratchet-rd-link-tui -f platform=macos -f backend_mode=local

[blacksmith-sh]

Found 3 test failures on Blacksmith runners:

Failures

Test	View Logs
test_a_picked_signing_label_has_a_rerun_alternative (main.RunsOnFallbackTests.test_ a_picked_signing_label_has_a_rerun_alternative)/ test_a_picked_signing_label_has_a_rerun_alternative (main.RunsOnFallbackTests.test_ a_picked_signing_label_has_a_rerun_alternative)	View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/ test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)	View Logs
test_no_runs_on_chain_ends_on_the_reserved_side_label (main.RunsOnFallbackTests.tes t_no_runs_on_chain_ends_on_the_reserved_side_label)/ test_no_runs_on_chain_ends_on_the_reserved_side_label (main.RunsOnFallbackTests.tes t_no_runs_on_chain_ends_on_the_reserved_side_label)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

Review (codex gpt-6-astra high fast, via reach review-router, diff-only prompt): SHIP at 96299c6
Follow-ups: none

Ratchet at this head: RATCHET_RC=0 (cmux-ci run https://github.com/manaflow-ai/cmux/actions/runs/41172450698).

[teamleaderleo]

Review (codex gpt-6-astra high fast, via reach review-router, diff-only prompt): SHIP at 5033a36
Follow-ups: none

Round 2 (SHIP at e9303c1) covered the acpmux rewrites of #28170's 8 hits; round 3 covers the compile fix (serde_json::Value inside tracing::warn!).
Workspace clippy and the panic ratchet at this head: WS_CLIPPY_RC=0, RATCHET_RC=0 (https://github.com/manaflow-ai/cmux/actions/runs/41177361809).

[lawrencecchen]

Note from the base-red lane: #29024 now fixes all three panic-ratchet rows on feat-cmux-next: cmux-rd-link indexing_slicing 7 > 0, acpmux 692 > 686 (#28170) and cmux-tui 836 > 831. It uses your hunks from this PR (credited with Co-authored-by), including your serde_json::Value compile fix in hub/peers.rs. It adds one more cmux-tui hit that came after your count: args[i] in take_target in cli/automation.rs (from 7b3b9f7, cmux automation --target cloud), so the cmux-tui count is now 836, not 835.

You can close this PR or keep it. Whichever PR merges first, the other one becomes a no-op. If this one merges first, #29024 will be closed with a comment.

[teamleaderleo]

Review (codex gpt-6-astra high fast, via reach review-router, delta-only per acpmux-owner): SHIP at dc34d45
Follow-ups: none

Delta over r3 (SHIP at 5033a36): removes the unused cmux_json::JsonSet import in acpmux server/requests.rs that clippy --all-targets flagged.
At this head: clippy --all-targets -p acpmux -p cmux-rd-link -p cmux-tui -D warnings RC=0; workspace clippy RC=0; panic ratchet RC=0 (https://github.com/manaflow-ai/cmux/actions/runs/41180193826).

[teamleaderleo]

Red classification at dc34d45: cmux-tui artifacts / build-windows / build x86_64-pc-windows-gnu is a base red, not this PR's.

The errors are all in cmux-automations:

• std::os::unix and std::os::fd imports in exec.rs and store.rs
• libc::localtime_r in clock.rs

That crate is unix-only code from ee37179, and this PR changes no file in it. The Windows build ran here only because the PR touches cmux-tui.

#29075 ("base red: cmux-tui builds for Windows again (cmux-automations unix-only)") is the open fix. release-notary and Guard status are the known base guard reds.

[teamleaderleo]

Review (the owner lane's independent review, at its land request): SHIP at 03e24e5

Recorded by lane-gh-broker from this PR's owner lane, which asked to land this exact head after its independent review. next-autoland lands it once every red is the base's; a BLOCK at this head, a HOLD line or a hold label still stops it.

[teamleaderleo]

Superseded by #29024 (0d38b5c), which landed the same panic-ratchet fixes. At head 03e24e5 this PR's tree equals the feat-cmux-next tree it merged (a93c5a13), so it would land an empty change. Holding it; it will be closed.

[teamleaderleo]

Owned by an agent session · session

[teamleaderleo]

Superseded by #29024, which landed the same panic-ratchet fixes (merged as 0d38b5c). This PR's diff against feat-cmux-next is empty, so there is nothing left to land.