Skip to content

measure only (do not merge): acpmux ratchet on tip + #28388 / #28015 - #28448

Closed
teamleaderleo wants to merge 7 commits into
feat-cmux-nextfrom
lane/acpmux-ratchet-measure
Closed

teamleaderleo wants to merge 7 commits into
feat-cmux-nextfrom
lane/acpmux-ratchet-measure

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

HOLD: measurement only, never merge. Its owner closes it after the run.

This adds only .measure/: the merge diffs of #28388 and #28015 into feat-cmux-next 27f2c06, and a script that measures the acpmux Rust panic ratchet on the tip, on tip+#28388 and on tip+#28015 (cmux-ci runs only at an open PR's head).

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Measurement-only PR, never to merge; its owner closes it after the run. It measures the acpmux Rust panic ratchet on flat feat-cmux-next tip against base 976656f, since cmux-ci runs only at an open PR's head.

Adds .measure/measure.sh, which runs clippy with the ratchet flags on the tip and reports the four deny-ratcheted lint counts (indexing_slicing, string_slice, unwrap_used, expect_used) plus per-file hit lines for each configuration difference.

Written for commit 421e624. Summary will update on new commits.

View guided diff Turn on auto-fix

…ches for #28388 and #28015

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test_a_picked_signing_label_has_a_rerun_alternative (main.RunsOnFallbackTests.test_
a_picked_signing_label_has_a_rerun_alternative)/
test_a_picked_signing_label_has_a_rerun_alternative (main.RunsOnFallbackTests.test_
a_picked_signing_label_has_a_rerun_alternative)
View Logs
test_no_runs_on_chain_ends_on_the_reserved_side_label (main.RunsOnFallbackTests.tes
t_no_runs_on_chain_ends_on_the_reserved_side_label)/
test_no_runs_on_chain_ends_on_the_reserved_side_label (main.RunsOnFallbackTests.tes
t_no_runs_on_chain_ends_on_the_reserved_side_label)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Measured (run 41097952660, tip 27f2c06): acpmux indexing_slicing/string_slice/unwrap_used/expect_used is 686/94/143/18 on the tip, 685/94/143/18 with #28388 merged, and 686/94/143/18 with #28015 merged. All are at or under the baseline. This PR is done and should be closed unmerged.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing for ao-panic-ratchet: this was a measure-only draft. The measurement is done (run 41097952660): tip 686/94/143/18, with #28388 merged in 685, and with #28015 merged in 686. #28388 has landed (d06357c).

…ch for #28428

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo teamleaderleo reopened this Oct 30, 2026
…719608 and abe139d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…28626 and base 976656f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ll ratchet RED lines, tip vs 976656f)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tchet RED lines on the tip)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

web and size checks: green

Default changes

No defaults change at 421e624ec4af.

@github-actions github-actions Bot added risk:high Risk tier (docs/ci/risk-tiers.md) and removed risk:normal Risk tier (docs/ci/risk-tiers.md) labels Oct 31, 2026
@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:high Risk tier (docs/ci/risk-tiers.md) labels Oct 31, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Measure-only PR (not for merge); both PRs it measured, #28388 and #28015, are merged. Closing as part of the open-PR sweep.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 421e624e Deployed Oct 31, 2026 by teamleaderleo via wait for same-key tree publisher #87482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant