Repository navigation
fix inspector output rows without a diff opener - #28705
Conversation
|
Review (codex gpt-6-astra high): SHIP at 320dfc4 No concrete correctness or accessibility defects found in the two-file diff from common ancestor
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a web and size checks: green Shipped in:
|
|
Found 2 test failures on Blacksmith runners: Failures
|
|
Independent review (gpt-6.1-sol high) at ca54a25: SHIP. No correctness findings. |
|
Independent review (gpt-6.1-sol high) at 8fe9f10: SHIP. No correctness findings. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Problem
The Inspector lists changed files in Outputs even when the caller cannot open a diff. Before this change those rows were rendered as disabled buttons, so a user saw a broken action with no usable target. This is the smallest uncovered gap in the UX-04 journey from an agent result to reviewable files.
Change
OutputsSectionnow keeps the same file-row content and layout, but chooses the semantic element from the available capability:onOpenFile, it remains an enabled button and opens the existing diff path;divwith no button role, disabled state, hover affordance, cursor or focus stop.This preserves the existing Session Info card order and does not add a second file or diff source.
Regression and validation
cd webviews && bun test test/chat-inspector-outputs.test.tsx— 5 passed, 0 failed.cd webviews && bunx vp lint src/agent-session/acpmux/inspector/OutputsSection.tsx test/chat-inspector-outputs.test.tsx— passed.git diff --check— passed.bun run checkwas attempted. It reports four existing baseline reds in unrelated settings design-token/layer and formatting/lint files; no changed-file error was reported.The enabled opener path remains covered by the existing test. The new regression renders the production
ChatInspectorcaller withoutonOpenOutputand asserts no button or disabled attribute while retaining the filename. No signed app, native artifact service, Cloud task, reconnect, or screenshot capture was available in this lane; this is a source-backed semantic fix with deterministic web test evidence. No visual geometry changed, so no before/after image is claimed.Related UX-04 evidence and ownership remain in HQ #5457, #5071, #5307, #5174 and adjacent artifact work #27815/#27253/#27823; this PR does not duplicate those scopes.
Base:
feat-cmux-nextat4d1e169b8e782755f67812a53f909a3dae5d7194Head:
320dfc4123a5e57635117b2521fa201cf36f783aagent-identity footer --repo manaflow-ai/cmux
Agent session: agent session