Skip to content

fix inspector output rows without a diff opener - #28705

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/orch-live-view-output-row
Oct 31, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/orch-live-view-output-row

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The Inspector lists changed files in Outputs even when the caller cannot open a diff. Before this change those rows were rendered as disabled buttons, so a user saw a broken action with no usable target. This is the smallest uncovered gap in the UX-04 journey from an agent result to reviewable files.

"Like you need to be more ambitious, really. Like the whole dynamic workflow situation. I don't know if you already have the UI for that, how good it is, if you guys have tested it out yet. But, you know, we need to have that. And likewise, obviously, like the session info area, like that's where the things can be shown, and also the right tab area. All of these, like better and better UI. Just go ahead, man. I feel like you can do a hell of a lot more. More codex, more Claude, more whatever. We have the capacity, so let's use the capacity to go do some more productive f***ing work, right?"

Change

OutputsSection now keeps the same file-row content and layout, but chooses the semantic element from the available capability:

  • with onOpenFile, it remains an enabled button and opens the existing diff path;
  • without it, it is a plain div with no button role, disabled state, hover affordance, cursor or focus stop.

This preserves the existing Session Info card order and does not add a second file or diff source.

Regression and validation

  • cd webviews && bun test test/chat-inspector-outputs.test.tsx — 5 passed, 0 failed.
  • cd webviews && bunx vp lint src/agent-session/acpmux/inspector/OutputsSection.tsx test/chat-inspector-outputs.test.tsx — passed.
  • git diff --check — passed.
  • Full bun run check was attempted. It reports four existing baseline reds in unrelated settings design-token/layer and formatting/lint files; no changed-file error was reported.

The enabled opener path remains covered by the existing test. The new regression renders the production ChatInspector caller without onOpenOutput and asserts no button or disabled attribute while retaining the filename. No signed app, native artifact service, Cloud task, reconnect, or screenshot capture was available in this lane; this is a source-backed semantic fix with deterministic web test evidence. No visual geometry changed, so no before/after image is claimed.

Related UX-04 evidence and ownership remain in HQ #5457, #5071, #5307, #5174 and adjacent artifact work #27815/#27253/#27823; this PR does not duplicate those scopes.

Base: feat-cmux-next at 4d1e169b8e782755f67812a53f909a3dae5d7194
Head: 320dfc4123a5e57635117b2521fa201cf36f783a

agent-identity footer --repo manaflow-ai/cmux
Agent session: agent session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high): SHIP at 320dfc4

No concrete correctness or accessibility defects found in the two-file diff from common ancestor 165401270dcf7a7d307c13a67f879fad608290bb.

  • Rows without onOpenFile are plain, non-focusable <div> content.
  • Rows with onOpenFile remain enabled buttons and preserve the correct path.
  • Regression coverage verifies the noninteractive case; existing coverage verifies activation.
  • Reviewer's tests were not run; the author ran the focused suite and lint documented in the PR body.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 320dfc4: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28705 -f ref=lane/orch-live-view-output-row -f platform=macos -f backend_mode=local

Gallery before/after for 8fe9f10: 16 states rendered, 18 images differ, 284 more touched states not rendered. Images are in the run's artifact, not on this public PR.

gh run download 41170272469 -R manaflow-ai/cmux -n gallery-advisory-28705-8fe9f102f2149a63fbc48e38d046689924ea53ee (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.chat-inspector/full Apple System Colors Light unchanged 0% own OutputsSection.tsx
agent-pane.chat-inspector/full Apple System Colors unchanged 0% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-running Apple System Colors Light changed 0.0048% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-running Apple System Colors changed 0.0037% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-finished Apple System Colors Light unchanged 0% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-finished Apple System Colors unchanged 0% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-agent-row-compact Apple System Colors Light changed 0.0054% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-agent-row-compact Apple System Colors changed 0.0046% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-agent-row-detail Apple System Colors Light changed 0.0048% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-agent-row-detail Apple System Colors changed 0.0042% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-agent-row-grid Apple System Colors Light changed 0.0055% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-agent-row-grid Apple System Colors changed 0.0041% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-agent-row-narrow Apple System Colors Light changed 0.0045% own OutputsSection.tsx
agent-pane.chat-inspector/workflow-agent-row-narrow Apple System Colors changed 0.004% own OutputsSection.tsx
agent-pane.chat-inspector/layout-glance Apple System Colors Light unchanged 0% own OutputsSection.tsx
agent-pane.chat-inspector/layout-glance Apple System Colors unchanged 0% own OutputsSection.tsx
agent-pane.chat-inspector-surfaces/transcript Apple System Colors Light changed 0.0278% imports OutputsSection.tsx (1 hops)
agent-pane.chat-inspector-surfaces/transcript Apple System Colors changed 0.0272% imports OutputsSection.tsx (1 hops)
agent-pane.chat-inspector-surfaces/diff-in-place Apple System Colors Light unchanged 0% imports OutputsSection.tsx (1 hops)
agent-pane.chat-inspector-surfaces/diff-in-place Apple System Colors unchanged 0% imports OutputsSection.tsx (1 hops)
agent-pane.chat-inspector-surfaces/document-beside Apple System Colors Light changed 0.0278% imports OutputsSection.tsx (1 hops)
agent-pane.chat-inspector-surfaces/document-beside Apple System Colors changed 0.0272% imports OutputsSection.tsx (1 hops)
agent-pane.chat-inspector-surfaces/diff-closed Apple System Colors Light changed 0.0278% imports OutputsSection.tsx (1 hops)
agent-pane.chat-inspector-surfaces/diff-closed Apple System Colors changed 0.0272% imports OutputsSection.tsx (1 hops)
agent-pane.inspector-motion/closed Apple System Colors Light unchanged 0% imports OutputsSection.tsx (1 hops)
agent-pane.inspector-motion/closed Apple System Colors unchanged 0% imports OutputsSection.tsx (1 hops)
agent-pane.inspector-motion/reopened Apple System Colors Light changed 0% imports OutputsSection.tsx (1 hops)
agent-pane.inspector-motion/reopened Apple System Colors changed 0% imports OutputsSection.tsx (1 hops)
agent-pane.inspector-motion/long-chat Apple System Colors Light unchanged 0% imports OutputsSection.tsx (1 hops)
agent-pane.inspector-motion/long-chat Apple System Colors unchanged 0% imports OutputsSection.tsx (1 hops)
agent-pane.inspector-motion/resize-handoff Apple System Colors Light unchanged 0% imports OutputsSection.tsx (1 hops)
agent-pane.inspector-motion/resize-handoff Apple System Colors unchanged 0% imports OutputsSection.tsx (1 hops)

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

web and size checks: green

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 31, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test_a_picked_signing_label_has_a_rerun_alternative (main.RunsOnFallbackTests.test_
a_picked_signing_label_has_a_rerun_alternative)/
test_a_picked_signing_label_has_a_rerun_alternative (main.RunsOnFallbackTests.test_
a_picked_signing_label_has_a_rerun_alternative)
View Logs
test_no_runs_on_chain_ends_on_the_reserved_side_label (main.RunsOnFallbackTests.tes
t_no_runs_on_chain_ends_on_the_reserved_side_label)/
test_no_runs_on_chain_ends_on_the_reserved_side_label (main.RunsOnFallbackTests.tes
t_no_runs_on_chain_ends_on_the_reserved_side_label)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent review (gpt-6.1-sol high) at ca54a25: SHIP. No correctness findings.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent review (gpt-6.1-sol high) at 8fe9f10: SHIP. No correctness findings.

@teamleaderleo
teamleaderleo merged commit e2c54e3 into feat-cmux-next Oct 31, 2026
181 of 184 checks passed
@teamleaderleo
teamleaderleo deleted the lane/orch-live-view-output-row branch October 31, 2026 07:24

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 8fe9f102 Deployed Oct 31, 2026 by teamleaderleo via wait for same-key tree publisher #87569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant