Skip to content

acpmux: add opt-in artifact MCP tools - #27253

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
lane/artifacts-mcp
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
lane/artifacts-mcp

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Adds artifact_save, artifact_list, and memory_search to the existing acpmux MCP server when artifacts_sync.enabled is true. The tools remain absent by default, and direct calls re-check the switch. Artifact files are validated for path traversal and secret-bearing names/content, saved through the shared artifacts client, and copied under ~/.cmux/artifacts/<id>/. Search and list results are explicitly wrapped as untrusted data.

Leo's request: "like the claude.ai artifacts but imagine you didnt need to only have it on claude.ai". On the MVP: "go ahead".

Validation: added tests for disabled listing and calls, secret/path rejection, mutually exclusive input forms, duplicate file names, local writes, and the untrusted-data wrapper. A loopback HTTP contract test checks the memory search query, bearer header, and wrapping of remote text. The initial remote formatting check found formatting issues; the current head is formatted with the repository's Rust 1.95.0 formatter. Cargo tests and clippy are pending the shared sync client dependency. No new timer or background task is introduced.

Draft dependency: the shared sync client must provide runtime mesh authentication and correct CAS/blob routing before this PR can be validated and made ready.

Risk: opted-in calls send artifact content to the configured artifacts service; secret scanning is heuristic. A remote save that succeeds before a local disk failure reports the saved artifact id and head so callers can recover without duplicating it.

Agent session: agent session

@blacksmith-sh

blacksmith-sh Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp09n1g528/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpbg13yvoc/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 72aea08; does not block
red: cmux-next crash ratchet; NEW: green on the base 72aea08; do not merge until green; see lane-rules

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-3jye86 created for this PR by the cmux coordinator.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
Agent-Session: deeplink/agent?id=aid-1cfbbef6961cda05f0b0
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #31850 (merged 2026-11-02, 419cb03), which carries this branch's artifact_save / artifact_list / memory_search tools adapted to today's acpmux_mcp.rs: memory_search became artifact_search, artifact_read was added, the opt-in switch became on-by-default with sign-in, and the local ~/.cmux/artifacts copy was dropped on purpose. Base-merging this draft would re-add duplicate tools and undo those choices. Adopted from a gone owner by the stall reconciler.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 48f1641e Deployed Oct 29, 2026 by teamleaderleo via plan the macOS fallback build #75316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant