Repository navigation
cmux-next tests: lift the multiWindow classic upgrade quarantine (#28425) - #28445
Merged
teamleaderleo merged 1 commit intoOct 30, 2026
Merged
Conversation
The order the multiWindow case checks is now read only once the queued sidebar placements have landed, so #28430's known issue comes off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 30, 2026 17:12 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lifts the
multiWindowquarantine from #28430 (tracking #28425). The fix is in #28362: the classic import waits for each workspace's queued sidebar placement before setting its group, and the simulator reads the tree only after the placement queue drains and the store catches up.Fleet loop,
ClassicUpgradeSimulationTests,ClassicMigrationTests, sequential runs with distinct keys:All three reds on the fix head ran on the same fleet worker, and that worker fails base the same way (every case's order checks). It's the only worker in the loop with a display attached (
NSScreen.screens.count == 1; the others report 0). On it, the window registry is still empty when the migration starts, so the placements' "window is open" guard skips every one. That's a separate environment problem, tracked in #28425. It isn't the race fixed here.Takes back #28430: that quarantine was meant to come off once #28362 landed, and it has.
No capture: test-only change.
Risk: low. It puts back the expectations that ran before #28430.
Agent session: agent session
🤖 Generated with Claude Code