Skip to content

cmux-next tests: quarantine the multiWindow classic upgrade order check (#28425) - #28430

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/classic-multiwindow-quarantine
Oct 30, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/classic-multiwindow-quarantine

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

ClassicUpgradeSimulationTests.theFirstLaunchBringsEverythingOnce("multiWindow") fails intermittently on base and on unrelated PRs, most recently #28283's daemon tests. The workspaces show in swapped order at ClassicUpgradeSimulationTests.swift:45 and :52, for example multiWindow: order differs: ["w1 0", "w1 2", "w1 1", "w1 3"] for ["w1 0", "w1 1", "w1 2", "w1 3"].

Tracking: #28425. Cause: the sidebar placements a run queues through PersonalPlacementQueue (#26153) trail it on a loaded runner. A late slot placement undoes the group the run set, and the simulator reads the order before the queue drains. The fix is #28362.

Change

Only that case's verify runs inside withKnownIssue(..., isIntermittent: true), which names #28425. The other seven matrix cases, the other tests and the rest of that case's expectations are unchanged. #28362 removes this quarantine.

No capture: test-only change.

Risk: low. One test case's order and group checks become a known issue until the fix lands.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Quarantines the intermittently failing multiWindow case of ClassicUpgradeSimulationTests.theFirstLaunchBringsEverythingOnce as a known issue (#28425) until the fix in #28362 lands.

The test flakes because sidebar placements a run queues trail it on a loaded runner, showing workspaces in swapped order. Only that case's verify runs inside withKnownIssue(..., isIntermittent: true); the other seven matrix cases and all other expectations are unchanged. Test-only change with low risk.

Written for commit f999387. Summary will update on new commits.

View guided diff Turn on auto-fix

…ck (#28425)

theFirstLaunchBringsEverythingOnce("multiWindow") fails intermittently on
base and on unrelated PRs: workspaces show in swapped order at
ClassicUpgradeSimulationTests.swift:45 and :52. The sidebar placements a
run queues (#26153) trail it on a loaded runner. The fix is #28362.

Until it lands, that one case's verify runs inside withKnownIssue
(isIntermittent) naming #28425. Every other case and check is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review f999387: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28430 -f ref=lane/classic-multiwindow-quarantine -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit dea0ac8 into feat-cmux-next Oct 30, 2026
158 of 169 checks passed
@teamleaderleo
teamleaderleo deleted the lane/classic-multiwindow-quarantine branch October 30, 2026 17:05
teamleaderleo added a commit that referenced this pull request Oct 30, 2026
The order the multiWindow case checks is now read only once the queued
sidebar placements have landed, so #28430's known issue comes off.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

1 inactive deployment
ci-routing-agent — f999387d Deployed Oct 30, 2026 by teamleaderleo via namespace autofix #8200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant