Repository navigation
cmux-next tests: quarantine the multiWindow classic upgrade order check (#28425) - #28430
Merged
teamleaderleo merged 1 commit intoOct 30, 2026
Merged
Conversation
…ck (#28425) theFirstLaunchBringsEverythingOnce("multiWindow") fails intermittently on base and on unrelated PRs: workspaces show in swapped order at ClassicUpgradeSimulationTests.swift:45 and :52. The sidebar placements a run queues (#26153) trail it on a loaded runner. The fix is #28362. Until it lands, that one case's verify runs inside withKnownIssue (isIntermittent) naming #28425. Every other case and check is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 30, 2026 16:42 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
Found 2 test failures on Blacksmith runners: Failures
|
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
ClassicUpgradeSimulationTests.theFirstLaunchBringsEverythingOnce("multiWindow")fails intermittently on base and on unrelated PRs, most recently #28283's daemon tests. The workspaces show in swapped order at ClassicUpgradeSimulationTests.swift:45 and :52, for examplemultiWindow: order differs: ["w1 0", "w1 2", "w1 1", "w1 3"] for ["w1 0", "w1 1", "w1 2", "w1 3"].Tracking: #28425. Cause: the sidebar placements a run queues through
PersonalPlacementQueue(#26153) trail it on a loaded runner. A late slot placement undoes the group the run set, and the simulator reads the order before the queue drains. The fix is #28362.Change
Only that case's
verifyruns insidewithKnownIssue(..., isIntermittent: true), which names #28425. The other seven matrix cases, the other tests and the rest of that case's expectations are unchanged. #28362 removes this quarantine.No capture: test-only change.
Risk: low. One test case's order and group checks become a known issue until the fix lands.
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Quarantines the intermittently failing
multiWindowcase ofClassicUpgradeSimulationTests.theFirstLaunchBringsEverythingOnceas a known issue (#28425) until the fix in #28362 lands.The test flakes because sidebar placements a run queues trail it on a loaded runner, showing workspaces in swapped order. Only that case's verify runs inside
withKnownIssue(..., isIntermittent: true); the other seven matrix cases and all other expectations are unchanged. Test-only change with low risk.Written for commit f999387. Summary will update on new commits.