Skip to content

carry of #27674: latency engine coverage - #28156

Merged
teamleaderleo merged 8 commits into
feat-cmux-nextfrom
lane/carry-27674-latency
Oct 31, 2026
Merged

teamleaderleo merged 8 commits into
feat-cmux-nextfrom
lane/carry-27674-latency

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Carry of #27674: fix latency scoreboard incomplete browser engine coverage.

Merged current feat-cmux-next into the original reviewed commits to resolve the conflict and force fresh checks/review. Original: #27674

Original purpose (#27674):

The latency scoreboard used to catch every browser launch error as an unstructured warning and continue. A partial Chromium/WebKit sweep could therefore look complete.

Performance

No perf numbers: this changes latency evidence reporting only; it does not alter measured latency or budgets.

Agent session: agent session

teamleaderleo and others added 2 commits October 29, 2026 23:51
Record selected engines and structured launch failures so partial latency sweeps cannot look complete.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-8653e9b405a501fdfdc3
…27674-latency

# Conflicts:
#	webviews/scripts/latency/run.ts
@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review cef7293: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28156 -f ref=lane/carry-27674-latency -f platform=macos -f backend_mode=local

Passes: CI passes on cef72935c5.

CI passes on cef72935c5 (run 41168861527 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

web and size checks: green

Shipped in:

@blacksmith-sh

blacksmith-sh Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Found 72 test failures on Blacksmith runners:

Failures

Test View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs

...and 62 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base 5be39f0 to this head): BLOCK at 27a7198.

[P1] webviews/scripts/latency/run.ts:149-162 - The module no longer exports parseOptions, evidenceErrors, or sampleIdle, and executes the entire benchmark during import. The existing latency-core-schema.test.ts therefore cannot load and the webview test suite fails. - Restore the exported API and main()/import.meta.main guard, or update all existing callers and tests.
[P2] webviews/scripts/latency/run.ts:85-90 - Server startup has no timeout and only matches the URL within each individual output chunk; a split or changed Vite banner leaves the promise pending until CI times out. - Buffer output across chunks, handle error/early exit, and enforce a startup timeout with cleanup.
[P2] webviews/scripts/latency/run.ts:186 - Page errors are reduced to console.warn, so runtime fixture failures no longer contribute to the run result and can be reported as passing measurements. - Record page errors as run/action failures and make them affect the exit status.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base 5be39f0 to this head): BLOCK at db2af6e.

[P1] webviews/scripts/latency/run.ts:299 - engineNames is undeclared, so TypeScript compilation fails (or a successful launch throws ReferenceError), preventing all latency measurements - replace with measuredEngines.push(engineName).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base 5be39f0 to this head): SHIP at 456faae.

No P1/P2 findings.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

…27674-latency

# Conflicts:
#	webviews/scripts/latency/run.ts
Keeps #28494's SGR-tolerant banner match covered after folding it into waitForServerReady.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-159afad10a5ab45ea16c
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base b828e44 to this head): SHIP at 5ae893d.

No P1/P2 findings.

web lint on the merge failed oxfmt --check for these two files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-159afad10a5ab45ea16c
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base b828e44 to this head): SHIP at 8c60c5e.

No P1/P2 findings.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base 584b3f6 to this head): SHIP at cef7293.

No P1/P2 findings.

@teamleaderleo
teamleaderleo merged commit d8a4522 into feat-cmux-next Oct 31, 2026
151 of 154 checks passed
@teamleaderleo
teamleaderleo deleted the lane/carry-27674-latency branch October 31, 2026 05:37

This branch was previously deployed

1 inactive deployment
ci-routing-agent — cef72935 Deployed Oct 31, 2026 by teamleaderleo via wait for same-key tree publisher #87449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant