Repository navigation
fix(latency): report incomplete browser engine coverage - #27674
teamleaderleo wants to merge 1 commit into
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
195f0d3 to
e726aa2
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Record selected engines and structured launch failures so partial latency sweeps cannot look complete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-8653e9b405a501fdfdc3
e726aa2 to
6b0ed8c
Compare
|
Found 1 test failure on Blacksmith runners: Failure
|
|
Review (codex gpt-6-astra high, next-review): SHIP at 6b0ed8c No blocking findings. Nonblocking note: The PR description says runtime exit policy is unchanged, but |
|
Superseded by #28156, a backlog-drain carry that keeps this PR's commits and their authorship and resolves the base merge conflict. Closing this one in its favour. |
* fix(latency): report browser engine launch coverage Record selected engines and structured launch failures so partial latency sweeps cannot look complete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-8653e9b405a501fdfdc3 * fix(latency): preserve schema and fail incomplete engine runs Agent-Session: https://cmux.com/deeplink/agent?id=aid-de6a18975ad3ec68b1b1 * test(latency): cover chunked server readiness Agent-Session: https://cmux.com/deeplink/agent?id=aid-01581fe5da773d909472 * test(latency): server readiness strips colour escapes around the port Keeps #28494's SGR-tolerant banner match covered after folding it into waitForServerReady. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-159afad10a5ab45ea16c * style(latency): oxfmt the engine-selection import and test web lint on the merge failed oxfmt --check for these two files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-159afad10a5ab45ea16c --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes manaflow-ai/cmuxterm-hq#5179.
The latency scoreboard used to catch every browser launch error as an unstructured warning and continue. A partial Chromium/WebKit sweep could therefore look complete, including the universal “every action fits one frame” line.
This change:
{ engine, error, stage: "launch" };--ciscoreboard and explicit--enginefiltering unchanged.The launch-selection helper has focused tests for complete coverage, one-engine failure, both-engine failure, and explicit one-engine selection. No latency samples, budgets, or runtime exit policy changed.
Performance
No perf numbers: this changes latency evidence reporting only; it does not alter measured latency, budgets, or runtime performance.
Validation will run through the managed Linux webview test lane.
🤖 Generated with Claude Code
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes manaflow-ai/cmuxterm-hq#5179.
The latency scoreboard previously caught browser launch errors as unstructured warnings and continued, so a partial Chromium/WebKit sweep could look complete and even print "every action fits one frame."
This change records the selected engine set before launching, keeps each launch failure as structured
{ engine, error, stage }data, and writes expected/measured engine coverage plus launch failures to the JSON output and GitHub summary. The universal success line is suppressed when coverage is incomplete, replaced by a measured/expected engine count. The run now exits non-zero when engine launch coverage is incomplete (unless--no-fail), matching the existing action-budget exit. Nonblocking--ciscoreboard behavior and explicit--enginefiltering (including an invalid filter) are unchanged.The new launch-selection helper has focused tests for complete coverage, one-engine failure, both-engine failure, and explicit one-engine selection. No latency samples or budgets changed.
Written for commit 6b0ed8c. Summary will update on new commits.