[teamleaderleo]

Carries #27257: cmux-next test windows and panels must close after each test, while preserving daemon ownership safely through teardown.

The original PR's latest exact-head review found two P2 teardown hazards in AppTestDaemonOwner:

• a cancelled endpoint caller could remove its still-running ensure task before reap joined it;
• an endpoint whose process identity was not verified could still receive a graceful socket shutdown, potentially stopping a replacement daemon.

This carry keeps admitted ensure tasks until teardown joins them, and only performs graceful shutdown for verified process identities. Unverified endpoints use a bounded exit observation and preserve state when ownership remains ambiguous.

Validation: git diff --check passed. Fleet Swift tests were not run because the broker was temporarily rate limited while this carry was prepared.

Original PR: #27257

Agent session: agent session

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Carries #27257: cmux-next tests must close the windows and panels they open after each test, while teardown preserves daemon ownership so a replacement daemon is never accidentally stopped.

An exact-head review of the original found two teardown hazards in AppTestDaemonOwner: a cancelled endpoint caller could drop its still-running ensure task before reap joined it, and an unverified endpoint could receive a graceful socket shutdown that stops a replacement daemon. This carry keeps admitted ensure tasks until teardown joins them, and performs graceful shutdown only for verified process identities. Unverified endpoints get a bounded exit observation and preserve state when ownership is ambiguous.

Behavior changes

• DaemonConnection.closeAndWait() and DaemonService.shutdownConnectionAndWait() join in-flight startup and reconnect attempts before the owner is reaped.
• Page Info certificate, site settings, and site data windows close with the retired page, and a late certificate response can no longer present anything.
• The Mac screen approval prompt closes and drops the last request's panel on settle.

Test harnesses now tear down daemons, windows, palette panels, and cached browser pages even on early failure or cancellation.

Validation: git diff --check passed. Fleet Swift tests were not run because the broker was temporarily rate limited while this carry was prepared.

^{Written for commit 351edf5. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 351edf5: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28093 -f ref=lane/carry-27257-pinned-teardown -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 695d1f5; does not block

[blacksmith-sh]

Found 7 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmpnibhp_j_/summary-missing.json (live):/summary-missing.json (live):	View Logs
/tmp/tmpxpx14fas/summary-fail.json (live):/summary-fail.json (live):	View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/ [new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows	View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs
convention violations found (ERROR lines above)./ convention violations found (ERROR lines above).	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

Superseded by #28091, a newer carry of #27257 with the same teardown fixes plus the compile repair (head ff12a5d). Closing this one in its favour.

[teamleaderleo]

Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at 351edf5

BLOCK

1. Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/BackgroundAccessoryPolicyTests.swift:93,102 — withLaunch replaces the process-wide AppProcessRoot with an inert AppServices instance when no root existed, then permanently restores that replacement. Since AppProcessRoot has no way to clear or restore nil, subsequent tests in the same process see a stale root and AppServices.background refuses to recognize their services as the process root. A throwing Launch initializer also leaves the newly adopted services installed.

2. Packages/macOS/CmuxNext/Sources/CmuxNextBrowser/PageInfo/UI/PageInfoController.swift:130-136 — closePanel() only cancels certificateTask; if the page-info controller is retired while its asynchronous loadTask is active, that task remains attached to the controller and can continue updating the retired page. Retirement should cancel and clear all outstanding controller tasks/observation before dropping the panel.