[teamleaderleo]

Batch B1 closes the remaining Swift test windows and panels that were still kept alive after each test. This follows Leo's instruction: "But why do you guys not just clean up after yourselves, or at least do your best to?"

The suites close their own windows and popup panels in teardown, while the product-side cleanup keeps Page Info, Extensions Menu, Host Pressure, Native Popup, and browser retirement panels from surviving a window close. This branch is stacked after the merged overlay-host fix.

No capture: no visible change; these changes only close hidden panels and test windows after their owner closes.

metric	before	after	delta	harness or run link
Windows open at process exit	251	pending	pending	five-step fleet census harness

Agent session: agent session

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 2a72ab7: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr27257 -f ref=lane/window-leak-suites-B1-codex -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: green on the base 1674720; do not merge until green; see lane-rules

[teamleaderleo]

Bead cx-edi7x1 created for this PR by the cmux coordinator.

[blacksmith-sh]

Found 7 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmpmiudc7_v/summary-fail.json (live):/summary-fail.json (live):	View Logs
/tmp/tmpr2wtz94v/summary-missing.json (live):/summary-missing.json (live):	View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/ [new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows	View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs
convention violations found (ERROR lines above)./ convention violations found (ERROR lines above).	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at 29fcf05

BLOCK

1. [P1] Third BrowserProfile test still lacks cleanup — BrowserProfileNewTabMenuTests.swift:132. theProfileBadgeMenuOpensItsTabInTheRightClickedTabsPane creates browser tabs without registering Self.close. Its harness closes shell windows but retains cached browser entries, leaving PageInfo/Extensions panels unclosed. Register cleanup at this body’s entry too.

2. [P2] Daemon-close test cleans only one cached page on failure — DaemonClosedBrowserPageTests.swift:25. Both pages are cached, but the defer releases only tabs[0]. If closeTab throws or the subsequent waits fail before retirement, tabs[1] retains its panels. Teardown must release both independently of the behavior being tested.

Reviewed exact head 29fcf056bf811e6cf679f2c5d83fdb66cc260dbc, including all 28 cumulative changed files; their blob hashes match the diff. The earlier cache and palette findings are resolved for the first two BrowserProfile bodies.

Source-only verdict. macOS runtime and full census remain pending; no readiness or merge approval.

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[teamleaderleo]

Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at 29f279a

BLOCK — 29f279aafff3ef0a05f41a15226b9f45d2247e65

1. [P2] Failed setup can leave daemon startup running. PinnedPageTests.swift:98 and PasswordManagerRouteTests.swift:82 call shutdownConnection() only when connection exists. Cancellation or timeout before the first connection skips it, leaving the unstructured startup/retry task running after window cleanup and directory removal. Stop startup unconditionally, await its completion, and reap any owner it launched.

2. [P2] Background shutdown still permits daemon restart. BackgroundAccessoryPolicyTests.swift:74 requests shutdown through the subscribed connection before disabling reconnect. Daemon EOF schedules reconnect through server ensure; if teardown’s main-actor continuation is delayed, it can spawn a replacement daemon. FreshLaunchSidebarTests.swift:48 has the same ordering. Close and await the connection first, then use the dedicated shutdownDaemon(endTerminals: true) socket, as the shared harnesses already do.

3. [P2] Answering the last MacScreen request can bypass panel cleanup. MacScreenApprovalPanel.swift:97 clears current before calling update(). With no remaining unsettled request, update() compares nil with nil and returns before present(false). Thus the new panel close/drop branch never runs when settlement beats the pending-request observer, including the already-ended-request error path. Preserve the previous request until update() processes the transition, or explicitly close when settlement empties the queue.

Read the full cumulative diff and lifecycle dependencies; all 31 changed-file hashes match. This is a source-only verdict: no native execution or runtime census establishes readiness or merge approval.

[teamleaderleo]

Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 71c6f3a

SHIP

1. No blocking source findings across all 33 cumulative changed files, including all 22 modified test files. Startup/reconnect draining, partial setup cleanup, browser/panel caches, and AppKit close paths reviewed.
2. ci-target-graph.json:1 exactly matches base; generator-computed test-resource reads are unchanged.

Source verdict only for 71c6f3ac024379436e6d27747209e00f0f17fc96. No native compile, runtime, or census validation; no readiness inferred.

Coordinator must request lawrencecchen, post the awareness comment, and launch the fresh-home fleet at this final head—no reply-wait gate. Those external actions were unavailable here. No branches modified; PR #26809 HOLD untouched.

[teamleaderleo]

Review (codex gpt-6-astra high, next-review): SHIP at a36713a

No blocking findings.

Review covered the supplied diff and files. Additional repository reads were blocked by environment policy; macOS tests were not run.

[cmux-bot]

cmux-bot approves a36713a: an independent review passed this exact head (next-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

[teamleaderleo]

take it

[teamleaderleo]

Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at c26c33d

BLOCK

1. [P2] ArtifactPanel.tsx:66: The new artifact preview is unreachable with agent.pageHost or agent.chromium enabled. Those hosts use cmux-page://cmux.agent, but canRender() accepts only cmux-agent:, so HTML/JSX artifacts show only Code. The frame URL also remains hardcoded to the legacy endpoint. Wire both the preview capability and frame URL to the newly added cmux-page://cmux.agent/__artifact endpoint.

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[teamleaderleo]

Fresh-home launch of b14c3d133e12 on a fleet capture Mac (empty HOME, CFFIXED_USER_HOME, TMPDIR and defaults): PASS

Verdict	PASS
Build	fleet job 1048c2a8c4e76ac65d30dd88 of b14c3d133e12
Validator	scripts/ci/fresh_home_launch_smoke.py from feat-cmux-next at 25d8da5fcd97
Home rendered	7.4s after launch
Up	30s
first_window_frame_committed	5169 ms
Crash reports / uncaught exceptions	0 / 0

cmux-ci fresh-home --job 1048c2a8c4e76ac65d30dd88 --pr N (commit status cmux-ci/fresh-home on b14c3d133e12)

[teamleaderleo]

Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at b14c3d1

BLOCK

1. Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/PinnedPageTests.swift:29-32 — endpoint() removes its unstructured ensure task from ensures in defer as soon as the caller is cancelled. DaemonConnection.close() cancels the caller while ensureEndpoint() continues running, so reap() can miss that in-flight launch, report success, and delete the temporary state directory before server ensure finishes. The daemon can then start after teardown and outlive the test.

2. Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/PinnedPageTests.swift:70-83,97-105 — record adds every endpoint to endpoints even when process verification fails (processes[endpoint] remains nil), but reap still runs the graceful shutdown closure first. That closure connects to the endpoint and issues shutdownDaemon; if the socket now belongs to a replacement or otherwise unverified daemon, teardown can shut down a process the test never established ownership of. The “unverified live process is left alone” safeguard only applies after this potentially destructive shutdown attempt fails.

[teamleaderleo]

Superseded by #28093, a backlog-drain carry that keeps this PR's commits and their authorship and repairs its BLOCK findings. Closing this one in its favour.

[teamleaderleo]

Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at 2a72ab7

BLOCK

1. Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/PinnedPageTests.swift:152-154 treats kernelProcess(pid:) == nil as proof that the daemon exited after graceful shutdown. That API can also return nil when the process identity is temporarily unreadable; the fallback below explicitly treats unreadable identity as insufficient evidence. This can report a live daemon as reaped and delete its state directory, leaving an owner running against removed state.