Repository navigation
fix(agent-pane): Preview tab-row tools reach the edge beside pushed Session Info - #27225
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Passes: CI passes on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 855e015; does not block Gallery before/after for
States
Pick other states with a |
|
Bead |
|
Found 6 test failures on Blacksmith runners: Failures
|
|
Review (codex gpt-6-astra high, review box): BLOCK at fc457e2 Independent box review-27225-fc45 (relayed by claude-sr2):
Fix: make the summed width rule cover the no-tab-row header too, or keep the old rule for that case, with a browser test for Push at tabRow.height 0 (tool positions unchanged, clicks still land). Posted by orchestration-ui. |
|
Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at ad7deca SHIP No findings. |
|
Queue audit at head ad7deca: the aggregate's Base comparison: I ran Separate unresolved red: risk evidence job says |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Takes back #27189: this replaces #27189's Preview-only header width rule (and #27122's Summary-only one) with one summed rule for every pushed side panel, because #27189's rule overrode the pushed Session Info width (review-27189-816e's P2). The behavior both PRs fixed is kept and covered by the same browser tests.
Takes back #27122: its Summary-column header width rule folds into the same summed rule; the Summary still sits below the tab row, at 28px and 40px rows.
Takes back #26372: its Push-always header width rule (
width: var(--acpmux-header-room, 100%)) becomes the--acpmux-inspector-pushterm of the same summed rule, so with Push always the header still keeps the room measured before the column, and the tab-row tools stay fixed.Fixes the P2 that review-27189-816e found in #27189 (landed as 0b016a3).
The box reported:
The tab-row header now has one additive width rule. Summary, pushed Session Info and side-by-side Preview each contribute an optional shell term; overlay Preview contributes zero. This keeps the tools at the pane edge when either panel is present alone or when both are pushed together.
Leo, 2026-10-28:
Risk: normal — additive responsive CSS geometry for the existing web tab-row and side panels. No defaults, protocol, native implementation or product surfaces outside this placement rule changed.
Validation:
scripts/web-lint.shpasses.Gallery comparison: synthetic Linux gallery stills for Preview + pushed Session Info at the offered 28px row, light and dark. The tools span the full pane edge without intersecting either side panel.
The before state is the base regression covered by the red-first test; the after stills will be attached to this PR.
Agent session: agent session