Skip to content

fix(agent-pane): keep Preview tab-row tools visible - #27189

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
lane/orch-preview-tools
Oct 29, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
lane/orch-preview-tools

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Preview open in the shared native tab row hid the chat's trailing tools: the Preview shell sibling consumed the panel column while the header stayed sized to the chat column. The Summary path already stretches its header over its sibling; Preview now uses the same responsive artifact width and keeps the tab-row tools at the pane edge. Narrow overlay mode keeps the header at the full shell width.

This is a fix-forward for #27122. It changes only the web tab-row and Preview placement CSS; #27133 and #27135 are untouched.

Leo, 2026-10-28:

"What the fuck is this? Why is this BACKGROUND STILL FUCKING EXIST ON THE RIGHT FUCKING BUTTONS??? What the fuck? How is this happening? How is this fucking issue been plaguing us for so fucking long? What is this? It's fixed, right? And the next fucking night it's fixed, right?"

Risk: normal — responsive CSS geometry for the existing Preview sibling and shared tab-row header. No defaults, protocol, or native implementation changes.

Validation:

  • Red browser assertions were committed first: Preview at 28px and 40px rows had non-zero web tools whose right edge stopped at the chat column (540px) instead of the 1000px shell edge.
  • Green browser coverage checks Preview and Summary at 28px and 40px rows, 640px narrow overlay and 1000px side-by-side layouts, in light and dark themes. Preview tools are non-empty and end at the shell edge; Preview remains below the offered row.
  • Local Node 24 scripts/web-lint.sh passes; focused browser suites pass (19 tests, 84 assertions).
  • Linux gallery captures cover Preview open and Summary open in light/dark at 28px and 40px rows. Before captures are the feat-cmux-next geometry; after captures are this head.

Gallery comparison: synthetic Linux gallery, Preview and Summary open, offered row at 28px/40px. The before Preview stills show the tools ending at the chat column; after spans the Preview sibling to the shell edge. Summary remains unchanged.

Surface Theme Before (base) After
Preview Dark Preview before dark Preview after dark
Preview Light Preview before light Preview after light
Summary Dark Summary before dark Summary after dark
Summary Light Summary before light Summary after light

Agent session: agent session

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 816ee5d: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr27189 -f ref=lane/orch-preview-tools -f platform=macos -f backend_mode=local

Gallery before/after for 127a023: 16 states rendered, 0 images differ, 1032 more touched states not rendered. Images are in the run's artifact, not on this public PR.

gh run download 40815918575 -R manaflow-ai/cmux -n gallery-advisory-27189-127a023e85a00ac189f9c05ebc7b07faa1d0bc03 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.chat-find-bar/empty Apple System Colors Light unchanged 0% own conversation.css
agent-pane.chat-find-bar/empty Apple System Colors unchanged 0% own conversation.css
agent-pane.chat-find-bar/matches Apple System Colors Light unchanged 0% own conversation.css
agent-pane.chat-find-bar/matches Apple System Colors unchanged 0% own conversation.css
agent-pane.chat-find-bar/next-match Apple System Colors Light unchanged 0% own conversation.css
agent-pane.chat-find-bar/next-match Apple System Colors unchanged 0% own conversation.css
agent-pane.chat-find-bar/no-results Apple System Colors Light unchanged 0% own conversation.css
agent-pane.chat-find-bar/no-results Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/claude-key Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/claude-key Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/deepseek-key Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/deepseek-key Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/sign-in Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/sign-in Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/rate-limited Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/rate-limited Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/on-coderouter Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/on-coderouter Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/moving Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/moving Apple System Colors unchanged 0% own conversation.css
agent-pane.continuation-spacing/shipped Apple System Colors Light unchanged 0% own conversation.css
agent-pane.continuation-spacing/shipped Apple System Colors unchanged 0% own conversation.css
agent-pane.continuation-spacing/two-thirds Apple System Colors Light unchanged 0% own conversation.css
agent-pane.continuation-spacing/two-thirds Apple System Colors unchanged 0% own conversation.css
agent-pane.continuation-spacing/half-tucked Apple System Colors Light unchanged 0% own conversation.css
agent-pane.continuation-spacing/half-tucked Apple System Colors unchanged 0% own conversation.css
agent-pane.continuation-spacing/before Apple System Colors Light unchanged 0% own conversation.css
agent-pane.continuation-spacing/before Apple System Colors unchanged 0% own conversation.css
agent-pane.copy-controls/output Apple System Colors Light unchanged 0% own conversation.css
agent-pane.copy-controls/output Apple System Colors unchanged 0% own conversation.css
agent-pane.diff-panel/unified-narrow Apple System Colors Light unchanged 0% own conversation.css
agent-pane.diff-panel/unified-narrow Apple System Colors unchanged 0% own conversation.css

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: green on the base 68e51e8; do not merge until green; see lane-rules

@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-2uc61f created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (Astra): SHIP at 816ee5d

No concrete correctness findings in the pinned CSS and browser-test diff. git diff --check passes; heavy tests were not run per instruction.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (Astra; carried): SHIP at 127a023

127a023 is the lander's base merge into 816ee5d, and the PR's own diff has the same patch-id (49bd0fce), so the Astra SHIP at 816ee5d carries. The earlier health (2) red, agent-pane.composer-context#computer-search (waitFor 5000 ms, about 5.76 s on all three tries), comes from a scene this PR can't reach: the PR's CSS changes only artifact and header widths, and the scene waits for one environment option after a search. Gallery health reruns at this head.

@blacksmith-sh

blacksmith-sh Bot commented Oct 29, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp51ajsrxh/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpq6jfk_9g/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit 0b016a3 into feat-cmux-next Oct 29, 2026
149 of 151 checks passed
@teamleaderleo
teamleaderleo deleted the lane/orch-preview-tools branch October 29, 2026 04:20
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

lawrencecchen added a commit that referenced this pull request Oct 30, 2026
…om/over" (#27725)

* review_receipt: a receipt is carried only by its label or "carried from/over", never a word of its verdict

cmux#27632's independent review read "Review (independent review subagent): SHIP at feae730... the warning
carries the whole finding." CARRIED (\bcarr(y|ies|ied|ying)\b anywhere on the first line) filed it as a lane's
carried claim, so with no other SHIP behind it the gate answered "no SHIP review receipt on this head". The lanes
write the marker in the reviewer label, "Review (<reviewer>; carried): SHIP at <head>" (cmux#26809, #26988, #27008,
#27189); CARRIED now matches the word there, or "carried from" / "carried over" anywhere on the first line.
cmux-review's SKILL.md now says how to write a receipt and a carried receipt. cmuxterm-hq next_autoland.CARRIED gets
the same rule; its agent-guards copy is re-pinned to this commit after it lands.

Test (fails on the base): the #27632 line passes alone; the real carried forms and "carried from/over" are carried
and never pass alone; "carries over" / "carried" in other prose is not.

Co-Authored-By: Claude <noreply@anthropic.com>

* review_receipt: docstring and SKILL.md say the rule as the checkers apply it (review)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 127a023e Deployed Oct 29, 2026 by teamleaderleo via wait for same-key tree publisher #74861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant