Repository navigation
fix(agent-pane): keep Preview tab-row tools visible - #27189
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: green on the base 68e51e8; do not merge until green; see lane-rules |
|
Bead |
|
Review (Astra): SHIP at 816ee5d No concrete correctness findings in the pinned CSS and browser-test diff. git diff --check passes; heavy tests were not run per instruction. |
|
Review (Astra; carried): SHIP at 127a023 127a023 is the lander's base merge into 816ee5d, and the PR's own diff has the same patch-id (49bd0fce), so the Astra SHIP at 816ee5d carries. The earlier health (2) red, |
|
Found 6 test failures on Blacksmith runners: Failures
|
|
Shipped in:
|
…om/over" (#27725) * review_receipt: a receipt is carried only by its label or "carried from/over", never a word of its verdict cmux#27632's independent review read "Review (independent review subagent): SHIP at feae730... the warning carries the whole finding." CARRIED (\bcarr(y|ies|ied|ying)\b anywhere on the first line) filed it as a lane's carried claim, so with no other SHIP behind it the gate answered "no SHIP review receipt on this head". The lanes write the marker in the reviewer label, "Review (<reviewer>; carried): SHIP at <head>" (cmux#26809, #26988, #27008, #27189); CARRIED now matches the word there, or "carried from" / "carried over" anywhere on the first line. cmux-review's SKILL.md now says how to write a receipt and a carried receipt. cmuxterm-hq next_autoland.CARRIED gets the same rule; its agent-guards copy is re-pinned to this commit after it lands. Test (fails on the base): the #27632 line passes alone; the real carried forms and "carried from/over" are carried and never pass alone; "carries over" / "carried" in other prose is not. Co-Authored-By: Claude <noreply@anthropic.com> * review_receipt: docstring and SKILL.md say the rule as the checkers apply it (review) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Preview open in the shared native tab row hid the chat's trailing tools: the Preview shell sibling consumed the panel column while the header stayed sized to the chat column. The Summary path already stretches its header over its sibling; Preview now uses the same responsive artifact width and keeps the tab-row tools at the pane edge. Narrow overlay mode keeps the header at the full shell width.
This is a fix-forward for #27122. It changes only the web tab-row and Preview placement CSS; #27133 and #27135 are untouched.
Leo, 2026-10-28:
Risk: normal — responsive CSS geometry for the existing Preview sibling and shared tab-row header. No defaults, protocol, or native implementation changes.
Validation:
scripts/web-lint.shpasses; focused browser suites pass (19 tests, 84 assertions).Gallery comparison: synthetic Linux gallery, Preview and Summary open, offered row at 28px/40px. The before Preview stills show the tools ending at the chat column; after spans the Preview sibling to the shell edge. Summary remains unchanged.
Agent session: agent session