Repository navigation
ci(signing): the owned signing pick accepts the nightly slot label - #27113
Merged
Merged
Conversation
…el, as the nightly build picker does Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 28, 2026 23:23 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
Owned by an agent session · session |
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 28, 2026 23:27 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
Bead |
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #26944. An independent review at #26944's head (posted just before it landed) found that
scripts/ci/signing_runner.pyonly accepted persistent pool labels.vars.CI_NIGHTLY_NEXT_BUILD_RUNNERmay name glaeda's nightly slot label (glaeda-nightly-<class>-xcode-<ver>). When it does, the owned pick came back empty and signing fell back to Blacksmith.Leo, 2026-10-28: "ok. idk what the "risk" was before but like.. we can just read the code and stuff."
What changed
nightly_build_runner.owned_label: a persistent pool or the nightly slot. A signing job on that runner is still admitted only as glaeda's exclusive class, and the claim gate still requires it.tests/test_ci_signing_owned_mac.pycovers a drained nightly-slot runner.Before / after
Owned signing stays off until
CI_SIGN_OWNED=1. Risk: low.Agent session: agent session
🤖 Generated with Claude Code