Repository navigation
fix(next): let transcript reading surfaces follow chat text size - #26875
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on b43bd42 to compare; do not merge until green; see lane-rules Gallery before/after for
States
Pick other states with a |
|
Bead |
|
Found 34 test failures on Blacksmith runners: Failures
...and 24 more test failures. View all on Blacksmith
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
|
Independent Codex gpt-6-astra xhigh: SHIP at Primary inspection also confirms transcript CSS, fixture/test and ratchet-baseline scope, with no composer, chatDisplay or store edits. Supplied final-head browser run 40697890018 passed 2 tests; all four PR-head web shards passed. The named gallery red is |
|
Landing is BLOCKED at Although the four head web jobs report SUCCESS, their raw test steps can fail and defer the decision to the separate base-comparison jobs. In shard 1 comparison, The other named comparison failures still need classification; they have not been waived as base reds. The currently uploaded 14/28px captures both show the final head, so an actual base-before/head-after pair at the same font/window is also requested from the transcript owner. No source or PR head was changed during this review. |
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Review (codex gpt-6-astra high, next-review): SHIP at 9876b3a No blocking findings. Reviewed the supplied diff and file copies. Tests were not run; additional repository reads were unavailable. |
|
Orphaned: no activity for 13 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged |
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Review (codex gpt-6-astra high, next-review): SHIP at e8e51ef No blocking findings. |
GitHub Actions
Inactive
|
Noting this for awareness from a transcript polish audit at feat-cmux-next 66f4014. This PR fixes size, line-height and min-height for the reading surfaces, but one parity case is still open: PlainCode ignores the code font family, while HighlightedCode honors it.
So a code block's font changes with whether it got syntax highlighting. If this PR is the right home, the fix is to use |
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Owned by an agent session · took over from an earlier session · session |
Resolved webviews/scripts/design-tokens-baseline.jsonl by taking base's rows and regenerating with check-design-tokens.ts --update-baseline: this PR replaces the fixed 45.5px and 44px heights with font-scaled min-heights, so those two baseline rows shrink. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ab1f035a409b977caceb
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 3ae6f12 SHIP No blocking findings. Type-scale validation passed. Browser tests and macOS compilation could not run because the snapshot lacks installed dependencies and Swift tooling. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40932085190 at 4efc389 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
Shipped in:
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40931922742 at 52b0452 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
The Agent Chat font-size setting now reaches transcript code headers, command output, footnotes, sign-in actions, diagram labels and media titles. Headers grow with their text, long shell and credential controls wrap, and output previews retain eight rendered lines. The 14px default keeps its existing header dimensions.
This is the focused transcript follow-up to closed, unmerged #26577 (handoff). Landed #26523 /
35e4e8eb9c3a9963ce9619db984799356ae7ea1calready supplies composer, New Tab, queued prompt, heading and table sizing; this PR preserves that work. #26628 owns font-size shortcuts and the font store separately.The fixture renders the real transcript components. Browser coverage changes the Agent Chat setting to 10, 14 and 28px, checks text and header containment at 760px and a 390px viewport with 125% zoom, and exercises image titles and credential actions in Chromium and WebKit, light and dark. Claude desktop transcript at 14px, see private ref. The captures below contain only the public fixture.
Verification
5b3c1ee7a25c84cfaa845cead386d250161830ee: both themes fail because the code header stays 14px when the setting is 10px.git diff --checkpass locally.a79611c418093c29a892627be44f42f20876f6a2, 2 tests passed across Chromium and WebKit in both themes (37.37s); 48 captures retained.dc567af89a3c7b6860a9b92510142a980b3625c0. The final commit corrects the default border-box test expectation from 33px to 32px and removes two formatting-only CSS changes; the final browser run verifies that correction.scripts/verify-local.pypasses its other ten executed checks; localization parity fails in untouched base catalogs. No native build or test was requested or run.Captures
14px and 28px, dark and light, from the exact published head:
WebKit image header at 28px, 390px viewport and 125% zoom:
Changelog
Fixed: Agent Chat text size applies to transcript reading surfaces without clipping their headers or output previews.
Agent session: agent session