Skip to content

test(next): restore New Tab gallery interactions - #26828

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/nx-newtab-gallery-26812
Oct 28, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/nx-newtab-gallery-26812

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

The New Tab gallery rendered its controls but three plays could not reach their intended state. The headline play searched for the old cmux, option name while the current searchable option is cmux /Users/you/src/cmux. The attachment play looked for the + and file input in the footer after the split composer moved both inside .nt-composer.

The plays now target the current accessible option and mounted composer. A Chromium regression test verifies that all four named variants reach their visible end states without exceptions, missing targets, popup errors, or anchor movement. It keeps the strict gallery layout-shift limit of zero. Selecting a project currently changes the headline and folder chip and records CLS 0.002726336640625 (sources: .nt-headline, picker button, location label, and icon); consequently picked and picker-open still report a layout-shift quality failure. That product issue is separate from this gallery-selector repair and remains visible. The attachment-menu and style-switch plays pass. Product components and CSS are unchanged.

Mounted Chromium gallery captures, 1000×800 at 2×, same variants on base d4f78c080b910185b7e41c519d6b7c10305ba1ac and the changed gallery tree 95171a47976e12ca67a3daa26b57b43651dd306d (final head 569ca86d3f40a6f63dd1fd571b212e464aafda8a adds only a test assertion). These are synthetic gallery fixtures, not native app captures:

State Before After
Picked project, light Before: picked project light After: picked project light
Project picker open, light Before: picker open light After: picker open light
Attachment menu, light Before: attachment menu light After: attachment menu light
Picked project, dark Before: picked project dark After: picked project dark
Project picker open, dark Before: picker open dark After: picker open dark
Attachment menu, dark Before: attachment menu dark After: attachment menu dark

Base gallery: three named plays failed due stale targets; style-switch passed. Current tree: all four reach their target without play errors, attachment-menu and style-switch report pass, and the two headline plays retain the named strict CLS failure. Focused browser test: 4 pass, 45 assertions (CMUX_BROWSER_TESTS=1 bun test test/new-tab-gallery-reached.test.ts). scripts/web-lint.sh passes. No native CI or build was dispatched for this gallery-only change.

Agent session: agent session

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 569ca86: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26828 -f ref=lane/nx-newtab-gallery-26812 -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on 569ca86d3f (run 40668561990 attempt 1): 3 code, 1 unknown.

Job Verdict Why
web / react-apps-base-check (3) code a web test failed
web / react-apps-base-check (2) code a web test failed
web / react-apps-base-check (1) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs agent-pane-background-tasks.test.ts the summary card lists the chat's background tasks: running ones first, the finished folded: failed (job)
  • seen on other PRs agent-pane-chat-unavailable.test.ts loading never shows the unavailable text: a slow attach, then a machine still connecting: failed (job)
  • seen on other PRs agent-pane-chat-unavailable.test.ts a chat whose machine goes offline names it, says when it was last seen, and Reconnect opens it: failed (job)
  • seen on other PRs agent-pane-hairline-focus.test.ts composer at 1x: focus is the resting hairline a step brighter, no ring: failed (job)
  • seen on other PRs agent-pane-hairline-focus.test.ts newtab at 1x: focus is the resting hairline a step brighter, no ring: failed (job)
  • seen on other PRs agent-pane-hairline-focus.test.ts composer at 2x: focus is the resting hairline a step brighter, no ring: failed (job)
  • seen on other PRs agent-pane-hairline-focus.test.ts newtab at 2x: focus is the resting hairline a step brighter, no ring: failed (job)
  • seen on other PRs agent-pane-hairline-focus.test.ts under Increase Contrast a focused edge keeps the resting edge, never a dimmer one: failed (job)
  • seen on other PRs agent-pane-dock-gutters.test.ts chromium > the gutter beside every part of the stack scrolls the transcript, and the part keeps the ...: failed (job)
  • seen on other PRs agent-pane-dock-gutters.test.ts webkit > the gutter beside every part of the stack scrolls the transcript, and the part keeps the po...: failed (job)
  • ... 14 more in the job logs
Matched log lines
web / react-apps-base-check (3): (fail) the summary card lists the chat's background tasks: running ones first, the finished folded [957.39ms]
web / react-apps-base-check (2): (fail) chromium > the gutter beside every part of the stack scrolls the transcript, and the part keeps the pointer [8717.50ms]
web / react-apps-base-check (1): (fail) only page.css imports the page's sheets [32.56ms]

Not re-run automatically: web / react-apps-base-check (3), web / react-apps-base-check (2), web / react-apps-base-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; base red: the same failure on the base bd735a6; does not block
red: web / react-apps-base-check (1); no finished base run on bd735a6 to compare; do not merge until green; see lane-rules
red: web / react-apps-base-check (2); no finished base run on bd735a6 to compare; do not merge until green; see lane-rules
red: web / react-apps-base-check (3); no finished base run on bd735a6 to compare; do not merge until green; see lane-rules
red: web / react-apps-check; base red: the same failure on the base bd735a6; does not block

Gallery before/after for 569ca86: 16 states rendered, 5 images differ, 98 more touched states not rendered. Images are in the run's artifact, not on this public PR.

gh run download 40668594798 -R manaflow-ai/cmux -n gallery-advisory-26828-569ca86d3f40a6f63dd1fd571b212e464aafda8a (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.new-tab/empty Apple System Colors Light unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/empty Apple System Colors unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/machines-fleet Apple System Colors Light unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/machines-fleet Apple System Colors unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/model-picker-open Apple System Colors Light unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/model-picker-open Apple System Colors unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/reasoning-chip Apple System Colors Light unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/reasoning-chip Apple System Colors unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/catalog-fast-menu Apple System Colors Light unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/catalog-fast-menu Apple System Colors unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/reasoning-chip-stage Apple System Colors Light unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/reasoning-chip-stage Apple System Colors unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/minimal-default Apple System Colors Light unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/minimal-default Apple System Colors unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/widgets-all-off Apple System Colors Light unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab/widgets-all-off Apple System Colors unchanged 0% own NewTabScreen.gallery.ts
agent-pane.new-tab-headline/on Apple System Colors Light unchanged 0% own NewTabHeadline.gallery.ts
agent-pane.new-tab-headline/on Apple System Colors unchanged 0% own NewTabHeadline.gallery.ts
agent-pane.new-tab-headline/picked Apple System Colors Light changed 3.56% own NewTabHeadline.gallery.ts
agent-pane.new-tab-headline/picked Apple System Colors changed 3.43% own NewTabHeadline.gallery.ts
agent-pane.new-tab-headline/picker-open Apple System Colors Light changed 4.07% own NewTabHeadline.gallery.ts
agent-pane.new-tab-headline/picker-open Apple System Colors changed 3.93% own NewTabHeadline.gallery.ts
agent-pane.composer-look/goal-active Apple System Colors Light unchanged 0% same-folder NewTabHeadline.gallery.ts
agent-pane.composer-look/goal-active Apple System Colors unchanged 0% same-folder NewTabHeadline.gallery.ts
agent-pane.composer-look/goal-paused Apple System Colors Light unchanged 0% same-folder NewTabHeadline.gallery.ts
agent-pane.composer-look/goal-paused Apple System Colors unchanged 0% same-folder NewTabHeadline.gallery.ts
agent-pane.composer-look/newtab-codex-speed Apple System Colors changed 0.0283% same-folder NewTabHeadline.gallery.ts
agent-pane.composer-look/newtab-codex-speed Apple System Colors Light unchanged 0% same-folder NewTabHeadline.gallery.ts
agent-pane.composer-look/claude-chat Apple System Colors Light unchanged 0% same-folder NewTabHeadline.gallery.ts
agent-pane.composer-look/claude-chat Apple System Colors unchanged 0% same-folder NewTabHeadline.gallery.ts
agent-pane.composer-look/permission-pill-claude Apple System Colors Light unchanged 0% same-folder NewTabHeadline.gallery.ts
agent-pane.composer-look/permission-pill-claude Apple System Colors unchanged 0% same-folder NewTabHeadline.gallery.ts

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

@teamleaderleo
teamleaderleo force-pushed the lane/nx-newtab-gallery-26812 branch from a7db1e7 to 9f6db90 Compare October 28, 2026 09:52
@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-mvza8k created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build/
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build
View Logs
nightly.yml must derive the embedded key and sign every appcast through the helper/
nightly.yml must derive the embedded key and sign every appcast through the helper
View Logs
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)/
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit 5386b95 into feat-cmux-next Oct 28, 2026
160 of 171 checks passed
@teamleaderleo
teamleaderleo deleted the lane/nx-newtab-gallery-26812 branch October 28, 2026 10:13
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40671012262 at 193f745 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 5b6ffb3. This pull request is one of 4 merged since: #26828, #26810, #26376, #26767.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40672367480 at d92bb78 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 5b6ffb3. This pull request is one of 5 merged since: #26828, #26810, #26376, #26767, #26808.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 569ca86d Deployed Oct 28, 2026 by teamleaderleo via wait for same-key tree publisher #71207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant