Repository navigation
test(next): restore New Tab gallery interactions - #26828
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; base red: the same failure on the base bd735a6; does not block Gallery before/after for
States
Pick other states with a |
a7db1e7 to
9f6db90
Compare
|
Bead |
9f6db90 to
95171a4
Compare
|
Found 4 test failures on Blacksmith runners: Failures
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40671012262 at 193f745 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40672367480 at d92bb78 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
The New Tab gallery rendered its controls but three plays could not reach their intended state. The headline play searched for the old
cmux,option name while the current searchable option iscmux /Users/you/src/cmux. The attachment play looked for the+and file input in the footer after the split composer moved both inside.nt-composer.The plays now target the current accessible option and mounted composer. A Chromium regression test verifies that all four named variants reach their visible end states without exceptions, missing targets, popup errors, or anchor movement. It keeps the strict gallery layout-shift limit of zero. Selecting a project currently changes the headline and folder chip and records CLS
0.002726336640625(sources:.nt-headline, picker button, location label, and icon); consequentlypickedandpicker-openstill report a layout-shift quality failure. That product issue is separate from this gallery-selector repair and remains visible. Theattachment-menuandstyle-switchplays pass. Product components and CSS are unchanged.Mounted Chromium gallery captures, 1000×800 at 2×, same variants on base
d4f78c080b910185b7e41c519d6b7c10305ba1acand the changed gallery tree95171a47976e12ca67a3daa26b57b43651dd306d(final head569ca86d3f40a6f63dd1fd571b212e464aafda8aadds only a test assertion). These are synthetic gallery fixtures, not native app captures:Base gallery: three named plays failed due stale targets;
style-switchpassed. Current tree: all four reach their target without play errors,attachment-menuandstyle-switchreport pass, and the two headline plays retain the named strict CLS failure. Focused browser test: 4 pass, 45 assertions (CMUX_BROWSER_TESTS=1 bun test test/new-tab-gallery-reached.test.ts).scripts/web-lint.shpasses. No native CI or build was dispatched for this gallery-only change.Agent session: agent session