Repository navigation
cmux NEXT composer: searchable tools and sessions in the plus menu - #26616
teamleaderleo wants to merge 9 commits into
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 56f0399 to compare; do not merge until green; see lane-rules
Agents: Gallery before/after for
States
Pick other states with a |
|
Found 36 test failures on Blacksmith runners: Failures
...and 26 more test failures. View all on Blacksmith
|
|
Bead |
|
Review (codex gpt-6-astra high, next-review): SHIP at e32bd45 No blocking findings. |
e32bd45 to
d5fc7a7
Compare
71409fb to
0a76f85
Compare
d0a60fd to
3505bc7
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
3ae0f29 to
a87fc7d
Compare
|
Orphaned: no activity for 15 h, and no lane holds a lease on it. The orphan sweep could not merge |
After dependency db519 restores native Home/End editing in the search field, the skill-navigation fixture focuses the listbox for End and subsequent selection keys. The component input-editing regressions remain unchanged. Validation: inherited keyboard test failed after rebase (picked add.mention instead of skill23); all 37 focused tests in five isolated suites now pass, 140 assertions. bun run check passes. Native and GUI verification remain on HOLD; strict menu CLS acceptance awaits the separately owned shared-anchor repair. Agent-Session: https://cmux.com/deeplink/agent?id=aid-97c8fe4890b3452e72be
…es row The New Tab + is the shared PaletteMenu here, whose Add files row is data-value=add.files; the old menu's data-value=attach no longer exists, so new-tab-gallery-reached failed agent-pane.new-tab#attachment-menu in CI (run 40770678122, react-apps-base-check (1): red on this change, not on base). CMUX_BROWSER_TESTS=1 bun test test/new-tab-gallery-reached.test.ts: 1 fail / 3 pass before, 4 pass after (Chromium, Linux). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-97c8fe4890b3452e72be
0b505d5 to
78cd795
Compare
|
Review (codex gpt-6-astra high, next-review): SHIP at 78cd795 No blocking findings. |
|
Review (codex gpt-6-astra, router-review): SHIP at 78cd795 SHIP at 78cd795 Visual verdict: no images supplied (range review); the visual verdict must come separately
Follow-ups:
router-review: follow-up: [P2] [follow-up] Wire standalone/Quick Composer models to the catalog and action dispatcher, or explicitly scope this feature to tab-backed composers. |
A newer verdict blocks 78cd795 (a HOLD line in the body).
|
Before this lands: base replaced the + menu with one short menu for chat and New Tab (#28798, #30230), so the searchable tools and sessions sections need a redesign on that menu rather than re-adding them as + rows; the base merge also conflicts in 12 files. A mechanical merge would undo base's design, so this needs a rework. |
|
Tried a base merge (base at c874cb9); stopped without pushing because the resolution needs a design call, not a mechanical merge. What clashes:
Conflicts: 12 files (5 Swift, 7 web). Still open: whether the native Tools/Apps catalog gets one "Tools and apps…" row that opens a searchable sub-list (like "Commands and skills…"), lives under / instead, or is dropped. Once that is chosen, this should be redone on a fresh branch from base, not merged. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, 2026-10-28: “likewise, the chatgpt desktop app, let's do their + symbol's capabiliities for our composer. we want to be having more command palette related capabilities and stff to be able to to be surfaced”.
Mounts the shared searchable PaletteMenu from landed #26843 in Chat and New Tab. The host supplies only currently performable Tools, Apps, Sessions and Tabs catalog actions; selection uses the existing gesture-gated action.run route. Search Tabs opens its search page without a tab target; creation actions retain the current tab placement.
Catalog reads remain passive so untouched New Tab pages stay recyclable. Synchronous errors and rejected native actions keep the mounted palettes open and show an error; New Tab retains its draft and attachments. No timer or observer is added.
Stack: #26843 is merged. This PR contains only the native catalog and production mounting slice. #26859 owns New Tab capability rows and #27049 owns capture/Plan/Build App wiring. The shared PaletteMenu and registry API are unchanged.
Reference: ChatGPT desktop + menu, adapting its sectioned capabilities to cmux colors, glass and current popup styling.
Validation
Candidate:
78cd7956bc257827cee7a10356bbf08b9cd23155, base90e1666c0ff07ebbc896f0e5400f8a9de02a847a. Only the four parent commits after11a563002c080edc5a1bb4731c70104f27f6bfdewere rebased after the palette squash; the landed component commits were not replayed. Later fixes address passive reads and mounted error propagation.c66291449a712ab27f1e5e728ca3135dec78dfce(identical Swift sources to the final candidate); the final subsequent change only corrects the web callback return type.AgentPaneComposerActionsTestsandComposerPlusActionTargetTests(two tests in two suites), including passive catalog reads and Search Tabs placement.No capture: the Swift changes add catalog transport, passive-read handling and targeting of existing actions; they do not change native views, layout or styling. The visible changes are in webview menus, shown by the real Chromium gallery pairs below. No native GUI capture is claimed.
Before / after
Real gallery captures (Chromium, synthetic fixtures). Before is the stack base
3a7653b0; after is historical sourcea87fc7d3; these show the unchanged mounting design. The final rejection/passive-read repairs are covered by the tests below.3a7653b0)a87fc7d3)New Tab (
agent-pane.new-tab/attachment-menu, 900×560): before, + offers only Attach files or images. After, the same searchable palette as chat, with Tools, Apps, Sessions and Open Tabs from the native catalog. Chat (agent-pane.composer/add-menu, 760×560): the Add rows are unchanged, and the native catalog sections follow. Text under an open menu reads through its glass in these Chromium gallery frames. That is the documented Chromium backdrop behaviour (ui/glass/glass.css); the app's WebKit frosts it.Outstanding scope, kept explicit:
Status: exact hosted-check reconciliation pending.
HOLD: needs a redesign on the current + menu before landing: base now has one short + menu for chat and New Tab (#28798, #30230), so the native catalog sections cannot be re-added as + rows; the base merge also conflicts in 12 files.
Changelog
Added: The composer’s + menu searches and runs the app’s tools, apps, sessions and tabs.
Agent session: agent session