Skip to content

test(agent-pane): update stale integration expectations - #26511

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/agent-pane-test-contracts
Oct 28, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/agent-pane-test-contracts

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Several agent-pane integration tests still assert rendering that later changes replaced. Update them to preserve their behavioral checks against the current output-token label (#25118), virtualized thread rail (#25152), immediate removal of read steer controls (#25785), ended-agent avatars (#25205), Markdown message line breaks, and workerless code fallback. Mermaid now checks the complete refused source; the rail checks its accessible full-list size; ended avatars must stay outside the running wave.

Observed / Not run

  • Base 5b181c2efb9fd315e57ae3160dd44fc08aff6dbb: the grouped remote reproduction had 50 passing and 10 failing tests, including all seven assertions repaired here (run).
  • Head 7234540524875687c97953e2ed00cb2e60036967: 35 pass, 0 fail in run 40618673640. Snapshot fd7dd07d5441a5422fc2208c13ca98a1210de23a and head share tree f8ba0114255b6529f7a845f040930918842b8dbb.
  • Independent Astra review: SHIP at 7234540524875687c97953e2ed00cb2e60036967.
  • Focused command from webviews/: cmux-ci test --setup webviews --timeout 1800 -- bun test test/agent-pane-mermaid.test.tsx test/agent-pane-pending-steer.test.tsx test/agent-pane-turn-tokens-muted.test.tsx test/chat-minimap.test.tsx test/running-wave.test.tsx test/transcript-row-message.test.tsx.
  • scripts/web-lint.sh --new-only --base 5b181c2efb9fd315e57ae3160dd44fc08aff6dbb and python3 scripts/cmux-next/prepush-gate.py passed.
  • verify-local.py has unrelated localization debt, stale generated launch policy, and missing classic project/test paths on this base. Native compilation and app capture were not run for this test-only change.

Risk: low. No capture: test assertions only.

Changelog

none

Agent session: agent session

Existing regressions reproduced remotely at 5b181c2 (40617223054). Preserve diagram source, queued control removal, token styling, rail accessibility, ended-agent motion, and multiline message checks across current render paths. Focused green receipt recorded in PR.

Agent-Session: https://cmux.com/deeplink/agent?id=aid-5ed1a69546bdb09adbf5
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 7234540: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26511 -f ref=codex/agent-pane-test-contracts -f platform=macos -f backend_mode=local

Probably yours: chat-inspector-overlay-toggle.test.ts, composer-footer-plain.test.ts fails here but not on main's latest full suite. Seen on other PRs too (likely flaky): layout.test.ts, agent-pane-queue-scroll-bottom.test.ts, agent-pane-queue-scroll-bottom.test.ts and 19 more. This PR merged before its CI finished: fix forward on main.

CI failed on 7234540524 (run 40619105168 attempt 1): 3 code, 1 unknown.

Job Verdict Why
web / react-apps-base-check (4) code a web test failed
web / react-apps-base-check (3) code a web test failed
web / react-apps-base-check (1) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs layout.test.ts only page.css imports the page's sheets: failed (job)
  • seen on other PRs agent-pane-queue-scroll-bottom.test.ts chromium > a prompt the fold hides, run elsewhere, leaves no room as the stack shrinks, opens and cl...: failed (job)
  • seen on other PRs agent-pane-queue-scroll-bottom.test.ts webkit > the queue opened, the view scrolled to its end shows the last row whole, and it stays: failed (job)
  • seen on other PRs agent-pane-queue-scroll-bottom.test.ts webkit > the queue closed at the latest row keeps the last row on the stack, with no room that glide...: failed (job)
  • seen on other PRs agent-pane-queue-scroll-bottom.test.ts webkit > a prompt the fold hides, run elsewhere, leaves no room as the stack shrinks, opens and clos...: failed (job)
  • seen on other PRs agent-pane-queue-scroll-bottom.test.ts webkit > a prompt past the opened queue's cap, run elsewhere, leaves no room when the queue closes: failed (job)
  • seen on other PRs agent-pane-queue-scroll-bottom.test.ts webkit > in a chat switched to, a queued prompt withdrawn leaves no room held for the last chat's qu...: failed (job)
  • seen on other PRs agent-pane-queue-scroll-bottom.test.ts webkit > a new line in the composer leaves the transcript's distance from its end as it was: failed (job)
  • seen on other PRs accent-glass-invariants.test.ts no orange or system accent and no opaque glass on the gallery stages: failed (job)
  • seen on other PRs agent-pane-agents-pill.test.ts by default the running agents sit in the tray above the composer, not in the transcript: failed (job)
  • ... 14 more in the job logs
Matched log lines
web / react-apps-base-check (4): (fail) only page.css imports the page's sheets [30.72ms]
web / react-apps-base-check (3): (fail) no orange or system accent and no opaque glass on the gallery stages [585362.44ms]
web / react-apps-base-check (1): (fail) chromium > the gutter beside every part of the stack scrolls the transcript, and the part keeps the pointer [8615.93ms]

Not re-run automatically: web / react-apps-base-check (4), web / react-apps-base-check (3), web / react-apps-base-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; base red: the same failure on the base f2500c8; does not block
red: web / react-apps-base-check (1); no finished base run on f2500c8 to compare; do not merge until green; see lane-rules
red: web / react-apps-base-check (3); no finished base run on f2500c8 to compare; do not merge until green; see lane-rules
red: web / react-apps-base-check (4); no finished base run on f2500c8 to compare; do not merge until green; see lane-rules
red: web / react-apps-check; base red: the same failure on the base f2500c8; does not block

@teamleaderleo
teamleaderleo merged commit 2923183 into feat-cmux-next Oct 28, 2026
158 of 174 checks passed
@teamleaderleo
teamleaderleo deleted the codex/agent-pane-test-contracts branch October 28, 2026 02:09
@blacksmith-sh

blacksmith-sh Bot commented Oct 28, 2026

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build/
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build
View Logs
nightly.yml must derive the embedded key and sign every appcast through the helper/
nightly.yml must derive the embedded key and sign every appcast through the helper
View Logs
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)/
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40619334537 at 0c83363 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at cfe2fa2. This pull request is one of 4 merged since: #26338, #26502, #26511, #26507.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40620136681 at 49c2477 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at f2500c8. This pull request is one of 4 merged since: #26511, #26507, #26501, #26489.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 72345405 Deployed Oct 28, 2026 by teamleaderleo via wait for same-key tree publisher #68555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant