Repository navigation
cmux NEXT tests: the divider-under-dock tests pin a style that draws divider lines - #26338
Conversation
… draws divider lines aStripDividerUnderADockIsNotHoveredOrDrawnThere read the live DesignSettings. A settings test earlier in the same process (PaneChromeEvenGapTests' load(nil), PaneChromeEvenInsetTests' reset) leaves them at the app's defaults: chromeStyle flat-sidebar-line, pane separation none, which draws no hover line (showsDividerFeedback false). The hovered divider then drew nothing and :91 failed for .docked and .overlay in the full CmuxNextAppTests run only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cc8bff1c3ddb4ec353c5
|
Owned by an agent session · session |
|
Bead |
|
Review (codex gpt-6-astra xhigh, next-review): SHIP at 6699ad3 No blocking findings. The fixture change preserves all assertions and isolates the test from shared design settings. Review was limited to the supplied files; repository reads required unavailable approval. Tests were not run. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
Found 4 test failures on Blacksmith runners: Failures
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40618800354 at 46f5779 failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40619334537 at 0c83363 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40619221614 at fc4458f failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes a flaky red in the cmux NEXT
swift testjob (CmuxNextAppTests). It fails only in the full run and passes when its suite runs alone:(CI jobs 122247588853, 122242789085.)
Cause. This is test isolation, not #26100. A diagnostic build printed the handle's state at the failure: line color clear,
showsActiveLinefalse,model.style.paneSeparation == .none. The fixture'sLayoutModelfollows the process-wideDesignSettings. A fresh process has chromeStyledefault, which uses dividers or borders, and that draws a hover line. But settings tests that run earlier in the same process (PaneChromeEvenGapTests'load(nil),PaneChromeEvenInsetTests'reset) apply a cmux.json withoutappearance.chromeStyle. That leaves the app defaultflat-sidebar-line, whose separation isnone, andnonedraws no divider hover line (PaneSeparation.drawsDividerFeedback). So the result depended on test order.Change. The fixture pins its style with
model.followsDesignMetrics = false(baseLayoutStyle,.borders), as other layout tests already do. All of the test's assertions are unchanged.Fleet proof (full
CmuxNextAppTestsruns):No capture: test fixture only; nothing on screen changes.
Risk: none for the product. One test fixture line changes.
Independent review: Codex (gpt-6-astra, xhigh) SHIP.
Agent session: agent session
🤖 Generated with Claude Code