Repository navigation
composer: the account's Cloud machines in the machine list, with Resume and Open - #26013
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 8711a8c to compare; do not merge until green; see lane-rules Tour of Gallery before/after for |
|
Owned by an agent session · session |
|
Found 8 test failures on Blacksmith runners: Failures
|
|
Bead |
4cb8cc2 to
e87e612
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
|
e87e612 to
4921d6e
Compare
…me and Open The environment picker and the plain Computer menu (cmux#25955) list only the peers acpmux reports, so a paused Cloud machine, or one this Mac's acpmux never linked, was missing. A new chat's list now also reads the app's list (cloudMachine.list, cmux#26011) as it opens and every 5 s while open, and adds each machine acpmux does not list as a peer to Cloud and VMs with its stage: "Paused · Resume", "Open", "Starting…". A pick resumes a paused machine or opens it; no chat moves, and these rows take no ⌥⌘ digit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-4ba8980ae4e8eecb82d6
4921d6e to
8c7cc71
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, 2026-10-26: "the dropdown should show the states of stuff when you've done the acp things or any kind of connectivity."
Replaces draft #25305, built on #25955's structure. #25955 made the composer's machine list show every peer the local acpmux reports, with its state. A Cloud machine the local acpmux has no link to, a paused one for example, still didn't appear. This PR adds those machines from the app's own list (#26011,
cloudMachine.list).The native methods landed in #26011.
What changes
For a new chat, both the environment picker (previews on) and the plain Computer menu (previews off) now list the account's Cloud machines that acpmux doesn't list.
cloudMachine.resume) or opens it (cloudMachine.open). It doesn't move the chat, and the rows take no ⌥⌘ digit.useMachineRefreshtimer. That timer stops when the list closes. Only one request runs at a time.ComposerContextreads the list from a small store (cloudMachines.ts,useSyncExternalStore), so the composer and the New Tab page get it without new props throughComposerorNewTabScreen.The draft's other webview parts aren't taken:
needsLogin, and the automatic peer update already handles outdated peers.cloud-machine:ids.Before / after
Gallery renders, Chromium on Linux, at 4cb8cc2. The "before" is
agent-pane.composer-context/environment-pickerand/computer-menu, which have no account list, as on base. The "after" is the same machines plus three account machines: paused, ready and booting.Tests
test/environment-picker-cloud-machines.test.tsx, 11 tests:cloudMachine.list, thencloudMachine.resumeon a click).On Linux at 8c7cc71 (rebased over #25644): this suite,
environment-picker,composer-location-row-new-chat-onlyandnew-tab-saved-environmentsall pass (72 pass, 0 fail), along withtsc,vp fmt --checkand oxlint.Review (Codex gpt-6-astra xhigh):
onOpen; a test now covers it.onProjectis set. Without it the strip is read-only and nothing can be picked.Risk
Low. This is a small, contained machine-list change: new rows only for a new chat, and a pick runs an existing app action that the app validates again.
Gallery: agent-pane.composer-context/environment-picker-cloud-machines, agent-pane.composer-context/computer-menu-cloud-machines
Agent session: agent session
🤖 Generated with Claude Code