Skip to content

cmux NEXT: live states and actions in the shared machine picker - #25305

Closed
teamleaderleo wants to merge 3 commits into
lane/nx-machine-nativefrom
lane/nx-machine-status
Closed

teamleaderleo wants to merge 3 commits into
lane/nx-machine-nativefrom
lane/nx-machine-status

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

The chat composer's machine picker shows explicit daemon peer states and the app's current-account cloud inventory in the existing searchable combobox. Native cloud and peer rows keep separate identities through selection, keyboard shortcuts, and folder lookup. Resume/Open use the typed native seam; creation, SSH and pairing reuse existing flows. Update, login and agent-assisted setup link the setup guide when no supported picker flow exists.

Leo, 2026-10-26: "the dropdown should show the states of stuff when you've done the acp things or any kind of connectivity."

Depends on #25318. This PR is 782 changed lines against that native prerequisite. The New Tab button strip and its composer wiring follow separately. Existing permission and Labs saved-environment/worktree defaults remain unchanged.

Matched Claude desktop's apps/claude/live/environment-picker.png from cmux-design-references: Search, compact Local/Cloud hierarchy, trailing keyboard hints, separate creation actions, with cmux colors and glass. The gallery includes the status matrix, update and login variants; the matrix is the selected presentation because labels and trailing actions remain readable together. Before/after captures, final-head hosted proof and independent Codex Astra xhigh review are pending. No private Leo screenshots are published.

Earlier combined-head managed runs passed behavioral tests and both browser engines, and exposed inherited lint warnings in untouched DynamicWorkflow.gallery.tsx and chat-environment-scroll-stability.test.tsx. The split proof will compare those annotations with its exact untouched base and execute remaining type/protocol checks explicitly. Real-machine native capture remains pending with the machine-flow owners.

Agent session: big-red

@github-actions github-actions Bot added the risk:high Risk tier (docs/ci/risk-tiers.md) label Oct 26, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-zo9gk created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Found 9 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpx4q10hug/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpy8ea9u88/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
bench OTHER_SWIFT_FLAGS is 'OTHER_SWIFT_FLAGS=$(inherited) -DCMUX_BENCH_HOOKS -DCMUX_BL
OCKING_CHECKS'/
bench OTHER_SWIFT_FLAGS is 'OTHER_SWIFT_FLAGS=$(inherited) -DCMUX_BENCH_HOOKS -DCMUX_BL
OCKING_CHECKS'
View Logs
bench OTHER_SWIFT_FLAGS is 'OTHER_SWIFT_FLAGS=$(inherited) -DCMUX_BENCH_HOOKS -DCMUX_BL
OCKING_CHECKS'/
bench OTHER_SWIFT_FLAGS is 'OTHER_SWIFT_FLAGS=$(inherited) -DCMUX_BENCH_HOOKS -DCMUX_BL
OCKING_CHECKS'
View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next fast gates / post cmux-next/fast-gates is red on 18 of 18 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 061b914: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr25305 -f ref=lane/nx-machine-status -f platform=macos -f backend_mode=local

Gallery before/after for 061b914: 16 states rendered, 7 images differ, 1943 more touched states not rendered. Images are in the run's artifact, not on this public PR.

gh run download 40268034329 -R manaflow-ai/cmux -n gallery-advisory-25305-061b91412e00dcafc303e9244941c2bc86080b3a (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.chat-width/standard Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/standard Apple System Colors unchanged 0% own App.tsx
agent-pane.chat-width/wide Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/wide Apple System Colors unchanged 0% own App.tsx
agent-pane.chat-width/wide-blocks Apple System Colors Light changed 1.53% own App.tsx
agent-pane.chat-width/wide-blocks Apple System Colors unchanged 0% own App.tsx
agent-pane.composer/new-chat Apple System Colors Light unchanged 0% own Composer.tsx
agent-pane.composer/new-chat Apple System Colors unchanged 0% own Composer.tsx
agent-pane.composer/side-session Apple System Colors Light unchanged 0% own Composer.tsx
agent-pane.composer/side-session Apple System Colors unchanged 0% own Composer.tsx
agent-pane.composer/new-chat-suggest-open Apple System Colors Light unchanged 0% own Composer.tsx
agent-pane.composer/new-chat-suggest-open Apple System Colors unchanged 0% own Composer.tsx
agent-pane.composer/new-chat-suggest-failing Apple System Colors Light unchanged 0% own Composer.tsx
agent-pane.composer/new-chat-suggest-failing Apple System Colors unchanged 0% own Composer.tsx
agent-pane.composer/new-chat-suggest-draft Apple System Colors Light unchanged 0% own Composer.tsx
agent-pane.composer/new-chat-suggest-draft Apple System Colors unchanged 0% own Composer.tsx
agent-pane.composer/new-chat-reasoning Apple System Colors Light unchanged 0% own Composer.tsx
agent-pane.composer/new-chat-reasoning Apple System Colors unchanged 0% own Composer.tsx
agent-pane.composer/agent-home Apple System Colors Light unchanged 0% own Composer.tsx
agent-pane.composer/agent-home Apple System Colors unchanged 0% own Composer.tsx
agent-pane.composer/agent-home-path Apple System Colors Light unchanged 0% own Composer.tsx
agent-pane.composer/agent-home-path Apple System Colors unchanged 0% own Composer.tsx
agent-pane.composer-context/environment-status-matrix Apple System Colors Light new 0% own ComposerContext.gallery.tsx
agent-pane.composer-context/environment-status-matrix Apple System Colors new 0% own ComposerContext.gallery.tsx
agent-pane.composer-context/environment-needs-update Apple System Colors Light new 0% own ComposerContext.gallery.tsx
agent-pane.composer-context/environment-needs-update Apple System Colors new 0% own ComposerContext.gallery.tsx
agent-pane.composer-context/environment-needs-login Apple System Colors Light new 0% own ComposerContext.gallery.tsx
agent-pane.composer-context/environment-needs-login Apple System Colors new 0% own ComposerContext.gallery.tsx
agent-pane.composer-context/closed Apple System Colors Light unchanged 0% own ComposerContext.gallery.tsx
agent-pane.composer-context/closed Apple System Colors unchanged 0% own ComposerContext.gallery.tsx
agent-pane.composer-context/folder-menu Apple System Colors Light unchanged 0% own ComposerContext.gallery.tsx
agent-pane.composer-context/folder-menu Apple System Colors unchanged 0% own ComposerContext.gallery.tsx

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on e6251fb to compare; do not merge until green; see lane-rules

@teamleaderleo
teamleaderleo force-pushed the lane/nx-machine-status branch from 1332151 to 061b914 Compare October 26, 2026 04:14
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next fast gates / post cmux-next/fast-gates is red on 20 of 26 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

@teamleaderleo teamleaderleo changed the title cmux NEXT: live machine state and setup actions in composer cmux NEXT: live states and actions in the shared machine picker Oct 26, 2026
@teamleaderleo
teamleaderleo changed the base branch from feat-cmux-next to lane/nx-machine-native October 26, 2026 04:16
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing. #25955 (#25955) and #26013 (#26013) replace this draft.

Leo, 2026-10-26: "the dropdown should show the states of stuff when you've done the acp things or any kind of connectivity."

The branch is kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant