Skip to content

webviews: give the workflow gallery a11y roles their reasons, clearing the web lint base red #25543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 2 commits into from
Oct 26, 2026
Merged

webviews: give the workflow gallery a11y roles their reasons, clearing the web lint base red #25543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24dc641
webviews: give the workflow gallery's three a11y roles the reasons th…
teamleaderleo Oct 26, 2026
2bd3dec
Say precisely why an img cannot stand in for the sparkline
teamleaderleo Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions webviews/src/agent-session/acpmux/conversation/DynamicWorkflow.gallery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ function ProgressSparkline() {
<svg
className="workflow-gallery__sparkline"
viewBox="0 0 100 44"
// oxlint-disable-next-line jsx-a11y/prefer-tag-over-role -- the geometry below is built from the workflow's own numbers; an <img> would need it serialized first and could not update it.
role="img"
aria-label="Workflow progress sparkline"
>
Expand Down Expand Up @@ -134,6 +135,7 @@ function WorkflowSummary({ compact = false }: { compact?: boolean }) {
</div>
<div
className="workflow-gallery__progress"
// oxlint-disable-next-line jsx-a11y/prefer-tag-over-role -- a styled bar; <progress> cannot take the fill span.
role="progressbar"
aria-label="Workflow agents done"
aria-valuenow={WORKFLOW.done}
Expand Down Expand Up @@ -300,6 +302,9 @@ function DetailSheet() {
</div>
<WorkflowControls state={workflowState} onStateChange={setWorkflowState} />
</header>
{/* A roving tabindex: the tabs below take the focus and the list only routes their arrow
keys, so making the list itself focusable would add a tab stop ARIA does not want. */}
{/* oxlint-disable-next-line jsx-a11y/interactive-supports-focus */}
<div className="workflow-gallery__tabs" role="tablist" aria-label="Workflow detail tabs" onKeyDown={onTabKeyDown}>
<button
id="workflow-workflow-tab"
Expand Down
Loading