Repository navigation
webviews: give the workflow gallery a11y roles their reasons, clearing the web lint base red - #25543
Conversation
…e lint asks for `vp lint` reports three warnings in this file and exits 1, so the `web lint (fast)` job fails for every push that touches webviews, and a base lint red skips the checks after it in the same job (#22197). Nothing here is actually wrong: an inline SVG drawn from live numbers is not an `<img>`, a bar whose fill is a child span cannot be a `<progress>`, and a tablist with a roving tabindex must not be a tab stop itself. Every other site in this package that makes one of these choices already carries an `oxlint-disable-next-line` with its reason (`charts.tsx`, `ThemePreview.tsx`, `MessageActions.tsx`, `AttachmentViews.tsx`, `Tree.tsx`); this file was the one that did not. So this follows that convention rather than loosening the rule or changing the markup: comments only, no behaviour and no rendering change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9cc710fd4775017aab15
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI stopped on
Not re-run automatically: Written by red: web / Web status; NEW: green on the base 8b3b189; do not merge until green; see lane-rules Tour of Gallery before/after for
States
Pick other states with a |
github-actions
Bot
added
risk:normal
|
Bead |
The review called the old reason broad: an `<img>` can of course render an SVG, once it is serialized. What it cannot do is host geometry built from the workflow's own numbers and update it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9cc710fd4775017aab15
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (Codex gpt-6-astra, read-only, correctness first): SHIP at 2bd3dec Full review at From |
|
Shipped in:
|
web lint (fast)is red onfeat-cmux-next, which makes it a base red that hides signal: a lint failure skips the checks after it in the same job (#22197).The job's own output is the giveaway — it fails while reporting no errors at all:
All three are in one file,
webviews/src/agent-session/acpmux/conversation/DynamicWorkflow.gallery.tsx, and all three have been there since #24764/#24766 landed on Oct 23. It shows up intermittently because the job lints only the pushed range normally and sweeps every package when the push base is unknown (a new branch, a force push, a dispatch) — so the three warnings surface on those runs and not on the others.What changes
Nothing in the markup, and no rule is loosened. Five comment lines:
<img>cannot draw it;span, which<progress>cannot take;Every other place in this package that makes one of these same three choices already carries an
oxlint-disable-next-line … -- <reason>:pages/chief-usage/charts.tsx:91,pages/settings/components/ThemePreview.tsx:87,agent-session/acpmux/conversation/MessageActions.tsx:226,pages/home-channels/AttachmentViews.tsx:411, andui/Tree.tsx:149for the focus rule. This file was the only one that did not, so this applies the convention the repository already has.Changelog
none
Red, then green
Same command the CI job runs, from
webviews/:bun run lintbun run checkc2276c46The one warning that did not go away on my first attempt is worth naming:
interactive-supports-focusis reported against the element's opening line, so the disable comment has to precede the element, not sit among its attributes — which is the positionui/Tree.tsx:149already uses for this same rule (it writes its suppression as a//comment rather than a JSX one, so this matches its placement and not its syntax).bunx vp fmtthen adjusted my comment's wrapping, and that formatting is in the commit.Observed / Not run
Observed: both commands above at base and at this head, in a fresh
bun install --frozen-lockfilecheckout; the fullbun run checkgreen, type check included.Not run: nothing visual — this change produces no rendering difference, so there is nothing to capture. I did not touch the gallery's markup, behaviour or styles.
🤖 Generated with Claude Code
Agent session: agent session