Skip to content

fix(cmux-next): expose comment sequence to file extension - #24646

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
perf-fix-file-comments
Oct 23, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
perf-fix-file-comments

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

FilePageProvider stores latestCommentsSequence in FilePageProvider.swift, while publishComments reads and writes it from the FilePageProvider+Comments.swift extension. The private declaration is scoped to its declaring file, so the tip compile fails with latestCommentsSequence private access. This one-line visibility repair keeps the member package-internal and lets the extension compile.

Leo's review direction is the reason for this follow-up: "A compile red hides signal for every other lane."

Verification

  • Before: cx4-sb24513 compile at feat-cmux-next tip reported FilePageProvider+Comments.swift failing on latestCommentsSequence private access after perf(cmux-next): persist diff comments off the UI actor #24610 (b9c80fa8f9c7b74c173226bffe053726e204dee1).
  • Base fleet app compile-check: 2156baad9c1b4ddda54aa7cd at b47ac9a9845f693d0646ce2d65268b30c087a1cf ended red on unrelated inherited WorkspaceNameSource visibility errors; it did not report this file.
  • Fixed-head CmuxNextAppTests compile submissions: d591436f11814cd0594c22fa and targeted 4e38c871c32c66fc121726c0, both pinned to 64485ce6d69d683687a2d2774ccf2a4c9e774478; the fleet queue remained saturated and neither produced a terminal receipt before merge.
  • Independent Codex xhigh review of exact head 64485ce6d69d683687a2d2774ccf2a4c9e774478: SHIP, no P1/P2/P3 findings.
  • git diff --check passes.
  • No timers, observers, or cleanup paths were added.

Scope

One source declaration changed; no behavior or persistence flow changed.

Agent session: big-red

@cursor

cursor Bot commented Oct 23, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 64485ce: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24646 -f ref=perf-fix-file-comments -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on fbbf611 to compare; do not merge until green; see lane-rules

Tour of 64485ce6d6 (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-s2o5g created for this PR by the cmux coordinator.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 23, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Found 13 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp5o1p_h6_/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpl258s2xw/summary-missing.json (live):/summary-missing.json (live): View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett
ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_
inputs_still_rewrites_them) (job='repair')/
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett
ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_
inputs_still_rewrites_them) (job='repair')
View Logs
test_base_passes (main.NoticesPairTests.test_base_passes)/
test_base_passes (main.NoticesPairTests.test_base_passes)
View Logs
test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeave
sTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='repair')
/test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeav
esTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='repair'
)
View Logs

...and 3 more test failures. View all on Blacksmith: run 40036145552, run 40036145529

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit c4fbfd6 into feat-cmux-next Oct 23, 2026
121 of 137 checks passed
@teamleaderleo
teamleaderleo deleted the perf-fix-file-comments branch October 23, 2026 23:04
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…mpiles

#24627 (f8c226e) wrote `daemon.supports(...)` in TabMoves.newWorkspaceName, a static func with no
daemon in scope, so `daemon` was Darwin's daemon(Int32, Int32) and the app did not compile. It now reads the
source workspace's daemon as WorkspaceAutoNameWiring.allowsLegacyDefaults does (no daemon: legacy defaults
apply). (The FilePageProvider comment-sequence error from #24610 was fixed upstream by #24646.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 64485ce6 Deployed Oct 23, 2026 by teamleaderleo via namespace autofix #2089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant