Repository navigation
fix(cmux-next): expose comment sequence to file extension - #24646
Conversation
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on fbbf611 to compare; do not merge until green; see lane-rules Tour of |
|
Bead |
|
Found 13 test failures on Blacksmith runners: Failures
...and 3 more test failures. View all on Blacksmith: run 40036145552, run 40036145529
|
…mpiles #24627 (f8c226e) wrote `daemon.supports(...)` in TabMoves.newWorkspaceName, a static func with no daemon in scope, so `daemon` was Darwin's daemon(Int32, Int32) and the app did not compile. It now reads the source workspace's daemon as WorkspaceAutoNameWiring.allowsLegacyDefaults does (no daemon: legacy defaults apply). (The FilePageProvider comment-sequence error from #24610 was fixed upstream by #24646.) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Shipped in:
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
FilePageProviderstoreslatestCommentsSequenceinFilePageProvider.swift, whilepublishCommentsreads and writes it from theFilePageProvider+Comments.swiftextension. Theprivatedeclaration is scoped to its declaring file, so the tip compile fails withlatestCommentsSequenceprivate access. This one-line visibility repair keeps the member package-internal and lets the extension compile.Leo's review direction is the reason for this follow-up: "A compile red hides signal for every other lane."
Verification
feat-cmux-nexttip reportedFilePageProvider+Comments.swiftfailing onlatestCommentsSequenceprivate access after perf(cmux-next): persist diff comments off the UI actor #24610 (b9c80fa8f9c7b74c173226bffe053726e204dee1).2156baad9c1b4ddda54aa7cdatb47ac9a9845f693d0646ce2d65268b30c087a1cfended red on unrelated inheritedWorkspaceNameSourcevisibility errors; it did not report this file.CmuxNextAppTestscompile submissions:d591436f11814cd0594c22faand targeted4e38c871c32c66fc121726c0, both pinned to64485ce6d69d683687a2d2774ccf2a4c9e774478; the fleet queue remained saturated and neither produced a terminal receipt before merge.64485ce6d69d683687a2d2774ccf2a4c9e774478: SHIP, no P1/P2/P3 findings.git diff --checkpasses.Scope
One source declaration changed; no behavior or persistence flow changed.
Agent session: big-red