Skip to content

perf(cmux-next): persist diff comments off the UI actor - #24610

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
perf-agent-chat-diff-comments
Oct 23, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
perf-agent-chat-diff-comments

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Diff-comment list decoding, mutation, trimming, and encoding now run in a dedicated MarkdownCommentRepository actor. The page provider awaits that boundary and publishes the persisted JSON without doing comment work on the UI actor. A FIFO mutation queue and monotonic publication sequence preserve add/delete order across storage and JSON awaits; the current-file guard suppresses results after navigation.

Leo said yes.

Performance evidence

Same fixed harness: 100 comments added in order to one transcript-sized comment list, using the same injected storage and Xcode 26.6 fleet lane:

  • persistence total: 20.153875 ms -> 19.921 ms
  • per comment: 0.20153875 ms -> 0.19921 ms

The metric is total persistence work for the fixed sequence; parsing, mutation, encoding, and I/O are actor-isolated from the page actor. The final head adds ordering and navigation guards without changing the measured persistence path.

Validation

  • Fleet receipt 0253d85f9a65201e156b7c3f: MarkdownCommentRepositoryTests, 2 tests passed on aws-m4pro-3, Xcode 26.6; ThreadProbe was [false,false,false] and ordering/durability assertions passed.
  • Baseline fleet receipt 99647b4b47210ad624cb7d29: same harness on parent, 2 tests passed on aws-m4pro-6, Xcode 26.6.
  • Final-head rerun was queued, then cancelled after suite workers remained in host_lock; no native receipt exists for 17fa8720cebeaa95122b32712f24db4779648073.
  • Exact head: 17fa8720cebeaa95122b32712f24db4779648073.
  • No generated artifacts, timers, or observers were added.
  • No capture: this is persistence scheduling/actor isolation; no visual surface or copy changed.
  • Overlap audit found old PR cmux next files: chat file links open at their line, bare file names open, chat tools stay beside a chat with a new tab #22857 sharing FilePageProvider.swift and FilePageService.swift for unrelated file-line routing; this PR changes only the comment persistence path and has no shared symbols.

Agent session: big-red

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 17fa872: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24610 -f ref=perf-agent-chat-diff-comments -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 1effa89 to compare; do not merge until green; see lane-rules

Tour of 17fa8720ce (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 23, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Found 10 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp2og6n75g/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpv_nv35z6/summary-missing.json (live):/summary-missing.json (live): View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_base_passes (main.NoticesPairTests.test_base_passes)/
test_base_passes (main.NoticesPairTests.test_base_passes)
View Logs
test_targets_outside_the_app_go_to_the_mac_canary (main.SwiftCanaryFleetCoverage.te
st_targets_outside_the_app_go_to_the_mac_canary)/
test_targets_outside_the_app_go_to_the_mac_canary (main.SwiftCanaryFleetCoverage.te
st_targets_outside_the_app_go_to_the_mac_canary)
View Logs
the committed export failed: check-daemon-capabilities-fresh: plans/cmux-next/
daemon-capabilities.json is stale:
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo force-pushed the perf-agent-chat-diff-comments branch from 79e5d92 to 9f52824 Compare October 23, 2026 21:40
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-a9r1n created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo force-pushed the perf-agent-chat-diff-comments branch from cc6272c to 17fa872 Compare October 23, 2026 21:49
@teamleaderleo
teamleaderleo merged commit b9c80fa into feat-cmux-next Oct 23, 2026
127 of 136 checks passed
@teamleaderleo
teamleaderleo deleted the perf-agent-chat-diff-comments branch October 23, 2026 22:07
azooz2003-bit added a commit that referenced this pull request Oct 23, 2026
… compile red)

b9c80fa (#24610) sets latestCommentsSequence from the +Comments extension
in another file, but the property is private: "'latestCommentsSequence' is
inaccessible due to 'private' protection level" (fleet build
c245113c75ddae0600ce28ab).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…'s daemon; the comment sequence is internal

#24627 (f8c226e) wrote `daemon.supports(...)` in TabMoves.newWorkspaceName, a static func with no
daemon in scope, so `daemon` was Darwin's daemon(Int32, Int32) and the app did not compile. It now reads the
source workspace's daemon as WorkspaceAutoNameWiring.allowsLegacyDefaults does (no daemon: legacy defaults
apply). #24610 (b9c80fa) set FilePageProvider's private latestCommentsSequence from
FilePageProvider+Comments.swift, another file; it is internal now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…der's comment sequence is visible to its extension

Two more compile errors on feat-cmux-next from #24627 and #24610
(fleet compile-check job 0c66846f79c254a414e309b4):
- TabMoves.newWorkspaceName called `daemon.supports(...)` in a static func, which
  resolved to libc's daemon(3); it now asks the source workspace's daemon through
  services.machines.daemon(forWorkspace:), as WorkspaceAutoNameWiring does.
- FilePageProvider+Comments.swift wrote the private latestCommentsSequence of
  FilePageProvider.swift; it is internal now.
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…NextWorkspaceNaming, TabMoves)

- b9c80fa (#24610) reads latestCommentsSequence from
  FilePageProvider+Comments.swift while it stayed private to
  FilePageProvider.swift: now internal to the module.
- f8c226e (#24627) and 70be1be (#24628) put WorkspaceNameSource
  (CmuxNextDaemon) in public signatures of NewWorkspaceName and
  WorkspaceAutoName under an internal import: now a public import.
- f8c226e (#24627) read `daemon` in TabMoves.newWorkspaceName, where no
  such value exists (it resolved to Darwin's daemon(3)): it now asks the source
  workspace's own daemon, as WorkspaceAutoNameWiring.allowsLegacyDefaults does
  (no daemon: legacy defaults allowed).

CmuxNextApp and CmuxNextWorkspaceNaming did not compile on feat-cmux-next
(cmux-ci steps f1cbf88c2b78e129fd383836, 7ddea01f7ac1bccd493aebbb, compile
check 197c7d71ec98e5f8efdb2136).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…der's comment sequence is visible to its extension

Two more compile errors on feat-cmux-next from #24627 and #24610
(fleet compile-check job 0c66846f79c254a414e309b4):
- TabMoves.newWorkspaceName called `daemon.supports(...)` in a static func, which
  resolved to libc's daemon(3); it now asks the source workspace's daemon through
  services.machines.daemon(forWorkspace:), as WorkspaceAutoNameWiring does.
- FilePageProvider+Comments.swift wrote the private latestCommentsSequence of
  FilePageProvider.swift; it is internal now.
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…der's comment sequence is visible to its extension

Two more compile errors on feat-cmux-next from #24627 and #24610
(fleet compile-check job 0c66846f79c254a414e309b4):
- TabMoves.newWorkspaceName called `daemon.supports(...)` in a static func, which
  resolved to libc's daemon(3); it now asks the source workspace's daemon through
  services.machines.daemon(forWorkspace:), as WorkspaceAutoNameWiring does.
- FilePageProvider+Comments.swift wrote the private latestCommentsSequence of
  FilePageProvider.swift; it is internal now.
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…ivate latestCommentsSequence, #24627 internal CmuxNextDaemon import and C daemon() in TabMoves)
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…ivate latestCommentsSequence, #24627 internal CmuxNextDaemon import and C daemon() in TabMoves)
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…ivate latestCommentsSequence, #24627 internal CmuxNextDaemon import and C daemon() in TabMoves)
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…; the comment sequence is readable from its extension

- TabMoves.newWorkspaceName(for:services:) called daemon.supports(...) with no
  daemon in scope, so Swift resolved libc's daemon(_:_:) ("value of type
  '@sendable (Int32, Int32) -> Int32' has no member 'supports'"); it asks
  services.machines.daemon(forTab:) like the other moves. Broken by
  f8c226e (#24627).
- FilePageProvider.latestCommentsSequence was private while
  FilePageProvider+Comments.swift (another file) reads and writes it; it is
  internal. Broken by b9c80fa (#24610).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…'s daemon; the comment sequence is internal

daemon in scope, so `daemon` was Darwin's daemon(Int32, Int32) and the app did not compile. It now reads the
source workspace's daemon as WorkspaceAutoNameWiring.allowsLegacyDefaults does (no daemon: legacy defaults
apply). #24610 (b9c80fa) set FilePageProvider's private latestCommentsSequence from
FilePageProvider+Comments.swift, another file; it is internal now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…mpiles

#24627 (f8c226e) wrote `daemon.supports(...)` in TabMoves.newWorkspaceName, a static func with no
daemon in scope, so `daemon` was Darwin's daemon(Int32, Int32) and the app did not compile. It now reads the
source workspace's daemon as WorkspaceAutoNameWiring.allowsLegacyDefaults does (no daemon: legacy defaults
apply). (The FilePageProvider comment-sequence error from #24610 was fixed upstream by #24646.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…ompile (#24513 ThemeStore.shared, #24610 missing imports, #24635 let child)
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…ompile (#24513 ThemeStore.shared, #24610 missing imports, #24635 let child)
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…ompile (#24513 ThemeStore.shared, #24610 missing imports, #24635 let child)
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…sitoryTests imports, SidebarGroupLineLayoutTests var)

feat-cmux-next's CmuxNextAppTests did not compile (fleet compile-tests step
bbf3c4c87fb08a4528741f48 on aws-m4pro-2):
- MarkdownCommentRepositoryTests (#24610) names JSONValue, SettingWriter and
  RecoveryDraftAcceptance without importing CmuxNextSettings and CmuxNextDesign.
- SidebarGroupLineLayoutTests (#24635) sets child.parent on a let SidebarGroup
  (a struct).
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…sitoryTests imports, SidebarGroupLineLayoutTests var)

feat-cmux-next's CmuxNextAppTests did not compile (fleet compile-tests step
bbf3c4c87fb08a4528741f48 on aws-m4pro-2):
- MarkdownCommentRepositoryTests (#24610) names JSONValue, SettingWriter and
  RecoveryDraftAcceptance without importing CmuxNextSettings and CmuxNextDesign.
- SidebarGroupLineLayoutTests (#24635) sets child.parent on a let SidebarGroup
  (a struct).
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…; the comment sequence is readable from its extension

- TabMoves.newWorkspaceName(for:services:) called daemon.supports(...) with no
  daemon in scope, so Swift resolved libc's daemon(_:_:) ("value of type
  '@sendable (Int32, Int32) -> Int32' has no member 'supports'"); it asks
  services.machines.daemon(forTab:) like the other moves. Broken by
  f8c226e (#24627).
- FilePageProvider.latestCommentsSequence was private while
  FilePageProvider+Comments.swift (another file) reads and writes it; it is
  internal. Broken by b9c80fa (#24610).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…Settings

Its FilePageHosting stub uses JSONValue and SettingWriter (CmuxNextSettings),
which the file never imported. Added by b9c80fa (#24610). Test code only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…sitoryTests imports and typed sequences, SidebarGroupLineLayoutTests var)

feat-cmux-next's CmuxNextAppTests did not compile (fleet compile-tests steps
bbf3c4c87fb08a4528741f48 and 90534172dbdd07c288701002 on aws-m4pro-2):
- MarkdownCommentRepositoryTests (#24610) names JSONValue, SettingWriter and
  RecoveryDraftAcceptance without importing CmuxNextSettings and CmuxNextDesign,
  and its sequence check [Int] == [1, 2, 3] was an ambiguous use of == (the
  literal also fits IndexSet and IndexPath); the sequences are typed [Int].
- SidebarGroupLineLayoutTests (#24635) sets child.parent on a let SidebarGroup
  (a struct).
lawrencecchen added a commit that referenced this pull request Oct 23, 2026
…sitoryTests imports and typed sequences, SidebarGroupLineLayoutTests var)

feat-cmux-next's CmuxNextAppTests did not compile (fleet compile-tests steps
bbf3c4c87fb08a4528741f48 and 90534172dbdd07c288701002 on aws-m4pro-2):
- MarkdownCommentRepositoryTests (#24610) names JSONValue, SettingWriter and
  RecoveryDraftAcceptance without importing CmuxNextSettings and CmuxNextDesign,
  and its sequence check [Int] == [1, 2, 3] was an ambiguous use of == (the
  literal also fits IndexSet and IndexPath); the sequences are typed [Int].
- SidebarGroupLineLayoutTests (#24635) sets child.parent on a let SidebarGroup
  (a struct).
lawrencecchen added a commit that referenced this pull request Oct 24, 2026
Test code:
- AAGroupLineGalleryTests, SidebarStatusCleanupGalleryTests: ThemeStore.shared
  is gone since B3 (73c3d0d); they apply the theme through
  ThemeScope.app.store like the other galleries.
- SidebarGroupLineLayoutTests: SidebarGroup is a struct; the child the test
  re-parents is a var.
- MarkdownCommentRepositoryTests: its FilePageHosting stub uses JSONValue and
  SettingWriter, which come from CmuxNextSettings (missing import since
  b9c80fa, #24610).
Product, import-only build fix in the sidebar area (a590's), no behavior
change: CmuxNextAgentLanes/SidebarLocalLanes.swift's public extension of
AgentLaneStore takes WorkspaceModel and AgentTurnStateStore, so its imports of
CmuxNextAgentActivity, CmuxNextBridge and CmuxNextDaemon are public
(InternalImportsByDefault; c2e943f, #24651).
Product, one word: CmuxNextFeed/Views/FeedView.swift's FeedView declared
onReportsReply as a let with a default, which is not in the memberwise
initializer, so FeedHostView's FeedView(..., onReportsReply:) did not compile
("extra argument 'onReportsReply' in call"); it is a var (9222c97, #24616).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 24, 2026
Test code:
- AAGroupLineGalleryTests, SidebarStatusCleanupGalleryTests: ThemeStore.shared
  is gone since B3 (73c3d0d); they apply the theme through
  ThemeScope.app.store like the other galleries.
- SidebarGroupLineLayoutTests: SidebarGroup is a struct; the child the test
  re-parents is a var.
- MarkdownCommentRepositoryTests: its FilePageHosting stub uses types from
  CmuxNextSettings and CmuxNextDesign, which it never imported (b9c80fa,
  #24610).
Product, minimal build fixes, no behavior change:
- Import-only build fix in the sidebar area (a590's):
  CmuxNextAgentLanes/SidebarLocalLanes.swift's public extension of
  AgentLaneStore takes WorkspaceModel and AgentTurnStateStore, so its imports of
  CmuxNextAgentActivity, CmuxNextBridge and CmuxNextDaemon are public
  (InternalImportsByDefault; c2e943f, #24651); CmuxNextApp/SidebarBridge.swift
  imports CmuxNextAgentActivity for the members it uses.
- CmuxNextFeed/Views/FeedView.swift: onReportsReply is a var optional (no
  explicit nil, swiftlint) so the memberwise init takes it; a let with a
  default is not an init parameter (9222c97, #24616).
- CmuxNextAgentPane/AcpmuxMailboxClient.swift: public import Foundation (a
  public Date in its API).
- CmuxNextApp/Feed/FeedPageService.swift: the reply closure captures
  [services] explicitly (Swift 6). Its Process.run() on the main thread is
  unchanged (cmux-4f's PL-main owns it).
Errors found together with session cmux-4f's PL-main (origin/pl-main-testfix4
085eaa6), which dropped its push for this one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo pushed a commit that referenced this pull request Oct 24, 2026
Test code:
- AAGroupLineGalleryTests, SidebarStatusCleanupGalleryTests: ThemeStore.shared
  is gone since B3 (73c3d0d); they apply the theme through
  ThemeScope.app.store like the other galleries.
- SidebarGroupLineLayoutTests: SidebarGroup is a struct; the child the test
  re-parents is a var.
- MarkdownCommentRepositoryTests: its FilePageHosting stub uses types from
  CmuxNextSettings and CmuxNextDesign, which it never imported (b9c80fa,
  #24610).
Product, minimal build fixes, no behavior change:
- Import-only build fix in the sidebar area (a590's):
  CmuxNextAgentLanes/SidebarLocalLanes.swift's public extension of
  AgentLaneStore takes WorkspaceModel and AgentTurnStateStore, so its imports of
  CmuxNextAgentActivity, CmuxNextBridge and CmuxNextDaemon are public
  (InternalImportsByDefault; c2e943f, #24651); CmuxNextApp/SidebarBridge.swift
  imports CmuxNextAgentActivity for the members it uses.
- CmuxNextFeed/Views/FeedView.swift: onReportsReply is a var optional (no
  explicit nil, swiftlint) so the memberwise init takes it; a let with a
  default is not an init parameter (9222c97, #24616).
- CmuxNextAgentPane/AcpmuxMailboxClient.swift: public import Foundation (a
  public Date in its API).
- CmuxNextApp/Feed/FeedPageService.swift: the reply closure captures
  [services] explicitly (Swift 6). Its Process.run() on the main thread is
  unchanged (cmux-4f's PL-main owns it).
Errors found together with session cmux-4f's PL-main (origin/pl-main-testfix4
085eaa6), which dropped its push for this one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a16ae4-6466-71c0-b22c-5513fa7573e9&host=huge-blue
lawrencecchen added a commit that referenced this pull request Oct 24, 2026
…sitoryTests imports and typed sequences, SidebarGroupLineLayoutTests var)

feat-cmux-next's CmuxNextAppTests did not compile (fleet compile-tests steps
bbf3c4c87fb08a4528741f48 and 90534172dbdd07c288701002 on aws-m4pro-2):
- MarkdownCommentRepositoryTests (#24610) names JSONValue, SettingWriter and
  RecoveryDraftAcceptance without importing CmuxNextSettings and CmuxNextDesign,
  and its sequence check [Int] == [1, 2, 3] was an ambiguous use of == (the
  literal also fits IndexSet and IndexPath); the sequences are typed [Int].
- SidebarGroupLineLayoutTests (#24635) sets child.parent on a let SidebarGroup
  (a struct).
lawrencecchen added a commit that referenced this pull request Oct 24, 2026
Test code:
- AAGroupLineGalleryTests, SidebarStatusCleanupGalleryTests: ThemeStore.shared
  is gone since B3 (73c3d0d); they apply the theme through
  ThemeScope.app.store like the other galleries.
- SidebarGroupLineLayoutTests: SidebarGroup is a struct; the child the test
  re-parents is a var.
- MarkdownCommentRepositoryTests: its FilePageHosting stub uses types from
  CmuxNextSettings and CmuxNextDesign, which it never imported (b9c80fa,
  #24610).
Product, minimal build fixes, no behavior change:
- CmuxNextFeed/Views/FeedView.swift: onReportsReply optionals without an
  explicit nil (swiftlint), so the memberwise init still takes them.
- CmuxNextApp/Feed/FeedPageService.swift: the reply closure captures [services]
  explicitly (Swift 6). Its Process.run() on main is unchanged (cmux-4f's
  PL-main owns it).
The import fixes for SidebarLocalLanes, SidebarBridge and AcpmuxMailboxClient
and the acpmux titles.rs fix (6999224) are already on the tip. Errors found
together with session cmux-4f's PL-main (085eaa6), which dropped its push.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 24, 2026
Test code:
- AAGroupLineGalleryTests, SidebarStatusCleanupGalleryTests: ThemeStore.shared
  is gone since B3 (73c3d0d); they apply the theme through
  ThemeScope.app.store like the other galleries.
- SidebarGroupLineLayoutTests: SidebarGroup is a struct; the child the test
  re-parents is a var.
- MarkdownCommentRepositoryTests: the sequence assertion types its literal
  ([Int]: an untyped array literal is ambiguous for == inside #expect), and its
  FilePageHosting stub uses types from
  CmuxNextSettings and CmuxNextDesign, which it never imported (b9c80fa,
  #24610).
Product, minimal build fixes, no behavior change:
- CmuxNextFeed/Views/FeedView.swift: onReportsReply optionals without an
  explicit nil (swiftlint), so the memberwise init still takes them.
- CmuxNextApp/Feed/FeedPageService.swift: the reply closure captures [services]
  explicitly (Swift 6). Its Process.run() on main is unchanged (cmux-4f's
  PL-main owns it).
The import fixes for SidebarLocalLanes, SidebarBridge and AcpmuxMailboxClient
and the acpmux titles.rs fix (6999224) are already on the tip. Errors found
together with session cmux-4f's PL-main (085eaa6), which dropped its push.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 24, 2026
…hared instance; comment repository test imports; a nested group test's child)

73c3d0d (B3) removed ThemeStore.shared; two sidebar gallery tests still
applied their theme through it. MarkdownCommentRepositoryTests (b9c80fa,
#24610) names JSONValue, SettingWriter and RecoveryDraftAcceptance without
importing CmuxNextSettings and CmuxNextDesignTokens, and its awaited array
comparison was ambiguous. SidebarGroupLineLayoutTests (#24635) sets the parent
of a let group. The test target did not compile on feat-cmux-next (cmux-ci
steps 1bb712123db802d37528912d, f012101c57927662812e05a8).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
azooz2003-bit added a commit that referenced this pull request Oct 24, 2026
…Settings and CmuxNextDesign

#24610 added the test with a FilePageHosting fake that names JSONValue,
SettingWriter (CmuxNextSettings) and RecoveryDraftAcceptance
(CmuxNextDesignTokens, re-exported by CmuxNextDesign) without importing
them, so CmuxNextAppTests does not compile. Import them the way
EditorRevealConfigTests does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 24, 2026
…hared instance; comment repository test imports; a nested group test's child)

73c3d0d (B3) removed ThemeStore.shared; two sidebar gallery tests still
applied their theme through it. MarkdownCommentRepositoryTests (b9c80fa,
#24610) names JSONValue, SettingWriter and RecoveryDraftAcceptance without
importing CmuxNextSettings and CmuxNextDesignTokens, and its awaited array
comparison was ambiguous. SidebarGroupLineLayoutTests (#24635) sets the parent
of a let group. The test target did not compile on feat-cmux-next (cmux-ci
steps 1bb712123db802d37528912d, f012101c57927662812e05a8).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 24, 2026
…sitoryTests imports and typed sequences, SidebarGroupLineLayoutTests var)

feat-cmux-next's CmuxNextAppTests did not compile (fleet compile-tests steps
bbf3c4c87fb08a4528741f48 and 90534172dbdd07c288701002 on aws-m4pro-2):
- MarkdownCommentRepositoryTests (#24610) names JSONValue, SettingWriter and
  RecoveryDraftAcceptance without importing CmuxNextSettings and CmuxNextDesign,
  and its sequence check [Int] == [1, 2, 3] was an ambiguous use of == (the
  literal also fits IndexSet and IndexPath); the sequences are typed [Int].
- SidebarGroupLineLayoutTests (#24635) sets child.parent on a let SidebarGroup
  (a struct).
lawrencecchen added a commit that referenced this pull request Oct 24, 2026
…sitoryTests imports and typed sequences, SidebarGroupLineLayoutTests var)

feat-cmux-next's CmuxNextAppTests did not compile (fleet compile-tests steps
bbf3c4c87fb08a4528741f48 and 90534172dbdd07c288701002 on aws-m4pro-2):
- MarkdownCommentRepositoryTests (#24610) names JSONValue, SettingWriter and
  RecoveryDraftAcceptance without importing CmuxNextSettings and CmuxNextDesign,
  and its sequence check [Int] == [1, 2, 3] was an ambiguous use of == (the
  literal also fits IndexSet and IndexPath); the sequences are typed [Int].
- SidebarGroupLineLayoutTests (#24635) sets child.parent on a let SidebarGroup
  (a struct).
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 17fa8720 Deployed Oct 23, 2026 by teamleaderleo via namespace autofix #2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant