Skip to content

Agent pane: align markdown table actions - #24579

Merged
teamleaderleo merged 8 commits into
feat-cmux-nextfrom
codex/table-action-alignment
Oct 30, 2026
Merged

teamleaderleo merged 8 commits into
feat-cmux-nextfrom
codex/table-action-alignment

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Align the Markdown table Open and Copy actions at the table's top-right edge.
  • Give the pair the shared 24px control height, 14px shared row icon size, centered glyphs, and shared action gap.
  • Keep the three TableBlock gallery variants and cover both glyph sizes in the table action test.

Leo: "You can pass this off to a codex lane as well, like the sort of table and copy the things. These aren't lined up properly. We can just fix this pretty easily. Just line it up better."

Changelog

  • Fixed Markdown table actions so the expand and copy glyphs share a centered line and consistent size.

Testing

  • Review P2 at a9af0e0 (the pair at top: 0; right: 0 covered the last header's text and caught its clicks) is fixed: the pair sits outside the cells at the table's top-right corner (left: 100%), and .cv-table-block reserves its width.
  • bun test webviews/test/agent-pane-table-actions.test.ts fails with the fix reverted (the pair's left edge 326 inside a table edge of 377.9; run 40980227292) and passes at 74f191d with bun run check and the table copy test, 13/13 (run 40980415323).
  • Code cards reviewed: their existing Open/Copy/Wrap actions already share equal boxes and glyph sizing.

Gallery

Gallery: agent-pane.table-block

Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Aligns the Markdown table Open and Copy controls in the agent pane so they form a centered 24px-tall pair at the table's top-right corner instead of two unevenly sized buttons beside the header row. Both buttons now use the shared compact control height, the rowIconSize(12) glyph size, and the --cv-action-gap spacing also used by code-block actions. The pair sits outside the cells, in space the block reserves at the column's edge, so it never covers a header's text or catches a click meant for a cell. A gallery-render test verifies the pair's geometry and non-overlap with cells, and the table copy test now renders through the artifact context and checks both glyph sizes.

Written for commit fa274fa. Summary will update on new commits.

View guided diff Turn on auto-fix

Leo: "These aren't lined up properly. We can just fix this pretty easily. Just line it up better."
Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a16a6a-202a-7f90-93d5-d731bd5faa0f&host=huge-blue
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review fa274fa: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24579 -f ref=codex/table-action-alignment -f platform=macos -f backend_mode=local

Gallery before/after for fa274fa: 3 states rendered, 6 images differ (picked by the Gallery: line in the PR body). Images are in the run's artifact, not on this public PR.

gh run download 40985761445 -R manaflow-ai/cmux -n gallery-advisory-24579-fa274faa6a728ce51398290640838e5446707acb (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.table-block/rest Apple System Colors changed 0.036% pr-body
agent-pane.table-block/rest Apple System Colors Light changed 0.0353% pr-body
agent-pane.table-block/hover Apple System Colors Light changed 0.0657% pr-body
agent-pane.table-block/hover Apple System Colors changed 0.0648% pr-body
agent-pane.table-block/first-block Apple System Colors Light changed 0.0858% pr-body
agent-pane.table-block/first-block Apple System Colors changed 0.0849% pr-body

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: green on the base cec0a36; do not merge until green; see lane-rules

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 23, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-47i63 created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Orphaned: no activity for 54 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged feat-cmux-next in at a9af0e0. A later pass queues it for the merge hub if it is reviewed, small and red only on base reds.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra xhigh, next-review): BLOCK at a9af0e0

  • [P2] conversation.css:954: top: 0; right: 0 places the 52×24px action pair over table content without reserving space. Headers have only 11px top padding and no right padding, so the buttons overlap the last header’s text and intercept clicks intended for links or text selection. Headerless tables similarly expose their first data row. Reserve space for the controls or position them outside the cells.

@teamleaderleo

teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

teamleaderleo and others added 4 commits October 29, 2026 17:28
Regression test for the review P2 at a9af0e0: the top-right action pair
covered the last header's text and caught its clicks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-a4efd6c1314eb5a4fc3e
The top-right pair sat over the last header's text and caught its clicks
(review P2 at a9af0e0). It now sits just right of the table's top edge, in
space the block reserves at the column's edge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-a4efd6c1314eb5a4fc3e
@cursor

cursor Bot commented Oct 30, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, review-router, for drain-transcript): SHIP at 74f191d

No findings.

Static review only.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent October 30, 2026 01:25 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent October 30, 2026 01:30 Inactive
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol high, review-router, for drain-transcript): SHIP at fa274fa

No findings.

Static review only.

@teamleaderleo
teamleaderleo merged commit 43c8555 into feat-cmux-next Oct 30, 2026
211 of 224 checks passed
@teamleaderleo
teamleaderleo deleted the codex/table-action-alignment branch October 30, 2026 04:13
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

1 inactive deployment
ci-routing-agent — fa274faa Deployed Oct 30, 2026 by cmux-bot[bot] via wait for same-key tree publisher #79478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant