Repository navigation
Agent pane: align markdown table actions - #24579
Conversation
Leo: "These aren't lined up properly. We can just fix this pretty easily. Just line it up better." Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a16a6a-202a-7f90-93d5-d731bd5faa0f&host=huge-blue
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: green on the base cec0a36; do not merge until green; see lane-rules |
|
Found 1 test failure on Blacksmith runners: Failure
|
|
Bead |
|
Orphaned: no activity for 54 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged |
|
Review (codex gpt-6-astra xhigh, next-review): BLOCK at a9af0e0
|
|
Owned by an agent session · session |
…-action-alignment
Regression test for the review P2 at a9af0e0: the top-right action pair covered the last header's text and caught its clicks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a4efd6c1314eb5a4fc3e
The top-right pair sat over the last header's text and caught its clicks (review P2 at a9af0e0). It now sits just right of the table's top edge, in space the block reserves at the column's edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a4efd6c1314eb5a4fc3e
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a4efd6c1314eb5a4fc3e
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (codex gpt-6-astra high, review-router, for drain-transcript): SHIP at 74f191d No findings. Static review only. |
|
Review (codex gpt-6.1-sol high, review-router, for drain-transcript): SHIP at fa274fa No findings. Static review only. |
|
Shipped in:
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Leo: "You can pass this off to a codex lane as well, like the sort of table and copy the things. These aren't lined up properly. We can just fix this pretty easily. Just line it up better."
Changelog
Testing
top: 0; right: 0covered the last header's text and caught its clicks) is fixed: the pair sits outside the cells at the table's top-right corner (left: 100%), and.cv-table-blockreserves its width.bun test webviews/test/agent-pane-table-actions.test.tsfails with the fix reverted (the pair's left edge 326 inside a table edge of 377.9; run 40980227292) and passes at 74f191d withbun run checkand the table copy test, 13/13 (run 40980415323).Gallery
agent-pane.table-block:rest,hover, andfirst-blockvariants. Before/after renders are in the gallery advisory run's artifact (no renders on the public PR, ci: stop publishing internal gallery details to PRs #21400).Gallery: agent-pane.table-block
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Aligns the Markdown table Open and Copy controls in the agent pane so they form a centered 24px-tall pair at the table's top-right corner instead of two unevenly sized buttons beside the header row. Both buttons now use the shared compact control height, the
rowIconSize(12)glyph size, and the--cv-action-gapspacing also used by code-block actions. The pair sits outside the cells, in space the block reserves at the column's edge, so it never covers a header's text or catches a click meant for a cell. A gallery-render test verifies the pair's geometry and non-overlap with cells, and the table copy test now renders through the artifact context and checks both glyph sizes.Written for commit fa274fa. Summary will update on new commits.