Repository navigation
ci: stop publishing internal gallery details to PRs - #21400
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Bead |
teamleaderleo
added a commit
that referenced
this pull request
Oct 19, 2026
…6 it touches touched.ts ranks touched entries (own source, a gallery that names the changed component, importers by hops, same folder, host stylesheet, broad change); gallery_select.py keeps that order for the 16-state cap, honours a 'Gallery: id, id/variant' line in the PR body, and writes gallery-review.json plus the team feed's visual-manifest.json into the artifact. A trusted comment job (base-branch scripts) keeps a text 'gallery' section in the PR status comment with the states and the exact download command, marked stale when the head moves. Images stay in the artifact (#21400). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
that referenced
this pull request
Oct 19, 2026
…6 it touches touched.ts ranks touched entries (own source, a gallery that names the changed component, importers by hops, same folder, host stylesheet, broad change); gallery_select.py keeps that order for the 16-state cap, honours a 'Gallery: id, id/variant' line in the PR body, and writes gallery-review.json plus the team feed's visual-manifest.json into the artifact. A trusted comment job (base-branch scripts) keeps a text 'gallery' section in the PR status comment with the states and the exact download command, marked stale when the head moves. Images stay in the artifact (#21400). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
that referenced
this pull request
Oct 21, 2026
![cmux-autofix[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…readable receipt (#22188) * test(gallery): rank touched entries by relevance to the change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(gallery advisory): selection, receipt, status section and workflow wiring Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci(gallery advisory): render the states a PR changes, not the first 16 it touches touched.ts ranks touched entries (own source, a gallery that names the changed component, importers by hops, same folder, host stylesheet, broad change); gallery_select.py keeps that order for the 16-state cap, honours a 'Gallery: id, id/variant' line in the PR body, and writes gallery-review.json plus the team feed's visual-manifest.json into the artifact. A trusted comment job (base-branch scripts) keeps a text 'gallery' section in the PR status comment with the states and the exact download command, marked stale when the head moves. Images stay in the artifact (#21400). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 65dd80b - vp fmt webviews/scripts/gallery/touched.ts Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39333877664 * ci(gallery advisory): review fixes: no comment from a cancelled or outrun run, a Gallery line naming nothing falls back, new and removed states first, previews.json - comment job runs on !cancelled() and skips when the PR head moved, so a cancelled run never overwrites the newer run's stale mark - a 'Gallery:' line whose ids match no state (prose) falls back to the ranking; ignored ids are recorded in selection.json - within an entry, the states the PR adds or removes come first - non-finite numbers in the artifact cannot crash the section - visual-manifest source is linux-fallback (headless Chromium, runner fonts); previews.json is HQ's cmux.pr-previews.v1 for tools/previews Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci(gallery advisory): no entry takes more than half the cap while another waits; finer diff % On #21672's real file list the summary card's own entry (agent-pane.subagents, 16 variants) filled all 16 states; now 8 of it, then the entries that import SummaryCard.tsx (chat-width, docked-chat). Diff percent keeps 4 decimals so a 0.019% change does not read as 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(gallery advisory): a failed play check does not end the receipt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci(gallery advisory): a failed play check does not end the receipt On this PR's own run (39364160532) the base render of 16 states wrote every image and results.json, then exited 1 because six base states' play scripts no longer find their element; set -e ended the capture before the head render, so no receipt. The runner's status is now a warning; a missing results.json still fails the stage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci(gallery advisory): mark the section stale on any head-moving event Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci(gallery advisory): mark stale on the same events as capture A body edit that mentions Gallery: shares the concurrency group and cancelled the synchronize run on #22188, so its mark-stale never ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci(gallery advisory): fail the run when the capture renders zero real frames The capture job was continue-on-error at job level and the capture step too, so a receipt with no images (bun or browser failure, every state unready, or flat placeholder frames) still went green. scripts/gallery-matrix/frames.ts counts frames that are ready, on disk and not one flat color; a run that touched gallery states and has none fails. No touched state still passes. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=e8f63fd9-94e8-4878-bcd4-704659aba1f2&host=cosmic-gray * ci(gallery advisory): the head's frames decide the zero-frame check Base frames alone no longer pass a run whose head rendered nothing; only a PR that removes every sampled state is judged on its base. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=e8f63fd9-94e8-4878-bcd4-704659aba1f2&host=cosmic-gray * ci-guards: the gallery ranking guard runs after an earlier red guard Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15db7-20cd-7e10-8535-158031297e5c&host=huge-blue --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cmux-autofix[bot] <cmux-autofix[bot]@users.noreply.github.com>
This was referenced Oct 22, 2026
This was referenced Oct 29, 2026
Closed
teamleaderleo
added a commit
that referenced
this pull request
Oct 31, 2026
…29025) Leo, 2026-10-31: "we have teh gallery... we should have a faithful all-levle representation of the app through that stuff....." router-review and next-review now read the gallery-advisory artifact's stills of the exact head (teamleaderleo/leo-workspace#1859), so a PR needs no hand-made screenshots of the states the section lists. Images stay off the public PR (#21400). Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the per-PR
gallery PR diffworkflow that published internal gallery details to pull requests.The gallery matrix and internal feed remain available for explicitly requested review runs. This removes the automated path that uploaded thumbnails to
pr-mediaand created or updated<!-- cmux-gallery-pr -->comments.Validation
gallery PR diffworkflow immediately..github/workflows/gallery-pr.yml.Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Removes the automatic per-PR gallery diff workflow so internal gallery details are no longer published to pull requests.
.github/workflows/gallery-pr.yml; PRs will no longer render touched gallery entries, upload thumbnails topr-media, or create/update<!-- cmux-gallery-pr -->comments.Written for commit 5fa11dd. Summary will update on new commits.