Skip to content

Agent chat tests: a held edit's run checks its tool rows, not the mid-turn card (fixes #24443's red) #24505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Oct 23, 2026
Merged

Agent chat tests: a held edit's run checks its tool rows, not the mid-turn card (fixes #24443's red) #24505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions webviews/test/agent-pane-edit-awaiting-permission.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,15 @@ await requireBrowserLane("agent-pane-edit-awaiting-permission.test.ts", async ()
const page = await browser!.newPage({ viewport: { width: 900, height: 760 } });
await page.goto(url(FIRST_RAN));
await page.getByText("Tighten the retry comment").waitFor();
const card = page.locator(".acpmux-edited");
await card.waitFor();
expect(await card.textContent()).toContain("install.sh");
expect(await card.textContent()).not.toContain("install_test.sh");
// A run with a change still waiting for its permission keeps its tool rows, so the held call
// stays in sight (conversation/turns.ts `codexRuns`); the turn's edited-files card comes once
// it runs. The edit that ran reads as Edited with its change, the held one as its call.
const run = page.locator(".acpmux-activity", { hasText: "install_test.sh" });
await run.waitFor();
const labels = (await run.locator(".cv-tool__text").allTextContents()).map((label) => label.trim());
expect(labels).toContain("Edited install.sh+1-0");
expect(labels).toContain("Edit install_test.sh");
expect(labels.some((label) => label.startsWith("Edited install_test.sh"))).toBe(false);
await page.close();
});

Expand Down
Loading