Repository navigation
Agent chat tests: a held edit's run checks its tool rows, not the mid-turn card (fixes #24443's red) - #24505
Conversation
…bels, not the card #24443 keeps a run whose change still waits for its permission in tool rows (codexRuns sets foldRun false; isEditRow skips shaped runs), so the held call stays in sight. The FIRST_RAN check still looked for the mid-turn edited-files card and failed. It now checks the same thing on the rows: the edit that ran reads "Edited install.sh +1 -0", the held one reads "Edit install_test.sh". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16030-bf28-7072-b1f6-b83bbd0beacc&host=cosmic-gray
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; NEW: green on the base e80d1f6; do not merge until green; see lane-rules Tour of |
|
Owned by transcript-parity on cosmic-gray · session |
|
Bead |
|
Found 21 test failures on Blacksmith runners: Failures
...and 11 more test failures. View all on Blacksmith: run 39927365228, run 39927365111
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
|
|
|
Review (Codex xhigh via codex exec on cmux16, different model, correctness first): SHIP at 7ed03c0. The test change matches #24443's design (a run with a held edit stays in tool rows); the locator is scoped to the activity row, labels are deterministic, and the held edit is checked not to read as Edited. No other findings. |
|
Shipped in:
|
Fixes a red that #24443 added to
react-apps-check (3):test/agent-pane-edit-awaiting-permission.test.ts> "when the first edit runs, only its file reads as Edited". It passes at 755c1d6 (#24443's parent) and fails at 3360fb0 on huge-blue.Context: #24443 builds Leo's ask (Leo, 2026-10-22: "this is pretty good ui: … the collapsing i mean"). It keeps a run whose file change still waits for its permission in tool rows, so the held call stays in sight.
codexRunssetsfoldRun: falseon that run, andisEditRowskips shaped runs; #24443'stranscript-collapsed-tool-runstest "an edit waiting for its permission next to finished edits keeps its row" locks that in. The older browser check still looked for the mid-turn edited-files card.What the page draws for that fixture at feat-cmux-next: the edit that ran reads
Edited install.sh +1-0, and the held one readsEdit install_test.sh. So what the test protects still holds (only the edit that ran reads as Edited). This PR makes the test check it on the tool rows instead of the card. No product code changes. The card still comes once the edit runs (the "once allowed and run" test in the same file, which passes).Tests (huge-blue, Chromium, at c7e203d plus this change):
agent-pane-edit-awaiting-permission5 pass, 0 fail.No capture: test-only change.
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the red
agent-pane-edit-awaiting-permissiontest (the "first edit runs" check) that #24443 introduced. Since a held edit's run now keeps its tool rows instead of the edited-files card, the check asserts on the tool rows: the ran edit reads "Edited install.sh +1-0" and the held one reads "Edit install_test.sh". Test-only change; no product behavior changes.Written for commit 7ed03c0. Summary will update on new commits.