[teamleaderleo]

Native hover cards can't turn solid again. The new lint rules apply to every hover card body.

Leo-ask: ask-d547ac77f0

Stacked on #23801, which adds scripts/cmux-next/check-overlay-glass.py. This branch starts from #23801's head (433dfb0), so review only the top commit (2df1ca0). After #23801 squash-merges, a base merge reduces the diff to that commit.

Audit (native). Every native hover card already shows in the app's one hover card window, HoverCardPanel, which is plain themed glass (#23740; #23801 made the card fill opt-in). None needed a fix:

• tab and tab group cards (TabHoverCardView, GroupHoverCardView)
• link chip preview in Home (HomeLinkPreviewCardView)
• sidebar workspace and group cards (WorkspaceHoverCard)
• sidebar pull request card (SidebarPullRequestCard)
• What's New highlights (SidebarUpdateCardView+Popover)

The only fills inside them are Palette.hoverFill (thumbnail placeholder, row hover), clear, and a pill tint at 14%.

Change. check-overlay-glass.py now treats any file that hands a body to that window (HoverCardBody() or reports a card's lines (HoverCardTextReporting) as a hover card body, and flags:

• hover-own-window: the body builds its own window or material (NSPanel, NSPopover, NSWindow, NSVisualEffectView, OverlaySurfaceView, makeOverlayPanel).
• hover-body-fill: a backgroundColor, fillColor or .background(...) that isn't Palette.hoverFill, clear, nil, or a color under 0.6 alpha. Each branch of a ternary is checked.

The panel and its definitions are exempt (HoverCardPanel.swift, HoverCardSource.swift, HoverCardRow.swift). The glass-opaque-allow: escape and the ALLOWED table work as before. check-overlay-glass.test.sh adds fixtures that should fail (popover, own glass, solid fill, solid ternary branch) and ones that should pass (hover fill, clear, 14% pill, escaped dot, the same fill outside a body).

The web hover cards are covered by #23997.

Verification (huge-blue):

• python3 -I scripts/cmux-next/check-overlay-glass.py . → ok.
• bash scripts/cmux-next/tests/check-overlay-glass.test.sh → ok.
• Mutation check: adding layer?.backgroundColor = Palette.background.cgColor to TabHoverCardView.swift gives [hover-body-fill] at that line. Reverted afterwards.

This commit changes no Swift; the only Swift in the diff comes from #23801.

No capture: lint only, nothing on screen changes.

Agent session: cosmic-gray

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Adds hover card body rules to check-overlay-glass.py so native hover cards can't turn solid again. With #23801 merged into base, this branch carries only the lint and its tests. Hover card bodies must draw only on the app's one glass hover card window (HoverCardPanel).

• hover-own-window flags a body that builds its own window or material (NSPanel, NSPopover, NSWindow, NSVisualEffectView, OverlaySurfaceView, makeOverlayPanel).
• hover-body-fill flags a backgroundColor / fillColor / .background(...) that isn't Palette.hoverFill, clear, nil, or under 0.6 alpha; each ternary branch is checked.
• Existing glass-opaque-allow: comments and the ALLOWED table still apply, and stale allowances fail.
• check-overlay-glass.test.sh adds failing and passing fixtures for each rule form.

^{Written for commit 73583d3. Summary will update on new commits.}

[teamleaderleo]

Owned by glass-regressions on cosmic-gray · session

[blacksmith-sh]

Found 11 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmp0gf2auq1/summary-missing.json (live):/summary-missing.json (live):	View Logs
/tmp/tmplet8_pmw/summary-fail.json (live):/summary-fail.json (live):	View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/ [new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows	View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs
convention violations found (ERROR lines above)./ convention violations found (ERROR lines above).	View Logs
nightly cmux-tui resolve/nightly cmux-tui resolve	View Logs
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo dules)/ test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo dules)	View Logs
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo dules) (job='web-bundles')/ test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo dules) (job='web-bundles')	View Logs

...and 1 more test failures. View all on Blacksmith

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 73583d3: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24022 -f ref=glass-regressions/glass-previews -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: red check: Checks job structure (+1 more) is not red on the base b5a78a8; do not merge until green; see lane-rules

[teamleaderleo]

Bead cx-y2xcb created for this PR by the cmux coordinator.

[teamleaderleo]

Review (subagent, correctness first): SHIP at 4836628

The new head is a base merge (feat-cmux-next at df74f47; #23801's content comes from base unchanged as 0b71d5e) plus the reviewed commit 2df1ca0, also unchanged: git diff feat-cmux-next 4836628f is exactly 2df1ca0's +/- lines in scripts/cmux-next/check-overlay-glass.py and scripts/cmux-next/tests/check-overlay-glass.test.sh, and nothing else. No Swift in the diff. check-overlay-glass.py passes on the merged tree, and so does check-overlay-glass.test.sh.

[teamleaderleo]

cmux-next guards / nightly-guards / workflow-guard-tests / release-notary is red on 12 of 18 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

[teamleaderleo]

Review (Codex xhigh via acpmux, correctness first): SHIP at 73583d3
BLOCKING: none
NON-BLOCKING: The hover checks are line-oriented regexes; multiline fill expressions and some multi-argument .background(...) forms are not covered by the new fixtures.
CHECKED: Diffed merge-base b5a78a8 to the exact head; only the lint and its shell fixture test changed. Ran the lint on the full extracted PR tree (ok), the fixture test (ok), bash -n, and a base-script/head-fixtures red-before check. Injecting Palette.background into the real TabHoverCardView was caught as [hover-body-fill]. Inspected the real HoverCardBody/HoverCardTextReporting callers, HoverCardPanel's cardFill: false glass construction and existing Reduce Transparency path, theme-derived fills, and the absence of hard-coded orange or new Swift per-frame/layout work. Verified CI and the prepush gate invoke both the lint and fixture test. No native Swift build/tests were run, per the explicit review restriction.

[github-actions]

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.3991367032401 (b9c3d5aabc)
• cmux NEXT nightly 1.0.0-nightly.3991575404801 (a62351daaa)

[github-actions]

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.3991503232101 (cd84bc62d1)