Repository navigation
cmux NEXT Home: a lone Chief in a narrow column takes no avatar column; the chat gets the width - #24006
Conversation
… no avatar-only column Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
…column; the chat gets the width The avatar-only list holding one conversation (and no note or requests) is hidden in HomeSidebarSplitView, with its divider, so the chat spans the split and compose stays at its top-left. A second conversation or a column wide enough for names brings the list back. Debug Settings > Home > "Avatar list for one conversation" (home.loneConversationRail, off) keeps the column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
|
Owned by chief-ui on cosmic-gray · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green Tour of The path-selected recorder failed for core-after, core-before; see the run artifact and failed manifests. Path-selected interactions
Core UI (before): FAILED — 16 ok, 3 failed, 1 unavailable
Failed steps: 5. Split right Screenshots (12)1. Launch
Failed steps: 5. Split right Screenshots (12)1. Launch
Screenshots (15)5. Dark 320: header row at rest, a row selected
Screenshots (15)5. Dark 320: header row at rest, a row selected Tours are data in |
|
Found 5 test failures on Blacksmith runners: Failures
|
… and divider Fold the lone conversation's list only when the window squeezes the person's own width to avatars; a width they dragged there keeps the divider to drag it back out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
|
Review (claude-reviewer-lone-rail): BLOCK at 7cddc95 Read-only review of Blocking
(At 00fcd29 there was a second blocker: Checked and OK
Non-blocking
|
|
Closed by mistake, now reopened. Leo's "leave it alone, design choice" was about the profile, not this lone-Chief avatar column. The rail fix is wanted: a narrow Home column whose list holds only the Chief should not keep a ~165 pt list column with one avatar in it. The review BLOCK above is fixed in 09a1455. |
ResizeInvariantTests.theHomeTranscriptKeepsItsMinimumThroughResizes used an empty list, which now folds away once it would show avatars only (a lone Chief takes no column). The test checks the list shrinking to its avatar minimum, so it gives the list two conversations, as HomeLoneChiefRailTests does for the list that keeps its avatar column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
|
Bead |
HomeTunables.swift conflicted: feat-cmux-next added home.chatHeader where this branch added home.loneConversationRail. Both are kept, and both are in HomeTunables.all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
Picks up 78c71ce (the agent pane's styles carry ui/wave.css): without it the cmux-next web bundles do not build, so no fleet suite or capture can run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…conversation fold HomeSidebarSplitDividerTests (from #23998) built the split around an empty list. On this branch an empty list folds away once the clamp would leave it avatars only, so the clamp test was really testing the fold. Its list now holds two conversations, as in ResizeInvariantTests. A new folded variant (one conversation, 400 pt) checks that the list folds and that no divider line stays at the old 320 pt place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
After the merge of #23998, layout() runs NSSplitView's layout a second time after place() so that the divider's layer follows a clamp. The lone- conversation fold returned before that second pass, so the hidden divider's layer could stay at the list's old edge. The fold now runs the same extra pass when it hides or shows the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
|
Review (claude-reviewer-24006): SHIP at c1f9a2f What was checked. Earlier passes: SHIP at 09a1455 (the full PR, including the fix for the
The full PR diff against cc027d8 was read ( The ee7f7f6 BLOCK is resolved.
Calling
The new fold test is sound.
No other test is affected. Every test that builds a
Non-blocking:
|
…ompile fix (evidence for #24006, not for merge)
Picks up #24219 (HomeChiefLinkInkTests compiles again), which unblocks the CmuxNext test build on this PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…red evidence only, not for merge)
…ividerTests (red evidence only, not for merge)
|
Review (claude-reviewer-24006, sonnet): SHIP at 29dcefb This is a different-model review (sonnet), read-only, from
Non-blocking:
|
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39788910738 at e70f2c3 failed: cmux-next fast tier. |
|
Shipped in:
|
|
Shipped in:
|




























































![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
In a narrow Home column (list below 180 pt, the avatar-only list from 33224e0), a list that holds only the Chief drew a ~120 pt column with one lone avatar in it: an empty band beside the chat. Now the avatar-only list takes no column while it holds one conversation and nothing else (no Cloud note, no Message Requests): it's hidden with its divider, the chat spans the split, and compose stays at the chat's top-left as it already does for any avatar-only list. A second conversation, or a column wide enough for the list with names, brings the list back at its width. Everything else in the narrow-list feature (header hiding, compose moving, the 53c99aa clamp) is unchanged.
Debug Settings > Home > "Avatar list for one conversation" (
home.loneConversationRail, off by default) keeps the avatar-only column for one conversation.How:
HomeSidebarView.holdsOneConversation(pinned + rows ≤ 1, no note, no requests; the New Message draft row doesn't count) and anonContentChangehook that re-lays out the split.HomeSidebarSplitView.layout()gets one line,if foldLoneConversation() { return }, before the existing placement; folding hides the list subview,shouldHideDividerAthides its divider,sidebarWidthreports 0 while folded, andplace/ the divider double-click do nothing while folded. The split follows the tunable through Observation, so toggling it applies without a resize.Regression test
cmux-ci run --class light --script scripts/ci/package-test-lane.sh --ref <sha> --arg=suite --arg=Packages/macOS/CmuxNext --arg=HomeLoneChiefRailTests --env CMUX_CI_XCODE_APP=/Applications/Xcode_26.6.appThe suite covers: one Chief in a 400 pt window (list folded, chat spans 400 pt, compose visible at the chat's top-left); three conversations keep the avatar list at 119 pt; one Chief in a 1000 pt window keeps the 320 pt list with names; fold and unfold as conversations come and go and the window widens and narrows; the Debug toggle keeps the column and turning it off folds the open page.
Observed / Not run
cmux-ci compile-check --ref 00fcd2953db --apppassed;scripts/cmux-next/prepush-gate.pyclean.Changelog
Fixed: A narrow Home column with only the Chief no longer shows an empty avatar column beside the chat.
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes a narrow Home column whose list holds only the Chief: the avatar-only list no longer draws a lone avatar in an empty band beside the chat. The list and its divider are hidden, the chat spans the split, and compose stays at the chat's top-left.
Behavior
home.loneConversationRail, off by default) keeps the avatar-only column for one conversation; turning it off folds the open page without a resize.Tests
HomeLoneChiefRailTestscovers folding and unfolding as conversations come and go and the window widens and narrows, plus the Debug toggle.HomeSidebarSplitDividerTestsandResizeInvariantTestsnow list two conversations, since a lone Chief folds away in the shrinking tests; a new folded variant checks that no divider line stays at the old 320 pt place.Written for commit 3603281. Summary will update on new commits.