Repository navigation
HomeChiefLinkInkTests: name NSView.display unambiguously (fix the base's test build) - #24219
Conversation
…e's test build) #24002 wrote #selector(NSView.display), which is ambiguous between display() and display(_:), so CmuxNextAppTests no longer built and every PR's fast tier was red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: |
|
Owned by chief-ui on cosmic-gray · session |
|
Found 12 test failures on Blacksmith runners: Failures
...and 2 more test failures. View all on Blacksmith: run 39729550499, run 39729550523
|
|
Review (claude-reviewer-24219, sonnet): SHIP at a88c965 Read-only review of the one-line change at HomeChiefLinkInkTests.swift:23. I did not build or run it.
The fix is minimal and test-only. It touches no app source, so there is no runtime risk. The only unverified part is that CI has not yet compiled it, so the CmuxNextAppTests build on this head is the final confirmation. |
|
Bead |
|
Review (claude-reviewer-24219, sonnet): SHIP at 42c6b04 Read-only re-check of the base merge. I did not build or run anything.
My earlier analysis stands: the cast selects |
|
Shipped in:
|
Picks up #24219 (HomeChiefLinkInkTests compiles again), which unblocks the CmuxNext test build on this PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes the base's red fast tier. #24002 (cc027d8) added
HomeChiefLinkInkTestswith#selector(NSView.display). AppKit has bothdisplay()anddisplay(_:), so the selector is ambiguous and CmuxNextAppTests no longer builds. Every PR'scmux-next fast tierhas been red since, for example jobs 119640111188, 119641860268 and 119642938745 at 4f51657.Change
One line:
#selector(NSView.display as (NSView) -> () -> Void). Only the test changes; no app code.Tests
cmux-ci run --class light --script scripts/ci/package-test-lane.sh --ref a88c965e4f52b14b92dfc4553e4333a01c6a808b --arg=suite --arg=Packages/macOS/CmuxNext --arg=HomeChiefLinkInkTestsbuilds CmuxNextAppTests and runs the test. The result goes in a comment.HomeChiefLinkInkTests.swift:23:116: error: ambiguous use of 'display'.Observed / Not run
Observed: the base's fast-tier errors. Fleet results are pending at the time of writing. Not run: nothing else; this is test-only.
Changelog
none
No capture: test-only change.
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the red
cmux-next fast tierby disambiguating#selector(NSView.display)inHomeChiefLinkInkTests. AppKit has bothdisplay()anddisplay(_:), so the bare selector is ambiguous andCmuxNextAppTestsno longer compiles — every PR's fast tier has been red since #24002.The fix casts the selector as
(NSView) -> () -> Void. Test-only change; no app code is modified.Written for commit 42c6b04. Summary will update on new commits.