Skip to content

Revert "cmux NEXT Home: plural step counts in every locale; the store keeps the thought's headline, not its text" - #23289

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
revert/pr-22707
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
revert/pr-22707

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Takes back #22707: it merged at 75a8be4 without no SHIP review receipt on the head; no risk tier label.

Opened by merge-audit (leo-workspace tools/merge_audit.py), which never merges it, and next-autoland never lands it: a person does. To keep #22707 instead, add the missing evidence for 75a8be4 on #22707 (an independent review's Review (subagent, correctness first): SHIP at <head> comment, a green compile, a risk tier; for a compile the router skipped, land-now from a maintainer); the next audit pass then closes this PR. Otherwise review and land it.

Changelog

none


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Reverts #22707, which changed the Home store to publish only a thought's headline for the running indicator and added plural step-count strings for every locale. This restores the prior behavior: the store keeps the full thought text, headline extraction happens in the UI layer, and the new plural translations are removed.

Written for commit a2b443d. Summary will update on new commits.

View guided diff Turn on auto-fix

… keeps the thought's headline, not its text (#22707)"

This reverts commit c4fc4e9.
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review a2b443d: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23289 -f ref=revert/pr-22707 -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on a2b443dfdc; ci-status is green without them.

CI passes on a2b443dfdc (run 39581087568 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: red check: Script tests (pin-cmux-tui, embed-cef, ensure-cef store) (+1 more) is not red on the base dfb5330; do not merge until green; see lane-rules

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-qsyf6 created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026

Copy link
Copy Markdown

Found 3 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp02kgpd_3/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmp19cwuqpv/summary-missing.json (live):/summary-missing.json (live): View Logs
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextHomeEngineTests')/
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextHomeEngineTests')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

codex-review: SHIP at a2b443d

  • Reviewed the current diff, focused tests, and affected call paths; no correctness bug found.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by browser-pip on cosmic-gray · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

original reviewed or superseded; see leo-workspace briefs/2026-10-20-gui-push/revert-triage.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant