Repository navigation
cmux NEXT Home: plural step counts in every locale; the store keeps the thought's headline, not its text - #22707
Conversation
…ought tokens wake the store only when the line changes Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=e8f63fd9-94e8-4878-bcd4-704659aba1f2&host=cosmic-gray
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by web and size checks: green |
… it is, not headlined a second time Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=e8f63fd9-94e8-4878-bcd4-704659aba1f2&host=cosmic-gray
|
|
This comment has been minimized.
This comment has been minimized.
|
Bead |
This comment has been minimized.
This comment has been minimized.
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
|
|
Owned by projects-3f on cosmic-gray · session |
check-l10n.sh requires each language to have all of English's plural categories; ja, km, ko, th, vi and zh had only other. Their one form repeats other, as the repo's other plural keys do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=cosmic-gray
|
Orphan sweep (owner session): the independent subagent review found one blocking issue. check-l10n.sh requires every language to have all of English's plural categories, and ja, km, ko, th, vi and zh-Hans/Hant had only Remaining reds, all also red on feat-cmux-next:
The fleet compile-check of the app at merge ref d695462 passed. |
scripts/localization-plurals.json keeps both base's home.turn.* keys (#22707) and this PR's importSuggestions.* keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=cosmic-gray
|
Shipped in:
|
|
Review (subagent, correctness first): SHIP at 75a8be4 This is a post-hoc independent review of the merged change (merge commit c4fc4e9). It was read-only and nothing was run. risk:low (strings catalog plus a moved helper). Nothing blocks. Notes:
The merge-audit revert of this PR is handled separately. See leo-workspace |
Summary
This is a follow-up to #22644, which merged before its review findings were fixed.
CmuxHome.xcstrings, and each is recorded inscripts/localization-plurals.json.HomeThoughtHeadline, moved into CmuxHomeCore), not the whole thought of up to 64 KiB. A streamed thought token now changesHomeStore.liveonly when the line a person sees changes. The headline rule itself is unchanged: last bold heading, else last sentence, at most 72 characters.Test
HomeTurnThoughtStoreTestsnow checks that the store holds the headline, not the raw text, and that a later heading replaces it after the thought's step ends.Observed / Not run
scripts/cmux-next/prepush-gate.pypasses.localization_catalog.py check --catalog …/CmuxHome.xcstringsreports no errors other thanneeds_reviewstates; every machine translation in this catalog carries that state.Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the review findings from #22644: the Chief's folded step counts now use plural forms in every locale, and the store keeps only a thought's headline instead of its whole text.
Plural forms
CmuxHome.xcstrings, recorded inscripts/localization-plurals.json.ja,km,ko,th,vi, andzhhad only theothercategory; their single form now repeatsother, satisfyingcheck-l10n.sh.Headline in the store
HomeThoughtHeadline, moved intoCmuxHomeCore) instead of the whole thought (up to 64 KiB), so a streamed token changesHomeStore.liveonly when the line a person sees changes.HomeTurnProgressTestsverifies the store holds the headline, not the raw text, and that a later heading replaces it.Written for commit 75a8be4. Summary will update on new commits.