[teamleaderleo]

Summary

Takes back #21897: it merged at 0f4fdca without no SHIP review receipt on the head; no risk tier label.

Opened by merge-audit (leo-workspace tools/merge_audit.py), which never merges it. To keep #21897 instead, add the missing evidence for 0f4fdca on #21897 (an independent review's Review (subagent, correctness first): SHIP at <head> comment, a green compile, a risk tier; for a compile the router skipped, land-now from a maintainer); the next audit pass then closes this PR. Otherwise review and land it.

Changelog

none

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Reverts #21897, which added the sessions.promptSuggestions setting so users could enable suggested follow-up tasks. This restores the previous behavior where the Debug Settings toggle agent.suggestedTasks is the only way to turn them on, removing the setting's schema entry, localization strings, and related tests. The original PR merged without the required ship-review receipt and risk-tier label, so this revert brings feat-cmux-next back to a reviewed state.

^{Written for commit bdeb863. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review bdeb863: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23173 -f ref=revert/pr-21897 -f platform=macos -f backend_mode=local

Passes: CI passes on bdeb8630ff.

CI passes on bdeb8630ff (run 39699266008 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

[blacksmith-sh]

Found 2 test failures on Blacksmith runners:

Failures

Test	View Logs
nightly cmux-tui resolve/nightly cmux-tui resolve	View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl ights_validate)/ test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl ights_validate)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

Bead cx-3qr09 created for this PR by the cmux coordinator.

[teamleaderleo]

Owned by composer-scroll-2 on cosmic-gray · session

[teamleaderleo]

Keeping this revert open. An independent post-merge review of #21897 at 0f4fdca found a blocking defect.

The new setting does nothing. AgentPaneSuggestedTasks.swift:33 computes isOn = setting() || AgentPaneTunables.suggestedTasks.value, and AgentPaneHost.swift:123 applies the same OR for the daemon (ACPMUX_OFFER_TOOLS). #22089 merged earlier and changed that Debug tunable's default to true (AgentPaneTunables+SuggestedTasks.swift:11). So Settings shows "Suggest Follow-Up Tasks" as off while suggestions are on, and turning it off changes nothing.

AgentPaneSuggestedTasksSettingTests.swift:22-23 (isOn == debugOn) passes anyway, so the test hides it. The settings schema, docs/mdm and defaults exports also lack sessions.promptSuggestions; the base autofix owns those.

The reviewer suggests a forward fix rather than this revert: default sessions.promptSuggestions to true and let the setting alone decide, or make the tunable a force-on that defaults to false. Behaviour on base is already "on", so reverting would only remove a toggle that is already a no-op. Waiting on the coordinator's call.

[teamleaderleo]

codex-review: SHIP at 5fe53a5

• Reviewed the current diff, its focused tests, and the affected call paths; no correctness bug found.

[teamleaderleo]

Orphaned: no activity for 14 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged feat-cmux-next in at bdeb863. A later pass queues it for the merge hub if it is reviewed, small and red only on base reds.

[teamleaderleo]

Review (codex gpt-6.1-sol): BLOCK at bdeb863

Blocking: Packages/macOS/CmuxNext/Sources/CmuxNextSettings/SessionSettings.swift:31 and the removed schema descriptor leave the checked-in generated exports stale. schemas/settings/settings-schema.json:4845 still advertises sessions.promptSuggestions (also schemas/defaults/cmux-next.json:561, docs/mdm/com.manaflow.cmux.plist:854, docs/mdm/com.manaflow.cmux.json:3087, docs/mdm/managed-preferences.md:72), and schemas/settings-export/settings-schema.sources.sha256:449 still hashes the pre-revert sources. On this head, SettingsSchemaExportTests.exportIsFresh and ManagedPreferencesManifestTests.checkedInSchemaMatchesTheCatalog will compare the current Swift schema, which no longer contains the key, against those old exports and fail; any schema or MDM consumer also continues to offer a setting the app ignores. Regenerate all settings exports and the source stamp before landing.

Non-blocking: None found.

Checked: the merge-base-to-head diff, whole-file references to the reverted setting, generated-export freshness test logic, commit history, and the unchanged final head; no builds or test suites were run.

[teamleaderleo]

Closing: fixed forward by #23284 (merged as 9fe0c23). The setting sessions.promptSuggestions (on by default) now decides on its own, and the Debug toggle agent.suggestedTasks (off by default) can only force suggestions on, so turning the setting off works and #21897 no longer needs reverting.