Skip to content

cmux NEXT: suggested tasks on by default - #22089

Merged
teamleaderleo merged 11 commits into
feat-cmux-nextfrom
next-chips-default-on
Oct 21, 2026
Merged

teamleaderleo merged 11 commits into
feat-cmux-nextfrom
next-chips-default-on

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Suggested-task chips are now on by default. An agent can suggest follow-up work (offer_session / suggest_tasks), and the chat shows it as a card with Start, Start all and Do it here. Started tasks become child chats beside this one, and their results come back here. Until now all of this sat behind the agent.suggestedTasks Debug toggle, which defaulted off, so nobody saw it.

The Debug toggle stays (DEV and NIGHTLY only). Turning it off removes the chips, and the daemon starts without ACPMUX_OFFER_TOOLS. Release and RC always use the default, so there the chips are always on and every local session gets the cmux-sessions MCP server. Leo's call on 2026-10-19: the chips shouldn't be off by default.

Verification

  • AcpmuxOfferToolsTests: byDefaultTheDaemonGetsTheOfferTools (new default) and turnedOffTheDaemonGetsNoOfferTools. The test commit (cmux NEXT: test that suggested tasks are on by default) is red: on base, an unset toggle launches the daemon without the offer tools. The flip makes it green. Not yet observed: cmux-next swift test is skipped on this PR (no full-ci), so the red-then-green is from reading the test, not a run; no local Swift build.

  • The chip UI itself is unchanged and covered by webviews/test/agent-pane-suggested-tasks.test.ts.

  • Risk: normal (risk_tier.py classify: Swift tunable, defaults snapshot, webview comments; the test and ci-target-graph.json are low). No migration: an unset toggle now reads on, and a stored true keeps its value. A stored opt-out was never written under the old default (the store drops values equal to the default), so earlier opt-outs come back on.

  • The ci-target-graph.json and schemas/defaults changes are PR-autofix regeneration, not part of this change.

Changelog

  • Changed: cmux NEXT shows agents' suggested tasks by default.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Suggested-task chips now show by default. The agent.suggestedTasks Debug toggle previously defaulted off, so agents' follow-up suggestions never appeared; it now defaults on. Turning it off still removes the chips and starts the daemon without ACPMUX_OFFER_TOOLS.

  • The daemon-offer test now covers both the default-on and turned-off cases.
  • Updates the CI target graph, removes stale default keys for browser focus-search and iPhone connections, and syncs the toggle's default across webview comments.

Written for commit 834fa8f. Summary will update on new commits.

View guided diff Turn on auto-fix

@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable new issues were found.

Summary

Suggested tasks now default to on. The Debug toggle remains available.

  • Agent chats show suggested tasks by default.
  • CI now maps the Agent Permissions module and its tests.
  • CI now maps Chromium Runtime for app builds and tests.
  • The defaults snapshot no longer lists two unsupported settings.

Reviews (10) · Last reviewed commit: "chore(next): PR autofix at a8d8f1a53dcd" · Reviewed by Greptile

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-7dh6q created for this PR by the cmux coordinator.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 834fa8f: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22089 -f ref=next-chips-default-on -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on 834fa8f808 (run 39534157592 attempt 1): 4 code, 1 unknown.
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped.

Job Verdict Why
web / react-apps-check (3) code a web test failed
web / react-apps-check (4) code a web test failed
web / react-apps-check (2) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs composer-mention.test.ts @ then letters lists the chat's matching files and Return writes the path: failed (job)
  • seen on other PRs composer-mention.test.ts after picking a path markdown escapes, typing on leaves the picker closed: failed (job)
  • seen on other PRs composer-mention.test.ts @proje lists other chats, then folders, then the chat folder's files: failed (job)
  • seen on other PRs composer-mention.test.ts a chat named for a long prompt does not take @app from the file: failed (job)
  • seen on other PRs composer-mention.test.ts a bare @ lists the most recent other chats: failed (job)
  • seen on other PRs composer-mention.test.ts an @ inside a word opens nothing and asks the host for nothing: failed (job)
  • seen on other PRs composer-row-rhythm.test.ts at 760 px (light): one gap in a group, one between groups, Send at the edge: failed (job)
  • seen on other PRs composer-row-rhythm.test.ts at 760 px (dark): one gap in a group, one between groups, Send at the edge: failed (job)
  • seen on other PRs agent-pane-background-tasks.test.ts clicking a background task's end opens its terminal beside the chat: failed (job)
  • seen on other PRs agent-pane-wheel-pass-through.test.ts chromium > the wheel over a long draft stops at its ends and moves nothing else: failed (job)
  • ... 6 more in the job logs
Matched log lines
web / react-apps-check (3): (fail) @ then letters lists the chat's matching files and Return writes the path [1700.09ms]
web / react-apps-check (4): (fail) clicking a background task's end opens its terminal beside the chat [945.68ms]
web / react-apps-check (2): (fail) chromium > the wheel over a long draft stops at its ends and moves nothing else [4124.06ms]
web / react-apps-check (1): (fail) ↑ and ↓ in an empty prompt step through the chat's earlier prompts [1784.18ms]

Not re-run automatically: web / react-apps-check (3), web / react-apps-check (4), web / react-apps-check (2), web / react-apps-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; NEW: green on the base 1a8eefe; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 1a8eefe to compare; do not merge until green; see lane-rules
red: web / react-apps-check (1); no finished base run on 1a8eefe to compare; do not merge until green; see lane-rules
red: web / react-apps-check (2); no finished base run on 1a8eefe to compare; do not merge until green; see lane-rules
red: web / react-apps-check (3); no finished base run on 1a8eefe to compare; do not merge until green; see lane-rules
red: web / react-apps-check (4); no finished base run on 1a8eefe to compare; do not merge until green; see lane-rules

CI fast guards failed on ee15854800 (https://github.com/manaflow-ai/cmux/actions/runs/39402606841). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally.

Tour of 834fa8f808 (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output.

@blacksmith-sh

blacksmith-sh Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Found 14 test failures on Blacksmith runners:

Failures

Test View Logs
test/agent-pane-background-tasks.test.ts/agent-pane-background-tasks.test View Logs
test/agent-pane-background-tasks.test.ts/agent-pane-background-tasks.test View Logs
test/agent-pane-wheel-pass-through.test.ts/agent-pane-wheel-pass-through.test View Logs
test/agent-pane-wheel-pass-through.test.ts/agent-pane-wheel-pass-through.test View Logs
test/composer-history.test.ts/composer-history.test View Logs
test/composer-history.test.ts/composer-history.test View Logs
test/composer-location-strip.test.ts/composer-location-strip.test View Logs
test/composer-location-strip.test.ts/composer-location-strip.test View Logs
test/composer-mention.test.ts/composer-mention.test View Logs
test/composer-mention.test.ts/composer-mention.test View Logs

...and 4 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

teamleaderleo and others added 2 commits October 19, 2026 19:15
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The agent.suggestedTasks Debug toggle now defaults on, so agents' offer and
suggest_tasks chips draw in every build; the toggle still turns them off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 20, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@cursor

cursor Bot commented Oct 20, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next guards / defaults-snapshot is red on 21 of 21 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

Review follow-up on #22089: three comments still said off by default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent, correctness first): SHIP at 48b0a3e

The subagent reviewed ee15854; 48b0a3e only fixes three comments that still said off by default. The flip reaches both paths: the daemon through AgentPaneHost → offersSessionTools, and the page through .suggestedTasks at load, handshake and every change. The Chief host starts no daemon. Nothing needs migrating: the store drops values equal to the default, so earlier opt-outs come back on, which is intended. Non-blocking points, now in the body: Release and RC have no off switch, and AcpmuxOfferToolsTests hasn't run on this PR (swift test is skipped without full-ci).

@teamleaderleo teamleaderleo added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Oct 20, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c03-03d0-7460-8bd4-cc70444781bd

…default-on

# Conflicts:
#	Packages/macOS/CmuxNext/ci-target-graph.json
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c03-03d0-7460-8bd4-cc70444781bd

@teamleaderleo
teamleaderleo merged commit 4c6e0ff into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the next-chips-default-on branch October 21, 2026 03:00
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

teamleaderleo added a commit that referenced this pull request Oct 21, 2026
…able already turns it on

AgentPaneSuggestedTasks.isOn is the setting OR the tunable, which defaults to
true since #22089, so the card would say Get while the feature is on and Remove
could not turn it off. The Agents category goes with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bdd-a3a7-70f3-960d-db7379df3d8d&host=cosmic-gray
teamleaderleo added a commit that referenced this pull request Oct 21, 2026
…cards (#23471)

* cmux NEXT App Store: Channels, Suggested Follow-Up Tasks and five sidebar launchers as Features cards

The Features tab lacked finished, default-off features that already have a key:
home.channelsEnabled (Channels), sessions.promptSuggestions (Suggested
Follow-Up Tasks, under a new Agents category) and the sidebar built-ins no card
offered (Search Chats, New Terminal, New Browser Tab, New Agent Chat,
Customize). The sidebar side now lists every sidebar item the catalog has, so a
new card needs no second list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bdd-a3a7-70f3-960d-db7379df3d8d&host=cosmic-gray

* Drop the Suggested Follow-Up Tasks card: the agent.suggestedTasks tunable already turns it on

AgentPaneSuggestedTasks.isOn is the setting OR the tunable, which defaults to
true since #22089, so the card would say Get while the feature is on and Remove
could not turn it off. The Agents category goes with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bdd-a3a7-70f3-960d-db7379df3d8d&host=cosmic-gray

* SidebarEditModeTests: Add Items lists the five new sidebar launchers too

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bdd-a3a7-70f3-960d-db7379df3d8d&host=cosmic-gray

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Oct 22, 2026
…ff (#23284)

* fix(cmux-next): let sessions.promptSuggestions turn suggested tasks off

#21897 added the setting but ORed it with the agent.suggestedTasks Debug
toggle, which #22089 had made default on, so turning the setting off did
nothing. The setting now decides and defaults on (today's behavior); the
Debug toggle defaults off and only forces suggestions on. The host's
default closure reads forNextDaemon alone, which already carries both.

The old test compared isOn to the Debug toggle's value, which hid the
bug; the new one turns the setting off and expects suggestions off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-5eec-7700-94d7-9a3a1f7d889a&host=cosmic-gray

* Say the setting decides suggested tasks in the webview comments

The comments still called the Debug toggle on by default; it is now a
force-on, and Settings > Suggest Follow-Up Tasks decides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-5eec-7700-94d7-9a3a1f7d889a&host=cosmic-gray

* chore(next): PR autofix: regenerate the settings exports

From the cmux-next PR autofix artifact (run 39623858039): the exports now
list sessions.promptSuggestions with default true, plus base's stale
agents.subsessions.answerQuestions row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-5eec-7700-94d7-9a3a1f7d889a&host=cosmic-gray

* docs(next): suggested tasks comments name the setting, not only the Debug toggle

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-5eec-7700-94d7-9a3a1f7d889a&host=Air-Blue

* test(next): the suggested tasks test names the setting, not only the Debug toggle

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-5eec-7700-94d7-9a3a1f7d889a&host=Air-Blue

* chore(next): PR autofix: regenerate the settings exports

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-5eec-7700-94d7-9a3a1f7d889a&host=Air-Blue

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant