Repository navigation
cmux-next sidebar: public import Observation in ChiefSidebar (base compile red since #22759) - #22898
lawrencecchen wants to merge 1 commit into
Conversation
…mpile red since #22759) ChiefSidebar is a public @observable class; the macro's public conformance needs Observation imported publicly under InternalImportsByDefault. Every CmuxNext package build fails: 'cannot use protocol Observable in a public or @usableFromInline conformance; Observation was not imported publicly' (cmux-ci step dcf9d85d09a1fe772bf22fdf).
|
Bead |
|
Fleet: cmux-ci step 82f063ddf835c64e09afcca2 on aws-m4pro-5 (Xcode 26.6), ref 554773e = #22887 + #22898 + #22853 on feat-cmux-next. CmuxNext built with tests (this proves #22898 clears the ChiefSidebar red and #22853 clears the SidebarPriorityRowView red). BrowserCookieImportSecurityTests and CookieImportCommandTests passed. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
Correctness review (subagent, correctness first): PASS
|
Base red, priority zero.
ChiefSidebaris a public@Observableclass. Under InternalImportsByDefault the macro's publicObservableconformance needspublic import Observation. Every CmuxNext package build of feat-cmux-next fails withcannot use protocol 'Observable' in a public or '@usableFromInline' conformance; 'Observation' was not imported publicly(cmux-ci step dcf9d85d09a1fe772bf22fdf, aws-m4pro-3). No open PR fixes it (#22852 touches the file's imports but keepsimport Observation).Changelog
none
Observed / Not run
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the compile error on the
feat-cmux-nextbase by making theObservationimport public inChiefSidebar.swift.Since
ChiefSidebaris a public@Observableclass, the macro's publicObservableconformance requirespublic import ObservationunderInternalImportsByDefault. Without this change, every CmuxNext package build fails with "cannot use protocol 'Observable' in a public or '@usableFromInline' conformance; 'Observation' was not imported publicly."Written for commit e50d6f3. Summary will update on new commits.