Skip to content

cmux-next sidebar: public import Observation in ChiefSidebar (base compile red since #22759) - #22898

Closed
lawrencecchen wants to merge 1 commit into
feat-cmux-nextfrom
nx-chiefsidebar-public-observation
Closed

lawrencecchen wants to merge 1 commit into
feat-cmux-nextfrom
nx-chiefsidebar-public-observation

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Base red, priority zero. ChiefSidebar is a public @Observable class. Under InternalImportsByDefault the macro's public Observable conformance needs public import Observation. Every CmuxNext package build of feat-cmux-next fails with cannot use protocol 'Observable' in a public or '@usableFromInline' conformance; 'Observation' was not imported publicly (cmux-ci step dcf9d85d09a1fe772bf22fdf, aws-m4pro-3). No open PR fixes it (#22852 touches the file's imports but keeps import Observation).

Changelog

none

Observed / Not run

  • Observed: the compile error in the step log at the base.
  • Not run: a separate compile of this one-word change.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the compile error on the feat-cmux-next base by making the Observation import public in ChiefSidebar.swift.

Since ChiefSidebar is a public @Observable class, the macro's public Observable conformance requires public import Observation under InternalImportsByDefault. Without this change, every CmuxNext package build fails with "cannot use protocol 'Observable' in a public or '@usableFromInline' conformance; 'Observation' was not imported publicly."

Written for commit e50d6f3. Summary will update on new commits.

View guided diff Turn on auto-fix

…mpile red since #22759)

ChiefSidebar is a public @observable class; the macro's public conformance needs
Observation imported publicly under InternalImportsByDefault. Every CmuxNext
package build fails: 'cannot use protocol Observable in a public or
@usableFromInline conformance; Observation was not imported publicly'
(cmux-ci step dcf9d85d09a1fe772bf22fdf).
@lawrencecchen lawrencecchen added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator

Bead cx-4x9mp created for this PR by the cmux coordinator.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Fleet: cmux-ci step 82f063ddf835c64e09afcca2 on aws-m4pro-5 (Xcode 26.6), ref 554773e = #22887 + #22898 + #22853 on feat-cmux-next. CmuxNext built with tests (this proves #22898 clears the ChiefSidebar red and #22853 clears the SidebarPriorityRowView red). BrowserCookieImportSecurityTests and CookieImportCommandTests passed.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Not verified: macOS jobs did not run: compile and app tests were skipped on e50d6f30c4; ci-status is green without them.

CI passes on e50d6f30c4 (run 39541581963 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Correctness review (subagent, correctness first): PASS

ChiefSidebar is a public @Observable class in an InternalImportsByDefault target, so the one-word change is the minimal fix. Client visibility does not widen: AgentPriorityMarks.swift already has public import Observation. No module declares a clashing Observable or Observation* name, and no other public @Observable class in CmuxNextAgentLanes has the same issue. The fleet build is in the comment above.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

The base already has this fix (#22905 landed the same one-word change as 89e9c65). Closing as a duplicate.

@lawrencecchen
lawrencecchen deleted the nx-chiefsidebar-public-observation branch October 21, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants