Repository navigation
cmux-next sidebar: Priority row's label no longer overrides NSView.tag (base compile red from #22778) - #22853
Conversation
… NSView.tag (base compile red)
SidebarPriorityRowView declared `private let tag: ChromeLabel`, which
overrides NSView's `tag: Int`; the module fails to compile ("overriding
property must be as accessible as its enclosing type", "property 'tag'
with type 'ChromeLabel' cannot override a property with type 'Int'"),
so feat-cmux-next does not build since #22778. Rename it placeLabel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: 01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
owner: 01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by web and size checks: green |
|
Found 1 test failure on Blacksmith runners: Failure
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.svg)
…eed (base compile red) AppActions.bind calls SidebarPriorityFeed.bind (#22778), a type of CmuxNextAgentLanes, without importing it: "cannot find 'SidebarPriorityFeed' in scope". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: 01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Bead |
The CmuxNextApp size cap refuses any source-line growth, and the import added one line. The Logger(...).fault(...) call becomes one line, so the fix adds no line to the app target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: 01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f
…w-reel Agent-Session: 01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f
Picks up the base fixes (#22877 inspector page, #22853 compile, #22856, #22876). settings.gallery.ts: kept both new covers entries (ChiefPetCard, FontPicker). ci-target-graph.json and the settings exports take the base side; PR autofix regenerates them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Shipped in:
|
|
Shipped in:
|
What changed
SidebarPriorityRowView(#22778) declaredprivate let tag: ChromeLabel, which overridesNSView.tag: Int.CmuxNextSidebardoesn't compile at feat-cmux-nextbfa73a4, so neither does the app:The label (a chat's project or machine) is renamed
placeLabel. With that fixed, the app target fails next:AppActions.swift:51: cannot find 'SidebarPriorityFeed' in scope. The type lives inCmuxNextAgentLanes, whichAppActions.swiftdidn't import, so the second commit adds the import. The CmuxNextApp size cap refuses any new source line, so the third commit joins the two-lineLogger(...).fault(...)call inAppActions.swiftinto one line. Nothing else changes.Changelog
none
Observed / Not run
cmux-ci compile-check --appfails atdc3bb42(a merge of base3a240e4) with the errors above, in job c8edb1f5.compile-check --appatd4b22cb(the rename alone) fails on the missing import (job 4d577874). At the head5fa7538it passes (job 52e968e4).5fa7538, CI'sCmuxNextApp size capfailed on the one-line growth. At991a42c,check-app-size.sh --base bfa73a4passes locally (no net new line), andprepush-gate.pyreports no new violations.compile-check --appat991a42c.Risk: low (a compile fix; it renames one private property).
Agent session: cosmic-gray
🤖 Generated with Claude Code