Repository navigation
cmux NEXT Settings: a Chief page with every Chief setting; the Chief popover links to it - #22848
Conversation
… Chat and Chief Pet; the Chief popover links to it (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c01-a495-7013-b37d-abe71de99881&host=cosmic-gray
…over's All Chief Settings… opens it The Chiefs list (name, picture, backend), Chief Chat and Chief Pet move from the bottom of Agents to their own Chief category, right after Agents. The name pill's popover stays the quick version and links to the page. HomeChiefHostLine moves to CmuxNextHomeEngine so CmuxNextApp does not grow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c01-a495-7013-b37d-abe71de99881&host=cosmic-gray
This comment has been minimized.
This comment has been minimized.
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; base red: the same failure on the base 3b1e3bb; does not block
Agents: |
|
Found 18 test failures on Blacksmith runners: Failures
...and 8 more test failures. View all on Blacksmith
|
…; the link test finds its button by accessibility id Also: the highlight gets its Open Settings action, and comments that said Settings > Agents > Chief… name the Chief page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c01-a495-7013-b37d-abe71de99881&host=cosmic-gray
|
Bead |
… joins Settings > Chief #21822 added a Chief Pet category for the pet card; its owner and this PR agreed on one Chief page. The card leads the Chief category after the Chiefs list, and the chief-pet category goes. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c01-a495-7013-b37d-abe71de99881&host=cosmic-gray Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
|
Owned by paired-approvals-b9 on cosmic-gray · session |
# Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextApp/Home/HomeHostView.swift
…39553280427) The PR autofix leaves its repairs as an artifact on pull_request runs; this is that patch, applied unchanged. Settings > Chief replaces the chief-pet category; the rest (notifications, trust, sidebar defaults) is base source the committed exports had not caught up with. Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39553280427 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
# Conflicts: # schemas/settings-export/settings-schema.sources.sha256
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
|
|
Shipped in:
|
Summary
Leo couldn't find Chief settings in the nightly. The Settings sidebar had no Chief entry, and the Chief's name-pill popover was the only place he looked. Its own words: "only having it as a popover is kind of crappy; there's a lot of settings you may or may not want for the chief".
Settings > Chief is a new category, right after Agents. It holds every Chief setting the app has:
These three used to sit at the bottom of Agents.
All Chief Settings… in the name-pill popover opens Settings > Chief and closes the popover. The popover stays the quick version.
The pet's own Chief Pet Settings… already opened Settings at the pet row, so it now lands on the Chief page.
The bottom-left profile menu already has Show/Hide Chief Pet in base (
profileMenu.chiefPet), so this PR doesn't change it.HomeChiefHostLinemoves from CmuxNextApp to CmuxNextHomeEngine, so CmuxNextApp's source lines stay level (+0 against the base).New strings: the category title "Chief" and "All Chief Settings…", in all 21 locales. Chief is kept untranslated as a product name.
The web page gets a crown icon for the category. The generated settings export (
settings-schema.json, itspage) is left for the PR autofix to regenerate.The cloud half of this item, where a cloud Chief's popover said "The server with this Chief is not connected." and showed empty pickers, is #22602. It is reviewed and lands separately.
Not in this PR: the brief also listed notices, voice, approvals and history import for the Chief page. None of them is a setting today, so there was nothing to move. Each would be a new setting with its own PR.
Coordination: #21822 (the Chief Pet card, from another lane) adds a separate Chief Pet category for the same two pet rows. I've asked its owner to draw that card inside this Chief category instead.
Changelog
Changed: Settings has a Chief page with every Chief setting, and the Chief's settings popover links to it.
Tests
Red commit
77d7bdf618, then the fix in91716854cd:ChiefSettingsPageTests(CmuxNextSettingsTests):ChiefBubbleStyleSettingTests.theSettingsPageDrawsItInChief: replaces the test that expected the bubble style row in Agents.HomeChiefSettingsViewTests.allChiefSettingsOpensTheSettingsPage: the popover's link is visible, is named for VoiceOver, and runsonAllSettings.webviews/src/pages/settings/categories.test.ts: the approved category order now includeschief.Observed / Not run
prepush-gate.py(no new violations),scripts/web-lint.sh(passed),count-swift-code-lines.py(CmuxNextApp 95441 source lines, the same as the base).77d7bdf618and the green run on the head.Risk: normal (Settings layout and one popover link; no policy or data change).
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Settings gains a Chief page holding every Chief setting, and the Chief name-pill popover links to it. The Chiefs list, Chief Chat, and Chief Pet rows move from the bottom of Agents into a new Settings > Chief category, right after Agents, with the pet card leading after the Chiefs list. The popover keeps its quick settings and adds an "All Chief Settings…" link that opens the page; the release note's action opens Settings.
HomeChiefHostLinemoves fromCmuxNextApptoCmuxNextHomeEngineso the app's source lines stay level.Not in this PR: the cloud Chief popover issue (#22602) and new settings like notices, voice, approvals, and history import, none of which are settings today.
Written for commit 1f63a5c. Summary will update on new commits.