Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci-guards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,10 @@ jobs:
if: ${{ matrix.group == 'ci' }}
run: python3 tests/test_ci_admission_placement.py

- name: Validate that roll-up gates never read an absent signal as green
if: ${{ matrix.group == 'ci' }}
run: python3 tests/test_ci_gate_absent_signal.py

- name: Validate the Linux tests dispatch lane
if: ${{ matrix.group == 'ci' }}
run: python3 tests/test_linux_tests_lane.py
Expand Down
35 changes: 35 additions & 0 deletions .github/workflows/ci-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4781,8 +4781,14 @@ jobs:

macos-status:
name: macOS status
# The placement jobs are here only so the gate verdict can read the `if:`
# of the jobs that need them. They are best effort (a 3-minute timeout or
# a lost runner can end them cancelled or failed), so the verdict step
# names them --context-only and never judges their own result.
needs:
- admission-placement
- macos-compile-admission
- late-placement
- app-host-unit-tests
- cli-product-tests
- cli-regressions
Expand All @@ -4796,6 +4802,35 @@ jobs:
runs-on: ${{ github.repository_owner != 'manaflow-ai' && 'ubuntu-24.04' || github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository && !contains(fromJSON(inputs.owned_head_repos), github.event.pull_request.head.repo.full_name) && 'blacksmith-4vcpu-ubuntu-2404' || vars.LINUX_RUNNER || 'blacksmith-4vcpu-ubuntu-2404' }}
timeout-minutes: 5
steps:
# An absent signal must never read green. The steps below allow a
# `skipped` need, which is right only when that job's routing turned it
# off. This asks each skipped job's own `if:` whether it was selected,
# with the same needs, variables, inputs and event fields that decided
# it, and fails when a selected job never ran (scripts/ci/gate_verdict.py;
# tests/test_ci_gate_absent_signal.py walks the needs graph).
- name: Check out the gate verdict
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
sparse-checkout: |
scripts/ci/gate_verdict.py
.github/workflows/ci-macos.yml
sparse-checkout-cone-mode: false

- name: Every selected job reported
env:
GATE_NEEDS: ${{ toJSON(needs) }}
GATE_VARS: ${{ toJSON(vars) }}
GATE_INPUTS: ${{ toJSON(inputs) }}
GATE_GITHUB: >-
{"event_name": ${{ toJSON(github.event_name) }},
"repository": ${{ toJSON(github.repository) }},
"repository_owner": ${{ toJSON(github.repository_owner) }},
"run_attempt": ${{ toJSON(github.run_attempt) }},
"triggering_actor": ${{ toJSON(github.triggering_actor) }},
"event": {"pull_request": {"head": {"repo": {"full_name": ${{ toJSON(github.event.pull_request.head.repo.full_name) }}}}}}}
run: python3 scripts/ci/gate_verdict.py --workflow .github/workflows/ci-macos.yml --gate macos-status --context-only admission-placement,late-placement

# Compile-avoidance shadow (RFC #15391, Work 3). The package lane
# classifies the pull request's package edits; when every edited
# package kept its interface and the package tests passed, the app
Expand Down
29 changes: 29 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1749,6 +1749,35 @@ jobs:
# required check every pull request waits on.
timeout-minutes: 5
steps:
# An absent signal must never read green. The steps below allow a
# `skipped` need, which is right only when that job's routing turned it
# off. This asks each skipped job's own `if:` whether it was selected,
# with the same needs, variables, inputs and event fields that decided
# it, and fails when a selected job never ran (scripts/ci/gate_verdict.py;
# tests/test_ci_gate_absent_signal.py walks the needs graph).
- name: Check out the gate verdict
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
sparse-checkout: |
scripts/ci/gate_verdict.py
.github/workflows/ci.yml
sparse-checkout-cone-mode: false

- name: Every selected job reported
env:
GATE_NEEDS: ${{ toJSON(needs) }}
GATE_VARS: ${{ toJSON(vars) }}
GATE_INPUTS: ${{ toJSON(inputs) }}
GATE_GITHUB: >-
{"event_name": ${{ toJSON(github.event_name) }},
"repository": ${{ toJSON(github.repository) }},
"repository_owner": ${{ toJSON(github.repository_owner) }},
"run_attempt": ${{ toJSON(github.run_attempt) }},
"triggering_actor": ${{ toJSON(github.triggering_actor) }},
"event": {"pull_request": {"head": {"repo": {"full_name": ${{ toJSON(github.event.pull_request.head.repo.full_name) }}}}}}}
run: python3 scripts/ci/gate_verdict.py --workflow .github/workflows/ci.yml --gate ci-status

- name: Check platform workflow routing
env:
PLATFORM_NEEDS: ${{ toJSON(needs) }}
Expand Down
Loading