test(cmux-next): sidebar cards assert the shared card glass veil (base red) by teamleaderleo · Pull Request #22598 · manaflow-ai/cmux

teamleaderleo · 2026-10-20T21:06:03Z

SidebarCardSurfaceTests.theUpdateReadyCardSitsOnTheComposersSurface is red on feat-cmux-next (fleet tip check on 936bad8, step 42a180113a99a967bff08749): alpha off by 0.09 at :52 and RGB mismatch at :54.

Cause: 17228e1 ("restart cmux-tui to use new features, and one shared neutral glass for toasts, dialogs and cards", @lawrencecchen) intentionally moved CardSurfaceView from the composer's 13% text fill to the neutral gray veil of FloatingGlassStyle.card (user 2026-10-20, after Rex). On the purple dark theme the card now draws 0.22 alpha gray, the test still expected 0.13 theme text. The new design already has its own test (FloatingGlassStyleTests.theSidebarCardDrawsTheNeutralVeilAndRim). Neither #22566 nor #22488 caused it.

Fix: test only. Both sidebar card tests now expect CardSurfaceView.style.look(isDark:).veil for the card's appearance, with the same 0.01 tolerance, so the Update Ready and notice cards are still checked to share one surface. Renamed to ...SitsOnTheSharedCardSurface. No source change.

@lawrencecchen: this follows your 17228e1 design; shout if the cards were meant to keep the composer fill.

Verification (fleet, package-test-lane.sh suite Packages/macOS/CmuxNext CmuxNextAppTests):

before, on 91f5909: step cd3f4997c9fe3a8136a2e071
after, on this branch: step c6ae74727c17f4af181d304d

Changelog

none

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

Fixes the failing SidebarCardSurfaceTests after the card surface moved from the composer's 13% text fill to the shared neutral gray veil of FloatingGlassStyle.card.

Updates both sidebar card tests to assert CardSurfaceView.style.look(isDark:).veil as the card's appearance, with the same 0.01 tolerance.
Renames the tests to ...SitsOnTheSharedCardSurface to match the new design.
No source code changes.

^{Written for commit 78efb7a. Summary will update on new commits.}

… the composer fill 17228e1 moved CardSurfaceView from the composer's 13% text fill to the neutral veil of FloatingGlassStyle.card (user 2026-10-20, after Rex), but SidebarCardSurfaceTests still expected the old fill, so the Update Ready card read 0.22 opaque instead of 0.13 on the purple dark theme. The tests now expect CardSurfaceView.style's veil for the card's appearance, with the same 0.01 tolerance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

github-actions · 2026-10-20T21:06:20Z

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 78efb7a: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22598 -f ref=fix-sidebar-card-surface-base-red -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 78efb7a9df; ci-status is green without them.

CI passes on 78efb7a9df (run 39499566745 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on c09af9b to compare; do not merge until green; see lane-rules

teamleaderleo · 2026-10-20T21:10:34Z

Bead cx-a01ct created for this PR by the cmux coordinator.

cursor · 2026-10-20T21:14:19Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

teamleaderleo · 2026-10-20T21:14:36Z

cmux-next guards / defaults-snapshot is red on 16 of 16 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

cursor · 2026-10-20T21:20:34Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

blacksmith-sh · 2026-10-20T21:32:49Z

Found 67 test failures on Blacksmith runners:

Failures

Test	View Logs
`/tmp/tmpc1v0maik/summary-fail.json (live):/summary-fail.json (live):`	View Logs
`/tmp/tmprrt983c_/summary-missing.json (live):/summary-missing.json (live):`	View Logs
`test_push_needs_a_patch_and_a_same_repository_head (main.PushGateTests.test_push_ne` `eds_a_patch_and_a_same_repository_head)/` `test_push_needs_a_patch_and_a_same_repository_head (main.PushGateTests.test_push_ne` `eds_a_patch_and_a_same_repository_head)`	View Logs
`test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='cancelled', repair='cancelled')/` `test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='cancelled', repair='cancelled')`	View Logs
`test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='cancelled', repair='failure')/` `test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='cancelled', repair='failure')`	View Logs
`test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='cancelled', repair='skipped')/` `test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='cancelled', repair='skipped')`	View Logs
`test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='cancelled', repair='success')/` `test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='cancelled', repair='success')`	View Logs
`test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='failure', repair='cancelled')/` `test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='failure', repair='cancelled')`	View Logs
`test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='failure', repair='failure')/` `test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='failure', repair='failure')`	View Logs
`test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='failure', repair='skipped')/` `test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or_not_needed (mai` `n``.PushGateTests.test_push_runs_only_after_the_areas_were_read_and_the_exports_made_or` `_not_needed) (areas='cancelled', exports='failure', repair='skipped')`	View Logs

...and 57 more test failures. View all on Blacksmith

^{Need help on this PR? Tag @codesmith-bot with what you need.}

github-actions · 2026-10-20T22:54:31Z

Shipped in:

cmux NEXT nightly 1.0.0-nightly.3950702982701 (333f97397c)
cmux NEXT nightly 1.0.0-nightly.3950883020001 (3cc9733dfc)
cmux NEXT nightly 1.0.0-nightly.3950982952501 (d5829ffea0)

This comment has been minimized.

Sign in to view

Merge branch 'feat-cmux-next' into fix-sidebar-card-surface-base-red

5a6b330

Merge branch 'feat-cmux-next' into fix-sidebar-card-surface-base-red

78efb7a

teamleaderleo merged commit 4fd74ff into feat-cmux-next Oct 20, 2026

teamleaderleo deleted the fix-sidebar-card-surface-base-red branch October 20, 2026 21:31

Navigation Menu

Repository navigation

test(cmux-next): sidebar cards assert the shared card glass veil (base red) - #22598

test(cmux-next): sidebar cards assert the shared card glass veil (base red)#22598
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
fix-sidebar-card-surface-base-red

teamleaderleo commented Oct 20, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

github-actions Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

teamleaderleo commented Oct 20, 2026

Uh oh!

cursor Bot commented Oct 20, 2026

Uh oh!

teamleaderleo commented Oct 20, 2026

Uh oh!

cursor Bot commented Oct 20, 2026

Uh oh!

blacksmith-sh Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 20, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Summary by cubic

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

teamleaderleo commented Oct 20, 2026

Uh oh!

cursor Bot commented Oct 20, 2026

Bugbot needs on-demand usage enabled

Uh oh!

teamleaderleo commented Oct 20, 2026

Uh oh!

cursor Bot commented Oct 20, 2026

Bugbot needs on-demand usage enabled

Uh oh!

blacksmith-sh Bot commented Oct 20, 2026

Failures

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 20, 2026 •

edited by cubic-dev-ai Bot

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading