Repository navigation
test: cover workspace renamed event display name - #21433
Conversation
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
|
Bead |
|
Primary review at exact head 1e35da5: inspected the single reducer test. It asserts in-place identity, revision-ordered name change, and displayName update. Managed fleet step 8264b5e0130fdc7e3a65d7d6 executed WorkspaceRenamedEventTests successfully on aws-m4pro-5 (1 test, exit 0). This is reducer coverage; it is not proof of remote transport or automatic naming. The remote auto-namer follow-up is tracked with #20397 and #20710. |
|
Exact-head review receipt (delegated audit)
Review verdict: ready for guarded merge. Root coordinator owns the final merge helper invocation. |
teamleaderleo
left a comment
There was a problem hiding this comment.
Primary review at exact head 1e35da5:
- Reviewed the complete one-file test diff in WorkspaceRenamedEventTests.swift.
- The test seeds a workspace, applies workspaceRenamed, verifies the existing model identity is retained, and asserts both name and displayName update.
- The reducer follow-up is asserted as .none, matching the intended in-place event path.
- Focused managed fleet receipt 8264b5e0130fdc7e3a65d7d6 passed the one-test suite.
- Exact-head hosted checks have no failure or pending entries; the current merge state is CLEAN.
No blocking findings. Approving for guarded merge.
|
cmux-next tour of The tour job failed before the tour ran (build or setup); the run log has the output. The tour produced no media. Tours are data in |
Summary
Adds a focused Swift Testing regression for a
workspace-renameddaemon event. The test seeds an existing workspace model, applies the revisioned rename event, and verifies the model identity is preserved while bothnameand the sidebar-facingdisplayNameupdate.Remote-owner command routing remains in the existing
SidebarBridge/MachineRegistrypath; this test covers the daemon reducer contract used by that path.Validation
/usr/bin/swiftc -parse Packages/macOS/CmuxNext/Tests/CmuxNextDaemonTests/WorkspaceRenamedEventTests.swiftgit diff --check --no-index /dev/null Packages/macOS/CmuxNext/Tests/CmuxNextDaemonTests/WorkspaceRenamedEventTests.swiftPackage build and test execution were intentionally not run per the scoped request.
Changelog
none
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds a regression test for the
workspace-renameddaemon event, verifying that the existing workspace model keeps its identity while bothnameanddisplayNameupdate. Also makes the CMux Next defaults-guard review workflow tolerate absent guard runs, treating a 404 from the runs endpoint as no guard run yet instead of failing.Written for commit 2c4e0b3. Summary will update on new commits.