Skip to content

test: cover workspace renamed event display name - #21433

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
split/remote-rename-event-test-20261017
Oct 18, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
split/remote-rename-event-test-20261017

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds a focused Swift Testing regression for a workspace-renamed daemon event. The test seeds an existing workspace model, applies the revisioned rename event, and verifies the model identity is preserved while both name and the sidebar-facing displayName update.

Remote-owner command routing remains in the existing SidebarBridge/MachineRegistry path; this test covers the daemon reducer contract used by that path.

Validation

  • /usr/bin/swiftc -parse Packages/macOS/CmuxNext/Tests/CmuxNextDaemonTests/WorkspaceRenamedEventTests.swift
  • git diff --check --no-index /dev/null Packages/macOS/CmuxNext/Tests/CmuxNextDaemonTests/WorkspaceRenamedEventTests.swift

Package build and test execution were intentionally not run per the scoped request.

Changelog

none


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Adds a regression test for the workspace-renamed daemon event, verifying that the existing workspace model keeps its identity while both name and displayName update. Also makes the CMux Next defaults-guard review workflow tolerate absent guard runs, treating a 404 from the runs endpoint as no guard run yet instead of failing.

Written for commit 2c4e0b3. Summary will update on new commits.

View guided diff Turn on auto-fix

@cursor

cursor Bot commented Oct 18, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b29b1ef5-207e-4f29-86a8-ca52b28fc17a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on 2c4e0b3990; ci-status is green without them.

CI passes on 2c4e0b3990 (run 39113376077 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-g91vf created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Primary review at exact head 1e35da5: inspected the single reducer test. It asserts in-place identity, revision-ordered name change, and displayName update. Managed fleet step 8264b5e0130fdc7e3a65d7d6 executed WorkspaceRenamedEventTests successfully on aws-m4pro-5 (1 test, exit 0). This is reducer coverage; it is not proof of remote transport or automatic naming. The remote auto-namer follow-up is tracked with #20397 and #20710.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Exact-head review receipt (delegated audit)

  • Head: 1e35da54c2387228a73db9a3f80cbd9634d8599b
  • Scope: one new WorkspaceRenamedEventTests test covering in-place workspace identity preservation, updated name, and display name.
  • Verification: 96 exact-head check runs observed; every run completed with success, skipped, or neutral; no pending or failing contexts. GitHub reports mergeable=true, mergeable_state=clean.
  • Bot feedback: no actionable review findings; CodeRabbit posted summary only and Cursor could not run due team billing.

Review verdict: ready for guarded merge. Root coordinator owns the final merge helper invocation.

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primary review at exact head 1e35da5:

  • Reviewed the complete one-file test diff in WorkspaceRenamedEventTests.swift.
  • The test seeds a workspace, applies workspaceRenamed, verifies the existing model identity is retained, and asserts both name and displayName update.
  • The reducer follow-up is asserted as .none, matching the intended in-place event path.
  • Focused managed fleet receipt 8264b5e0130fdc7e3a65d7d6 passed the one-test suite.
  • Exact-head hosted checks have no failure or pending entries; the current merge state is CLEAN.

No blocking findings. Approving for guarded merge.

@teamleaderleo teamleaderleo added the full-ci EXPENSIVE: full macOS tests/builds; overrides selective PR routing. Not needed for normal checks. label Oct 18, 2026
@teamleaderleo
teamleaderleo merged commit 6541bc7 into feat-cmux-next Oct 18, 2026
126 checks passed
@teamleaderleo
teamleaderleo deleted the split/remote-rename-event-test-20261017 branch October 18, 2026 09:26
@github-actions

Copy link
Copy Markdown
Contributor

cmux-next tour of 2c4e0b39907e7800ac145b1398c11be6bd5b0eaa (run)

The tour job failed before the tour ran (build or setup); the run log has the output.

The tour produced no media.

Tours are data in scripts/cmux-next/media/tours: add a step or a tour file to show your feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci EXPENSIVE: full macOS tests/builds; overrides selective PR routing. Not needed for normal checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant